c950316378277c190f9a5322f6577dfbcb08fbd3: Bug 1766889 - Fix insertRule with layer statements before imports. r=firefox-style-system-reviewers,layout-reviewers,boris
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Apr 2022 11:29:37 +0000 - rev 615683
Push 161950 by ealvarez@mozilla.com at Fri, 29 Apr 2022 11:31:57 +0000
Bug 1766889 - Fix insertRule with layer statements before imports. r=firefox-style-system-reviewers,layout-reviewers,boris We need to do a bit more nuanced check because @layer statements might go before imports. Differential Revision: https://phabricator.services.mozilla.com/D144996
57d322f6e79538816837e099b7dedcc02514f7f9: Bug 1766885 - Fix a flaky @layer test. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Apr 2022 11:28:18 +0000 - rev 615682
Push 161949 by ealvarez@mozilla.com at Fri, 29 Apr 2022 11:30:41 +0000
Bug 1766885 - Fix a flaky @layer test. r=dholbert @import loads are async per spec, so we need to wait for the style element's load event. Differential Revision: https://phabricator.services.mozilla.com/D144992
2134212765b907a4c37c4e082bf5adf2816e8029: Backed out changeset 5d44356db349 (bug 1763527) for causing build bustages. CLOSED TREE
Butkovits Atila <abutkovits@mozilla.com> - Fri, 29 Apr 2022 13:41:02 +0300 - rev 615681
Push 161948 by abutkovits@mozilla.com at Fri, 29 Apr 2022 10:41:55 +0000
Backed out changeset 5d44356db349 (bug 1763527) for causing build bustages. CLOSED TREE
5d44356db349c073cdb7453b1200f7b9f0a68498: Bug 1763527 - Remove OPAQUE_RESPONSE_BLOCKING* probes. r=necko-reviewers,kershaw
Andreas Farre <farre@mozilla.com> - Fri, 29 Apr 2022 10:27:50 +0000 - rev 615680
Push 161947 by afarre@mozilla.com at Fri, 29 Apr 2022 10:30:16 +0000
Bug 1763527 - Remove OPAQUE_RESPONSE_BLOCKING* probes. r=necko-reviewers,kershaw Differential Revision: https://phabricator.services.mozilla.com/D144791
b5dd1087ada0c883c3915aa351000806e51a74bf: Bug 1763526 - Extend telemetry SERVICE_WOREKER_RUNNING to Firefox 105. r=dom-worker-reviewers,smaug
Eden Chuang <echuang@mozilla.com> - Fri, 29 Apr 2022 10:23:07 +0000 - rev 615679
Push 161946 by echuang@mozilla.com at Fri, 29 Apr 2022 10:25:46 +0000
Bug 1763526 - Extend telemetry SERVICE_WOREKER_RUNNING to Firefox 105. r=dom-worker-reviewers,smaug Differential Revision: https://phabricator.services.mozilla.com/D144709
d235e07d431b847d5e2d4b5a4cb04091de21292d: Bug 1763525 - Extend telemetry SERVICE_WORKER_LIFE_TIME to Firefox 105. r=dom-worker-reviewers,smaug
Eden Chuang <echuang@mozilla.com> - Fri, 29 Apr 2022 10:22:53 +0000 - rev 615678
Push 161945 by echuang@mozilla.com at Fri, 29 Apr 2022 10:25:17 +0000
Bug 1763525 - Extend telemetry SERVICE_WORKER_LIFE_TIME to Firefox 105. r=dom-worker-reviewers,smaug Differential Revision: https://phabricator.services.mozilla.com/D144708
8222bc88ad9b5f4855156c6cef097f97ca2214fd: Bug 1765913 - Stop using jsm extension for non-JSM files in osfile. r=barret
Tooru Fujisawa <arai_a@mac.com> - Fri, 29 Apr 2022 10:10:24 +0000 - rev 615677
Push 161944 by arai_a@mac.com at Fri, 29 Apr 2022 10:12:45 +0000
Bug 1765913 - Stop using jsm extension for non-JSM files in osfile. r=barret Differential Revision: https://phabricator.services.mozilla.com/D144941
344c426713d991ece5c263e835c35bbd1c876690: Bug 1766156 - stop adding '#general' to the about:preferences URL when going back to the main pane, to fix back/fwd navigation, r=sclements,preferences-reviewers,jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 29 Apr 2022 10:09:22 +0000 - rev 615676
Push 161943 by gijskruitbosch@gmail.com at Fri, 29 Apr 2022 10:11:43 +0000
Bug 1766156 - stop adding '#general' to the about:preferences URL when going back to the main pane, to fix back/fwd navigation, r=sclements,preferences-reviewers,jaws Differential Revision: https://phabricator.services.mozilla.com/D144993
ecbff21b8699e0cfd9f4eaf645b85f0f13cec810: Merge mozilla-central to autoland. CLOSED TREE
Butkovits Atila <abutkovits@mozilla.com> - Fri, 29 Apr 2022 12:59:59 +0300 - rev 615675
Push 161942 by abutkovits@mozilla.com at Fri, 29 Apr 2022 10:00:45 +0000
Merge mozilla-central to autoland. CLOSED TREE
a3002a9b4204308cd68ca46d7aeb140f0ba497f7: Merge autoland to mozilla-central. a=merge
Butkovits Atila <abutkovits@mozilla.com> - Fri, 29 Apr 2022 12:46:43 +0300 - rev 615674
Push 161942 by abutkovits@mozilla.com at Fri, 29 Apr 2022 10:00:45 +0000
Merge autoland to mozilla-central. a=merge
3455eb78751d07995448a6e7e0bad70f28ee20f9: no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD
Mozilla Releng Treescript <release+treescript@mozilla.org> - Fri, 29 Apr 2022 06:57:32 +0000 - rev 615673
Push 161942 by abutkovits@mozilla.com at Fri, 29 Apr 2022 10:00:45 +0000
no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD en-CA -> 7d5308ba18bcbd253d477df36202ccb430b583d2 es-AR -> d4ac90fa01073352ed7a63cf861c7b0953ce838d et -> 9e73523ffc296ba5c7b7f0e9fbf1cb1626f03e61 eu -> 1b765f983a35b470ff6fc01d9466e2f11c23b08e hye -> f8581fe2688b399ad2d9f5c568589784475e0a83 kab -> 582e8dc1edf7209cb86dd25c86aea44ed5e7f7cc nl -> 34e328c73b8dd181352b2b24670d460e812f6aa2 tg -> f3c64f9a633318e87cf26f84db537628fb356a29 vi -> 2bcfc3d6d0c5b88e3f10622db222842d9ac05bec zh-CN -> ff71610322e791a08d55afea30bb4779f8f94cf8
624ae1b1ac6520a02172c8df3d805b48cd30ee96: Bug 1766377 - Fix remaining sign-compare warnings in Windows builds. r=rkraesig,gsvelto,media-playback-reviewers,gfx-reviewers,bryce,sotaro
Mike Hommey <mh+mozilla@glandium.org> - Fri, 29 Apr 2022 09:14:12 +0000 - rev 615672
Push 161941 by mh@glandium.org at Fri, 29 Apr 2022 09:23:14 +0000
Bug 1766377 - Fix remaining sign-compare warnings in Windows builds. r=rkraesig,gsvelto,media-playback-reviewers,gfx-reviewers,bryce,sotaro browser/components/shell/WindowsUserChoice.cpp(233,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare] for (int j = 0; j < DWORDS_PER_BLOCK; ++j) { ~ ^ ~~~~~~~~~~~~~~~~ browser/components/shell/WindowsUserChoice.cpp(388,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(exts); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~ browser/components/shell/nsWindowsShellService.cpp(1225,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(shortcutCSIDLs); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ browser/components/shell/nsWindowsShellService.cpp(1492,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(folders); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~ dom/media/platforms/wmf/MFTDecoder.cpp(85,23): error: comparison of integers of different signs: 'int' and 'UINT32' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 1; i < actsNum; i++) { ~ ^ ~~~~~~~ gfx/2d/Factory.cpp(1276,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int y = 0; y < height; y++) { ~ ^ ~~~~~~ gfx/layers/d3d11/CompositorD3D11.cpp(1096,36): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] swapDesc.BufferDesc.Height == mSize.height) || ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ gfx/layers/d3d11/CompositorD3D11.cpp(1095,35): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] if (((swapDesc.BufferDesc.Width == mSize.width && ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ gfx/layers/d3d11/TextureD3D11.cpp(1278,30): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] currentDesc.Height != mSize.height || ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ gfx/layers/d3d11/TextureD3D11.cpp(1277,29): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] if (currentDesc.Width != mSize.width || ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ gfx/layers/ipc/ContentCompositorBridgeParent.cpp(248,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'int32_t' (aka 'int') [-Werror,-Wsign-compare] if (sequenceNum == status.sequenceNumber() && !dm->HasDeviceReset()) { ~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~ gfx/thebes/D3D11Checks.cpp(129,21): error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare] if (resultColor != 0xffffff00) { ~~~~~~~~~~~ ^ ~~~~~~~~~~ gfx/thebes/D3D11Checks.cpp(154,23): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < PR_ARRAY_SIZE(checkModules); i += 1) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ gfx/thebes/D3D11Checks.cpp(409,14): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'UINT' (aka 'unsigned int') [-Werror,-Wsign-compare] if (vendor != desc.VendorId) { ~~~~~~ ^ ~~~~~~~~~~~~~ gfx/thebes/gfxDWriteFontList.cpp(1248,39): error: comparison of integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare] addFamily(names[index], index != sysLocIndex); ~~~~~ ^ ~~~~~~~~~~~ intl/lwbrk/nsUniscribeBreaker.cpp(121,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < aLength; ++i) { ~ ^ ~~~~~~~ intl/lwbrk/nsUniscribeBreaker.cpp(132,23): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < aLength; ++i) { ~ ^ ~~~~~~~ intl/lwbrk/nsUniscribeBreaker.cpp(138,23): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < aLength; ++i) { ~ ^ ~~~~~~~ mozglue/misc/PreXULSkeletonUI.cpp(319,26): error: comparison of integers of different signs: 'std::basic_string<char>::size_type' (aka 'unsigned long long') and 'int' [-Werror,-Wsign-compare] while (line.length() > whitespace && ~~~~~~~~~~~~~ ^ ~~~~~~~~~~ mozglue/misc/PreXULSkeletonUI.cpp(1003,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 1; i < noPlaceholderSpans.length(); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ mozglue/misc/PreXULSkeletonUI.cpp(1708,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < dataLen / (2 * sizeof(double)); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ security/sandbox/chromium-shim/sandbox/win/permissionsService.cpp(40,16): error: comparison of integers of different signs: 'int' and 'const std::basic_string<wchar_t>::size_type' (aka 'const unsigned long long') [-Werror,-Wsign-compare] if (slashIdx != std::wstring::npos) { ~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~ toolkit/components/aboutthirdparty/tests/gtest/TestAboutThirdParty.cpp(107,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kDirectoriesUnsorted); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/breakpad-client/windows/crash_generation/crash_generation_server.cc(957,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < kExceptionAppMemoryRegions; i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/client/crashreporter_win.cpp(373,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < sizeof(kDefaultAttachedBottom) / sizeof(UINT); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/client/crashreporter_win.cpp(671,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < sizeof(controls) / sizeof(controls[0]); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/client/crashreporter_win.cpp(1048,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < sizeof(kDefaultAttachedBottom) / sizeof(UINT); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/mozapps/defaultagent/SetDefaultBrowser.cpp(248,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < mozilla::ArrayLength(associations); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/system/windowsproxy/ProxyUtils.cpp(27,36): error: comparison of integers of different signs: 'const int' and 'nsTArray_base::size_type' (aka 'unsigned long long') [-Werror,-Wsign-compare] if (i < addr.Length()) { ~ ^ ~~~~~~~~~~~~~ toolkit/xre/dllservices/mozglue/interceptor/Arm64.h(178,28): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare] if (signbits && signbits != 0xFE000000) { ~~~~~~~~ ^ ~~~~~~~~~~ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned int, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(35,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned int, int, nullptr>' requested here EXPECT_EQ(mCounters.Count(), N); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(210,28): note: in instantiation of function template specialization 'ModuleLoadCounter::Remains<1>' requested here EXPECT_TRUE(waitForOne.Remains({kTestModules[0]}, {0})); ^ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(139,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(151,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(164,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const int' and 'const unsigned long long' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned long long>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(138,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<int, unsigned long long, nullptr>' requested here EXPECT_EQ(len, ArrayLength(kExpectedArgsW)); ^ widget/windows/TSFTextStore.cpp(3455,28): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'long' [-Werror,-Wsign-compare] range.mEndOffset == end - mComposition->StartOffset() && ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ widget/windows/TSFTextStore.cpp(3454,30): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'long' [-Werror,-Wsign-compare] if (range.mStartOffset == start - mComposition->StartOffset() && ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ xpfe/appshell/AppWindow.cpp(1900,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < toolbarSprings->Length(); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~ Differential Revision: https://phabricator.services.mozilla.com/D144695
6a5aa84bce701cabcc34bb63104d3941f528213d: Bug 1766377 - Fix sign-compare warnings related to constants in gtests. r=nika,mossop
Mike Hommey <mh+mozilla@glandium.org> - Fri, 29 Apr 2022 09:14:12 +0000 - rev 615671
Push 161941 by mh@glandium.org at Fri, 29 Apr 2022 09:23:14 +0000
Bug 1766377 - Fix sign-compare warnings related to constants in gtests. r=nika,mossop obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare] GTEST_IMPL_CMP_HELPER_(GT, >) ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ obj-build/dist/include/gtest/gtest.h(1422,14): note: expanded from macro 'GTEST_IMPL_CMP_HELPER_' if (val1 op val2) { \ ~~~~ ^ ~~~~ toolkit/system/windowsPackageManager/tests/gtest/TestWindowsPackageManager.cpp(22,3): note: in instantiation of function template specialization 'testing::internal::CmpHelperGT<unsigned long long, int>' requested here ASSERT_GT(packages.Length(), 0); ^ obj-build/dist/include/gtest/gtest.h(1891,31): note: expanded from macro 'ASSERT_GT' ^ obj-build/dist/include/gtest/gtest.h(1865,44): note: expanded from macro 'GTEST_ASSERT_GT' ASSERT_PRED_FORMAT2(::testing::internal::CmpHelperGT, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long long, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/system/windowsPackageManager/tests/gtest/TestWindowsPackageManager.cpp(33,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long long, int, nullptr>' requested here ASSERT_EQ(packages.Length(), 0); ^ obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ' ^ obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/system/windowsDHCPClient/tests/gtest/TestDHCPUtils.cpp(232,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<int, unsigned int, nullptr>' requested here ASSERT_EQ(0, size); ^ obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ' ^ obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned int, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/mozapps/defaultagent/tests/gtest/CacheTest.cpp(67,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned int, int, nullptr>' requested here ASSERT_EQ(Cache::kDefaultCapacity, 2); ^ obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ' ^ obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare] GTEST_IMPL_CMP_HELPER_(GT, >) ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ obj-build/dist/include/gtest/gtest.h(1422,14): note: expanded from macro 'GTEST_IMPL_CMP_HELPER_' if (val1 op val2) { \ ~~~~ ^ ~~~~ toolkit/xre/dllservices/tests/gtest/TestDLLBlocklist.cpp(123,5): note: in instantiation of function template specialization 'testing::internal::CmpHelperGT<unsigned long long, int>' requested here EXPECT_GT(strlen(pEntry->mName), 3); ^ obj-build/dist/include/gtest/gtest.h(1852,44): note: expanded from macro 'EXPECT_GT' EXPECT_PRED_FORMAT2(::testing::internal::CmpHelperGT, val1, val2) ^ In file included from Unified_cpp_xpcom_tests_gtest0.cpp:2: In file included from xpcom/tests/gtest/Helpers.cpp:12: obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long long, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ xpcom/tests/gtest/TestAvailableMemoryWatcherWin.cpp(483,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long long, int, nullptr>' requested here EXPECT_EQ(tokens.Length(), 3); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long long, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(211,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long long, int, nullptr>' requested here EXPECT_EQ(collector.Data().length(), 1); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned int, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(310,7): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned int, int, nullptr>' requested here EXPECT_EQ(evt.mLoadStatus, 0); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare] GTEST_IMPL_CMP_HELPER_(GT, >) ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ obj-build/dist/include/gtest/gtest.h(1422,14): note: expanded from macro 'GTEST_IMPL_CMP_HELPER_' if (val1 op val2) { \ ~~~~ ^ ~~~~ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(332,3): note: in instantiation of function template specialization 'testing::internal::CmpHelperGT<unsigned int, int>' requested here EXPECT_GT(aData.mNumEvents, 0); ^ obj-build/dist/include/gtest/gtest.h(1852,44): note: expanded from macro 'EXPECT_GT' EXPECT_PRED_FORMAT2(::testing::internal::CmpHelperGT, val1, val2) ^ Differential Revision: https://phabricator.services.mozilla.com/D144694
9ac10050264fdc49588b2348e3329afaf67a66e0: Bug 1766377 - Fix sign-compare warnings related to IDL constants. r=anti-tracking-reviewers,necko-reviewers,kershaw,timhuang
Mike Hommey <mh+mozilla@glandium.org> - Fri, 29 Apr 2022 09:14:11 +0000 - rev 615670
Push 161941 by mh@glandium.org at Fri, 29 Apr 2022 09:23:14 +0000
Bug 1766377 - Fix sign-compare warnings related to IDL constants. r=anti-tracking-reviewers,necko-reviewers,kershaw,timhuang dom/network/TCPSocket.cpp(973,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsISocketTransport::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsISocketTransport.h:102:3)' [-Werror,-Wsign-compare] if (static_cast<uint32_t>(aStatus) != ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ dom/security/ReferrerInfo.cpp(216,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare] rejectedReason != ~~~~~~~~~~~~~~ ^ toolkit/components/antitracking/StorageAccess.cpp(175,23): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare] if (aRejectedReason == ~~~~~~~~~~~~~~~ ^ toolkit/components/antitracking/StorageAccess.cpp(415,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare] aRejectedReason == ~~~~~~~~~~~~~~~ ^ toolkit/components/antitracking/StorageAccess.cpp(428,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare] return aRejectedReason == ~~~~~~~~~~~~~~~ ^ Differential Revision: https://phabricator.services.mozilla.com/D144693
38403cbd82e61b2fe9bcb89a6e9dc09f59872c19: Bug 1766377 - Fix sign-compare warnings related to Windows constants. r=rkraesig,gfx-reviewers,sotaro
Mike Hommey <mh+mozilla@glandium.org> - Fri, 29 Apr 2022 09:14:11 +0000 - rev 615669
Push 161941 by mh@glandium.org at Fri, 29 Apr 2022 09:23:14 +0000
Bug 1766377 - Fix sign-compare warnings related to Windows constants. r=rkraesig,gfx-reviewers,sotaro obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, long>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/components/maintenanceservice/tests/gtest/ServiceStartInteractiveOnly.cpp(51,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, long, nullptr>' requested here ASSERT_EQ(GetLastError(), ERROR_ACCESS_DENIED); ^ obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ' ^ obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, long>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/library/gtest/TestUCRTDepends.cpp(52,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, long, nullptr>' requested here EXPECT_EQ(GetLastError(), ERROR_FILE_NOT_FOUND); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ ipc/chromium/src/base/thread_local_win.cc(18,14): error: comparison of integers of different signs: 'base::ThreadLocalPlatform::SlotType' (aka 'int') and 'DWORD' (aka 'unsigned long') [-Werror,-Wsign-compare] CHECK(slot != TLS_OUT_OF_INDEXES); ~~~~ ^ ~~~~~~~~~~~~~~~~~~ ipc/glue/WindowsMessageLoop.cpp(381,44): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] if (objId == OBJID_CLIENT || objId == MOZOBJID_UIAROOT) { ~~~~~ ^ ~~~~~~~~~~~~~~~~ ipc/glue/WindowsMessageLoop.cpp(381,19): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'LONG' (aka 'long') [-Werror,-Wsign-compare] if (objId == OBJID_CLIENT || objId == MOZOBJID_UIAROOT) { ~~~~~ ^ ~~~~~~~~~~~~ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, long>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ xpcom/tests/windows/TestPoisonIOInterposer.cpp(108,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, long, nullptr>' requested here EXPECT_EQ(::GetLastError(), ERROR_IO_PENDING); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ gfx/thebes/gfxGDIFont.cpp(454,13): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'HRESULT' (aka 'long') [-Werror,-Wsign-compare] if (ret == E_PENDING) { ~~~ ^ ~~~~~~~~~ accessible/windows/msaa/Compatibility.cpp(120,21): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'HRESULT' (aka 'long') [-Werror,-Wsign-compare] if (exceptionCode == RPC_E_CANTCALLOUT_ININPUTSYNCCALL && NS_IsMainThread()) { ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ widget/windows/WinIMEHandler.cpp(166,35): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'LONG' (aka 'long') [-Werror,-Wsign-compare] static_cast<DWORD>(aLParam) == OBJID_CARET) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ widget/windows/nsWindow.cpp(541,37): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'LONG' (aka 'long') [-Werror,-Wsign-compare] static_cast<DWORD>(aLParam) != OBJID_CLIENT || ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ Differential Revision: https://phabricator.services.mozilla.com/D144692
583898d054c27f611fd4a7f787f43555aef89e06: Bug 1765336: Add IPC_FAIL conditions to RecvBlocked. r=dom-storage-reviewers,janv
Jens Stutte <jstutte@mozilla.com> - Fri, 29 Apr 2022 08:34:31 +0000 - rev 615668
Push 161940 by jstutte@mozilla.com at Fri, 29 Apr 2022 08:36:50 +0000
Bug 1765336: Add IPC_FAIL conditions to RecvBlocked. r=dom-storage-reviewers,janv Differential Revision: https://phabricator.services.mozilla.com/D144164
0203682dddbe6da4c331843a2dd8986e6da42052: Bug 1719560 - Collect timestamps for all collections r=robwu
Mathieu Leplatre <mathieu@mozilla.com> - Fri, 29 Apr 2022 08:07:26 +0000 - rev 615667
Push 161939 by mleplatre@mozilla.com at Fri, 29 Apr 2022 08:34:37 +0000
Bug 1719560 - Collect timestamps for all collections r=robwu Instead of having complex build scripts that have to introspect which dump is packaged on which platform and in which circumptances, the `last_modified.json` now contains the timestamps of all dumps files present in the source tree. Depends on D144428 Differential Revision: https://phabricator.services.mozilla.com/D144169
b25c6fb8520a4a4663127826d3c3fbcc4d7e195f: Bug 1725660 - Include timestamps in packaged dumps r=robwu
Mathieu Leplatre <mathieu@mozilla.com> - Fri, 29 Apr 2022 08:07:25 +0000 - rev 615666
Push 161939 by mleplatre@mozilla.com at Fri, 29 Apr 2022 08:34:37 +0000
Bug 1725660 - Include timestamps in packaged dumps r=robwu Since the dumps don't contain tombstones, this prevents situations where the dump would not be reloaded (with `loadDumpIfNewer`) if the last operation on the collection is a delete. Differential Revision: https://phabricator.services.mozilla.com/D144428
4dd9b8c7db91b12368449781cebf0041c96a600c: Backed out changeset 740c29a7efb2 (bug 1766797) for causing gtest failures in TestMediaDataDecoder. CLOSED TREE
Molnar Sandor <smolnar@mozilla.com> - Fri, 29 Apr 2022 11:26:41 +0300 - rev 615665
Push 161938 by smolnar@mozilla.com at Fri, 29 Apr 2022 08:30:44 +0000
Backed out changeset 740c29a7efb2 (bug 1766797) for causing gtest failures in TestMediaDataDecoder. CLOSED TREE
9ff6d8a5d9773f7f2c3772902baa813a2ddb4f5d: Backed out changeset 93d77cc28bbc (bug 1766630) for causing xpc failures in test_mdn-compatibility.js. CLOSED TREE
Molnar Sandor <smolnar@mozilla.com> - Fri, 29 Apr 2022 11:24:14 +0300 - rev 615664
Push 161938 by smolnar@mozilla.com at Fri, 29 Apr 2022 08:30:44 +0000
Backed out changeset 93d77cc28bbc (bug 1766630) for causing xpc failures in test_mdn-compatibility.js. CLOSED TREE
06e81bd27ede49b464c6e10812b82ab118f5bec2: Bug 1757144: Clarify that we already abort LS operations on InitiateShutdown. r=dom-storage-reviewers,janv
Jens Stutte <jstutte@mozilla.com> - Fri, 29 Apr 2022 07:35:39 +0000 - rev 615663
Push 161937 by jstutte@mozilla.com at Fri, 29 Apr 2022 07:37:58 +0000
Bug 1757144: Clarify that we already abort LS operations on InitiateShutdown. r=dom-storage-reviewers,janv Differential Revision: https://phabricator.services.mozilla.com/D139689
740c29a7efb270e5d6d49f48b099213493ff318d: Bug 1766797 Add AV1 test to TestMediaDataDecoder r=alwu
stransky <stransky@redhat.com> - Fri, 29 Apr 2022 07:29:51 +0000 - rev 615662
Push 161936 by stransky@redhat.com at Fri, 29 Apr 2022 07:32:16 +0000
Bug 1766797 Add AV1 test to TestMediaDataDecoder r=alwu Differential Revision: https://phabricator.services.mozilla.com/D144929
93d77cc28bbcffd583888ab019f309acd0fcb3c4: Bug 1766630 - [devtools] Update MDN compat data (2022 April). r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 29 Apr 2022 06:40:03 +0000 - rev 615661
Push 161935 by nchevobbe@mozilla.com at Fri, 29 Apr 2022 06:42:24 +0000
Bug 1766630 - [devtools] Update MDN compat data (2022 April). r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D144810
b18ab8c7fe5fc0762c5edb6335a6e46bd25e0646: Bug 1731298: Further audit accesses through mState variants. r=dom-worker-reviewers,asuth
Jens Stutte <jstutte@mozilla.com> - Fri, 29 Apr 2022 06:09:24 +0000 - rev 615660
Push 161934 by jstutte@mozilla.com at Fri, 29 Apr 2022 06:12:01 +0000
Bug 1731298: Further audit accesses through mState variants. r=dom-worker-reviewers,asuth Depends on D140302 Differential Revision: https://phabricator.services.mozilla.com/D140314
ca68786294025e0cc0fc5123530233fce44b46ba: Backed out 4 changesets (bug 1766377) for causing mochitest failures on HyperTextAccessible.cpp CLOSED TREE
Norisz Fay <nfay@mozilla.com> - Fri, 29 Apr 2022 07:35:11 +0300 - rev 615659
Push 161933 by nfay@mozilla.com at Fri, 29 Apr 2022 04:35:51 +0000
Backed out 4 changesets (bug 1766377) for causing mochitest failures on HyperTextAccessible.cpp CLOSED TREE Backed out changeset 6335511477a4 (bug 1766377) Backed out changeset e8108d6fab9f (bug 1766377) Backed out changeset 80d16d55c490 (bug 1766377) Backed out changeset 1a6583d6e52e (bug 1766377)
c6787fce55cf485f53ab852a70e811102ed244dd: Bug 1766912 - Avoid trying to insert NULLs into the sync bookmark itemsRemoved table. r=skhamis
Mark Hammond <mhammond@skippinet.com.au> - Fri, 29 Apr 2022 02:55:08 +0000 - rev 615658
Push 161932 by mhammond@mozilla.com at Fri, 29 Apr 2022 02:57:30 +0000
Bug 1766912 - Avoid trying to insert NULLs into the sync bookmark itemsRemoved table. r=skhamis Differential Revision: https://phabricator.services.mozilla.com/D145048
7891234e69fb71ab66dd112697493bb829798a23: Bug 1739560: Update line starts in the cache when they change. r=morgan
James Teh <jteh@mozilla.com> - Fri, 29 Apr 2022 00:44:11 +0000 - rev 615657
Push 161931 by jteh@mozilla.com at Fri, 29 Apr 2022 00:46:43 +0000
Bug 1739560: Update line starts in the cache when they change. r=morgan If text or bounds change, it's very likely that line starts have changed too, so we push an update for them. However, if a non-rectangular text span changes its line wrapping without changing its text, the bounds might not change. In that case, we still get a bounds cache update request; we just determine not to push bounds. This happens a lot, though. To limit this, we compare against the cached first line start in LocalAccessible and push an update only if it's different. If text and bounds both change, we don't want to push two separate cache updates. We use queued cache updates to prevent this. This necessitated moving where we send queued cache updates so that we do it before firing mutation events, since clients might need the text to be up to date when handling those events. Differential Revision: https://phabricator.services.mozilla.com/D144949
6335511477a464e13ccd21cbca2988b9a83d063c: Bug 1766377 - Fix remaining sign-compare warnings in Windows builds. r=rkraesig,gsvelto,media-playback-reviewers,gfx-reviewers,bryce,sotaro
Mike Hommey <mh+mozilla@glandium.org> - Fri, 29 Apr 2022 00:43:32 +0000 - rev 615656
Push 161930 by mh@glandium.org at Fri, 29 Apr 2022 00:46:11 +0000
Bug 1766377 - Fix remaining sign-compare warnings in Windows builds. r=rkraesig,gsvelto,media-playback-reviewers,gfx-reviewers,bryce,sotaro browser/components/shell/WindowsUserChoice.cpp(233,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare] for (int j = 0; j < DWORDS_PER_BLOCK; ++j) { ~ ^ ~~~~~~~~~~~~~~~~ browser/components/shell/WindowsUserChoice.cpp(388,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(exts); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~ browser/components/shell/nsWindowsShellService.cpp(1225,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(shortcutCSIDLs); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ browser/components/shell/nsWindowsShellService.cpp(1492,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(folders); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~ dom/media/platforms/wmf/MFTDecoder.cpp(85,23): error: comparison of integers of different signs: 'int' and 'UINT32' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 1; i < actsNum; i++) { ~ ^ ~~~~~~~ gfx/2d/Factory.cpp(1276,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int y = 0; y < height; y++) { ~ ^ ~~~~~~ gfx/layers/d3d11/CompositorD3D11.cpp(1096,36): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] swapDesc.BufferDesc.Height == mSize.height) || ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ gfx/layers/d3d11/CompositorD3D11.cpp(1095,35): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] if (((swapDesc.BufferDesc.Width == mSize.width && ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ gfx/layers/d3d11/TextureD3D11.cpp(1278,30): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] currentDesc.Height != mSize.height || ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ gfx/layers/d3d11/TextureD3D11.cpp(1277,29): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] if (currentDesc.Width != mSize.width || ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ gfx/layers/ipc/ContentCompositorBridgeParent.cpp(248,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'int32_t' (aka 'int') [-Werror,-Wsign-compare] if (sequenceNum == status.sequenceNumber() && !dm->HasDeviceReset()) { ~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~ gfx/thebes/D3D11Checks.cpp(129,21): error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare] if (resultColor != 0xffffff00) { ~~~~~~~~~~~ ^ ~~~~~~~~~~ gfx/thebes/D3D11Checks.cpp(154,23): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < PR_ARRAY_SIZE(checkModules); i += 1) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ gfx/thebes/D3D11Checks.cpp(409,14): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'UINT' (aka 'unsigned int') [-Werror,-Wsign-compare] if (vendor != desc.VendorId) { ~~~~~~ ^ ~~~~~~~~~~~~~ gfx/thebes/gfxDWriteFontList.cpp(1248,39): error: comparison of integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare] addFamily(names[index], index != sysLocIndex); ~~~~~ ^ ~~~~~~~~~~~ intl/lwbrk/nsUniscribeBreaker.cpp(121,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < aLength; ++i) { ~ ^ ~~~~~~~ intl/lwbrk/nsUniscribeBreaker.cpp(132,23): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < aLength; ++i) { ~ ^ ~~~~~~~ intl/lwbrk/nsUniscribeBreaker.cpp(138,23): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < aLength; ++i) { ~ ^ ~~~~~~~ mozglue/misc/PreXULSkeletonUI.cpp(319,26): error: comparison of integers of different signs: 'std::basic_string<char>::size_type' (aka 'unsigned long long') and 'int' [-Werror,-Wsign-compare] while (line.length() > whitespace && ~~~~~~~~~~~~~ ^ ~~~~~~~~~~ mozglue/misc/PreXULSkeletonUI.cpp(1003,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 1; i < noPlaceholderSpans.length(); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ mozglue/misc/PreXULSkeletonUI.cpp(1708,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < dataLen / (2 * sizeof(double)); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ security/sandbox/chromium-shim/sandbox/win/permissionsService.cpp(40,16): error: comparison of integers of different signs: 'int' and 'const std::basic_string<wchar_t>::size_type' (aka 'const unsigned long long') [-Werror,-Wsign-compare] if (slashIdx != std::wstring::npos) { ~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~ toolkit/components/aboutthirdparty/tests/gtest/TestAboutThirdParty.cpp(107,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kDirectoriesUnsorted); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/breakpad-client/windows/crash_generation/crash_generation_server.cc(957,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < kExceptionAppMemoryRegions; i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/client/crashreporter_win.cpp(373,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < sizeof(kDefaultAttachedBottom) / sizeof(UINT); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/client/crashreporter_win.cpp(671,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < sizeof(controls) / sizeof(controls[0]); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/client/crashreporter_win.cpp(1048,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < sizeof(kDefaultAttachedBottom) / sizeof(UINT); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/mozapps/defaultagent/SetDefaultBrowser.cpp(248,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < mozilla::ArrayLength(associations); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/system/windowsproxy/ProxyUtils.cpp(27,36): error: comparison of integers of different signs: 'const int' and 'nsTArray_base::size_type' (aka 'unsigned long long') [-Werror,-Wsign-compare] if (i < addr.Length()) { ~ ^ ~~~~~~~~~~~~~ toolkit/xre/dllservices/mozglue/interceptor/Arm64.h(178,28): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare] if (signbits && signbits != 0xFE000000) { ~~~~~~~~ ^ ~~~~~~~~~~ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned int, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(35,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned int, int, nullptr>' requested here EXPECT_EQ(mCounters.Count(), N); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(210,28): note: in instantiation of function template specialization 'ModuleLoadCounter::Remains<1>' requested here EXPECT_TRUE(waitForOne.Remains({kTestModules[0]}, {0})); ^ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(139,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(151,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(164,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const int' and 'const unsigned long long' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned long long>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(138,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<int, unsigned long long, nullptr>' requested here EXPECT_EQ(len, ArrayLength(kExpectedArgsW)); ^ widget/windows/TSFTextStore.cpp(3455,28): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'long' [-Werror,-Wsign-compare] range.mEndOffset == end - mComposition->StartOffset() && ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ widget/windows/TSFTextStore.cpp(3454,30): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'long' [-Werror,-Wsign-compare] if (range.mStartOffset == start - mComposition->StartOffset() && ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ xpfe/appshell/AppWindow.cpp(1900,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < toolbarSprings->Length(); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~ Differential Revision: https://phabricator.services.mozilla.com/D144695
e8108d6fab9fc9b368fc975ed8e492ba6ae34e3f: Bug 1766377 - Fix sign-compare warnings related to constants in gtests. r=nika,mossop
Mike Hommey <mh+mozilla@glandium.org> - Fri, 29 Apr 2022 00:43:32 +0000 - rev 615655
Push 161930 by mh@glandium.org at Fri, 29 Apr 2022 00:46:11 +0000
Bug 1766377 - Fix sign-compare warnings related to constants in gtests. r=nika,mossop obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare] GTEST_IMPL_CMP_HELPER_(GT, >) ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ obj-build/dist/include/gtest/gtest.h(1422,14): note: expanded from macro 'GTEST_IMPL_CMP_HELPER_' if (val1 op val2) { \ ~~~~ ^ ~~~~ toolkit/system/windowsPackageManager/tests/gtest/TestWindowsPackageManager.cpp(22,3): note: in instantiation of function template specialization 'testing::internal::CmpHelperGT<unsigned long long, int>' requested here ASSERT_GT(packages.Length(), 0); ^ obj-build/dist/include/gtest/gtest.h(1891,31): note: expanded from macro 'ASSERT_GT' ^ obj-build/dist/include/gtest/gtest.h(1865,44): note: expanded from macro 'GTEST_ASSERT_GT' ASSERT_PRED_FORMAT2(::testing::internal::CmpHelperGT, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long long, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/system/windowsPackageManager/tests/gtest/TestWindowsPackageManager.cpp(33,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long long, int, nullptr>' requested here ASSERT_EQ(packages.Length(), 0); ^ obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ' ^ obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/system/windowsDHCPClient/tests/gtest/TestDHCPUtils.cpp(232,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<int, unsigned int, nullptr>' requested here ASSERT_EQ(0, size); ^ obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ' ^ obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned int, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/mozapps/defaultagent/tests/gtest/CacheTest.cpp(67,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned int, int, nullptr>' requested here ASSERT_EQ(Cache::kDefaultCapacity, 2); ^ obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ' ^ obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare] GTEST_IMPL_CMP_HELPER_(GT, >) ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ obj-build/dist/include/gtest/gtest.h(1422,14): note: expanded from macro 'GTEST_IMPL_CMP_HELPER_' if (val1 op val2) { \ ~~~~ ^ ~~~~ toolkit/xre/dllservices/tests/gtest/TestDLLBlocklist.cpp(123,5): note: in instantiation of function template specialization 'testing::internal::CmpHelperGT<unsigned long long, int>' requested here EXPECT_GT(strlen(pEntry->mName), 3); ^ obj-build/dist/include/gtest/gtest.h(1852,44): note: expanded from macro 'EXPECT_GT' EXPECT_PRED_FORMAT2(::testing::internal::CmpHelperGT, val1, val2) ^ In file included from Unified_cpp_xpcom_tests_gtest0.cpp:2: In file included from xpcom/tests/gtest/Helpers.cpp:12: obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long long, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ xpcom/tests/gtest/TestAvailableMemoryWatcherWin.cpp(483,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long long, int, nullptr>' requested here EXPECT_EQ(tokens.Length(), 3); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long long, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(211,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long long, int, nullptr>' requested here EXPECT_EQ(collector.Data().length(), 1); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned int, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(310,7): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned int, int, nullptr>' requested here EXPECT_EQ(evt.mLoadStatus, 0); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare] GTEST_IMPL_CMP_HELPER_(GT, >) ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ obj-build/dist/include/gtest/gtest.h(1422,14): note: expanded from macro 'GTEST_IMPL_CMP_HELPER_' if (val1 op val2) { \ ~~~~ ^ ~~~~ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(332,3): note: in instantiation of function template specialization 'testing::internal::CmpHelperGT<unsigned int, int>' requested here EXPECT_GT(aData.mNumEvents, 0); ^ obj-build/dist/include/gtest/gtest.h(1852,44): note: expanded from macro 'EXPECT_GT' EXPECT_PRED_FORMAT2(::testing::internal::CmpHelperGT, val1, val2) ^ Differential Revision: https://phabricator.services.mozilla.com/D144694
80d16d55c4904f82a9f6c6312477e07532690a45: Bug 1766377 - Fix sign-compare warnings related to IDL constants. r=anti-tracking-reviewers,necko-reviewers,kershaw,timhuang
Mike Hommey <mh+mozilla@glandium.org> - Fri, 29 Apr 2022 00:43:31 +0000 - rev 615654
Push 161930 by mh@glandium.org at Fri, 29 Apr 2022 00:46:11 +0000
Bug 1766377 - Fix sign-compare warnings related to IDL constants. r=anti-tracking-reviewers,necko-reviewers,kershaw,timhuang dom/network/TCPSocket.cpp(973,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsISocketTransport::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsISocketTransport.h:102:3)' [-Werror,-Wsign-compare] if (static_cast<uint32_t>(aStatus) != ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ dom/security/ReferrerInfo.cpp(216,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare] rejectedReason != ~~~~~~~~~~~~~~ ^ toolkit/components/antitracking/StorageAccess.cpp(175,23): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare] if (aRejectedReason == ~~~~~~~~~~~~~~~ ^ toolkit/components/antitracking/StorageAccess.cpp(415,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare] aRejectedReason == ~~~~~~~~~~~~~~~ ^ toolkit/components/antitracking/StorageAccess.cpp(428,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare] return aRejectedReason == ~~~~~~~~~~~~~~~ ^ Differential Revision: https://phabricator.services.mozilla.com/D144693
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -30 +30 +50 +100 +300 +1000 +3000 +10000 tip