b1571c5221831c10d481fec95bdb889bfd32e7b4: Bug 1532695 - Include target.gtest.tests.tar.gz in android builds; r=bc
Geoff Brown <gbrown@mozilla.com> - Mon, 08 Apr 2019 20:16:43 +0000 - rev 468427
Push 82578 by gbrown@mozilla.com at Mon, 08 Apr 2019 20:17:33 +0000
Bug 1532695 - Include target.gtest.tests.tar.gz in android builds; r=bc Differential Revision: https://phabricator.services.mozilla.com/D26587
59ae6dc11ba316a178ebbb5ad65a809c9118d5a8: bug 1542836: toolkit/xre: format --MOZ_LOG and --MOZ_LOG_FILE help text; r=erahm
Andreas Tolfsen <ato@sny.no> - Mon, 08 Apr 2019 19:30:44 +0000 - rev 468426
Push 82577 by atolfsen@mozilla.com at Mon, 08 Apr 2019 20:07:29 +0000
bug 1542836: toolkit/xre: format --MOZ_LOG and --MOZ_LOG_FILE help text; r=erahm Produces a help text that conforms to the line width recommendations of nsICommandLine. On the other hand, the formatting of the source code itself is rendered rather ugly by clang-format. Differential Revision: https://phabricator.services.mozilla.com/D26583
69eda9f7be573886154815681f2a94b089eddf87: Bug 1540285 - Add a test generator script into `./mach addtest` r=ahal
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 08 Apr 2019 19:09:42 +0000 - rev 468425
Push 82576 by bgrinstead@mozilla.com at Mon, 08 Apr 2019 20:06:46 +0000
Bug 1540285 - Add a test generator script into `./mach addtest` r=ahal Instead of: perl gen_template.pl -b=123456 --type=plain > path/to/test_bug123456.html You can do: ./mach addtest --suite="mochitest-plain" > path/to/test_bug123456.html But you can also pass in a new file path and let it guess the suite/doc: ``` # mochitest-chrome tests ./mach addtest js/xpconnect/tests/chrome/test_chrome.html ./mach addtest js/xpconnect/tests/chrome/test_chrome.xhtml ./mach addtest js/xpconnect/tests/chrome/test_chrome.xul # mochitest-plain tests ./mach addtest js/xpconnect/tests/mochitest/test_plain.html ./mach addtest js/xpconnect/tests/mochitest/test_plain.xhtml ./mach addtest js/xpconnect/tests/mochitest/test_plain.xul # mochitest-browser tests ./mach addtest browser/base/content/test/alerts/browser_foo.js # xpcshell tests ./mach addtest browser/components/extensions/test/xpcshell/test_xpcshell.js ``` This also changes the mochitest template files in the following ways: - removes the bug # boilerplate - remove some unnecessary attributes in the template - removes the th.template - adds the browser.template for browser-chrome tests Differential Revision: https://phabricator.services.mozilla.com/D25482
5937ad352b2dd7bd092ea73348bb7f142db73050: Bug 1542024 - Eliminate nsXPCWrappedJSClass by moving its methods into nsXPCWrappedJS. r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Mon, 08 Apr 2019 19:44:45 +0000 - rev 468424
Push 82575 by amccreight@mozilla.com at Mon, 08 Apr 2019 20:06:08 +0000
Bug 1542024 - Eliminate nsXPCWrappedJSClass by moving its methods into nsXPCWrappedJS. r=bzbarsky I changed DelegatedQueryInterface and CallMethod to be non-static methods rather than taking an explicit |self| parameter. I did a tiny bit of cleanup in the nsIXPConnectJSObjectHolder case of DelegatedQueryInterface(). There is already a method nsXPCWrappedJS::CallMethod() with the same signature, but it is a shim, so I inlined it into the version in XPCWrappedJSClass.cpp. I also fixed up a few comments that mention nsXPCWrappedJSClass. The new comments starting with "We now need to enter the realm" were written by Boris, and are a little more explicit so they are easier to understand. I renamed DebugDump() to DebugDumpInterfaceInfo() to be more informative. Differential Revision: https://phabricator.services.mozilla.com/D26422
f6bf51e87b1aafe0b76a0dfd82546c99983dd3f4: Bug 1534647 - Switch python3 version to 3.6 on osx hosts; r=ahal
Geoff Brown <gbrown@mozilla.com> - Mon, 08 Apr 2019 19:10:25 +0000 - rev 468423
Push 82574 by gbrown@mozilla.com at Mon, 08 Apr 2019 20:05:32 +0000
Bug 1534647 - Switch python3 version to 3.6 on osx hosts; r=ahal Quick fix for python3 mozbase perma-fail on osx: Use python 3.6 explicitly, rather than the system default 3.7, which appears to be broken currently (lacking ssl support). Differential Revision: https://phabricator.services.mozilla.com/D26345
d2b7450ab5c61b9e934b7d8bd32b46f3cd1547b6: Bug 1542149 - Add some MacOS file extensions to to the list of executable extensions in download protection. r=Gijs
Dimi Lee <dlee@mozilla.com> - Fri, 05 Apr 2019 12:04:49 +0000 - rev 468422
Push 82573 by dlee@mozilla.com at Mon, 08 Apr 2019 20:04:55 +0000
Bug 1542149 - Add some MacOS file extensions to to the list of executable extensions in download protection. r=Gijs Here are the file extensions are added to the list: 1. action 2. caction 3. configprofile 4. definition 5. dylib 6. internetconnect 7. networkconnect 8. service 9. wflow 10.workflow Differential Revision: https://phabricator.services.mozilla.com/D26284
0fbc141c10046b151442b8164b4366757d6409bd: Bug 1542824 - [Coverity] Limit Coverity to run only on try. r=bastien
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Mon, 08 Apr 2019 18:23:54 +0000 - rev 468421
Push 82572 by bpostelnicu@mozilla.com at Mon, 08 Apr 2019 20:04:11 +0000
Bug 1542824 - [Coverity] Limit Coverity to run only on try. r=bastien Differential Revision: https://phabricator.services.mozilla.com/D26571
eb58abd1cf11cdc20fa184b65b113df527bf5dba: Backed out 3 changesets (bug 1541130) for causing GeckoChildProcessHost.cpp build bustages CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Mon, 08 Apr 2019 22:54:57 +0300 - rev 468420
Push 82571 by aciure@mozilla.com at Mon, 08 Apr 2019 19:55:38 +0000
Backed out 3 changesets (bug 1541130) for causing GeckoChildProcessHost.cpp build bustages CLOSED TREE Backed out changeset 656108173cde (bug 1541130) Backed out changeset 5914a425bc67 (bug 1541130) Backed out changeset 8ef30ebad16c (bug 1541130)
656108173cde7bbc6bab7dfee15dea907b0af05a: Bug 1541130: Follow-up: Add more missing parts that had been stripped during rebase; r=froydnj, jld on a CLOSED TREE
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 13:28:04 -0600 - rev 468419
Push 82570 by apavel@mozilla.com at Mon, 08 Apr 2019 19:33:27 +0000
Bug 1541130: Follow-up: Add more missing parts that had been stripped during rebase; r=froydnj, jld on a CLOSED TREE
5914a425bc67dc5131c9625052362ebd777aa841: Bug 1541130: Follow-up: Add missing parts that had been stripped out during rebase; r=froydnj, jld on a CLOSED TREE
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 12:55:55 -0600 - rev 468418
Push 82569 by apavel@mozilla.com at Mon, 08 Apr 2019 19:07:58 +0000
Bug 1541130: Follow-up: Add missing parts that had been stripped out during rebase; r=froydnj, jld on a CLOSED TREE
dfa27849ea1b47d3eb48453441c9446790a2132e: Bug 1542400 - Don't set LLVM_DEFAULT_TARGET_TRIPLE to possibly erroneous value when building clang runtimes. r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Mon, 08 Apr 2019 16:28:24 +0000 - rev 468417
Push 82568 by cmanchester@mozilla.com at Mon, 08 Apr 2019 18:36:25 +0000
Bug 1542400 - Don't set LLVM_DEFAULT_TARGET_TRIPLE to possibly erroneous value when building clang runtimes. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D26384
8ef30ebad16c538e39b9fb4648a551a3257d9729: Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 18:19:06 +0000 - rev 468416
Push 82567 by aklotz@mozilla.com at Mon, 08 Apr 2019 18:34:49 +0000
Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld The binary path type of a particular content process is useful information outside of IPC. Given that `XRE_EnableSameExecutableForContentProc` already exists, and given that the binary path type is closely related to `GeckoProcessType`, I've added a new function, `XRE_GetContentProcBinPathType`. The mapping of process type to binary type has been moved to the `GeckoProcessTypes` definitions. This patch also modifies `ipc::GeckoChildProcessHost` to call into the new function. Differential Revision: https://phabricator.services.mozilla.com/D25816
390bf9dcba1a62dd70fe7c66fa23e8dca12311c9: Bug 1532545 Add support for running page load tests against Fennec r=rwood
alexandru.ionescu <alexandru.ionescu@softvision.ro> - Mon, 08 Apr 2019 17:47:59 +0000 - rev 468415
Push 82566 by dhunt@mozilla.com at Mon, 08 Apr 2019 18:33:36 +0000
Bug 1532545 Add support for running page load tests against Fennec r=rwood Differential Revision: https://phabricator.services.mozilla.com/D25723
0d7d1ef8d08e18a27fa9449985b3fd45c774456a: Bug 1533890: Add support for additional call opcodes r=mgaudet
Iain Ireland <iireland@mozilla.com> - Mon, 08 Apr 2019 15:29:31 +0000 - rev 468414
Push 82565 by iireland@mozilla.com at Mon, 08 Apr 2019 18:32:43 +0000
Bug 1533890: Add support for additional call opcodes r=mgaudet To verify that I had covered all of the existing functionality, I added assertions to DoCallFallback and DoSpreadCallFallback to verify that the old C++ implementation never managed to attach a stub if CacheIR had failed to handle it. This patch includes the changes made as a result of this testing: 1. JSOP_CALLITER is equivalent to JSOP_CALL for our purposes. Adding support for JSOP_CALLITER did not require any additional changes. 2. JSOP_SUPERCALL and JSOP_SPREADSUPERCALL are just like normal constructors, except we don't save a template object. I added the super guards where necessary. 3. There were also a number of cases where we tried to attach a CacheIR stub, declined to attach because an identical stub already existed, and then attached an old stub. For example, a spread call IC with more than 16 arguments will fail, but we will try to attach another spread call IC. I examined the failures of this sort by hand. Many of them were invalid (in particular, oomtests that caused us to fail during the process of attaching the stub) or seemed acceptable. I made a few spot fixes to cover easy exceptions. 4. I added jitspew to the attachment code to print BaselineICFallback messages if we try to attach an identical stub, which will hopefully help when testing new ICs to verify that they are not perma-failing. Differential Revision: https://phabricator.services.mozilla.com/D25877
b698d91f51ddcf94064cc7befd810f9c0b25d16d: Bug 1533890: Migrate ConstStringSplit to CacheIR r=mgaudet
Iain Ireland <iireland@mozilla.com> - Mon, 08 Apr 2019 15:29:19 +0000 - rev 468413
Push 82565 by iireland@mozilla.com at Mon, 08 Apr 2019 18:32:43 +0000
Bug 1533890: Migrate ConstStringSplit to CacheIR r=mgaudet This patch adds support for ConstStringSplit. ConstStringSplit is attached after the call is performed, so that it can grab and cache the result. To make it work, I added a new AttachDecision value. Note: 1. Testing this code made me realize that a previous change I made was wrong. Even in call ICs that don't use argc, we have to initialize the input location. If we don't, the register can be allocated and clobbered, which will break subsequent ICs. 2. We only want a ConstStringSplit if this is the first stub that we try attaching. (If there's already another stub, then it can't be a constant string split. The old implementation would remove any existing ConstStringSplit stubs when it realized that the optimization had failed, but there isn't a particularly nice way of doing that in CacheIR and I don't think it matters much. 3. For unclear reasons, we had an implementation of CallStringSplitResult in IonCacheIRCompiler. It was dead code, so I removed it. Differential Revision: https://phabricator.services.mozilla.com/D25876
90f3b654d3ac69515e688942af08bf5480b5f0fa: Bug 1533890: Add TemporarilyUnoptimizable support to CallIRGenerator r=mgaudet
Iain Ireland <iireland@mozilla.com> - Mon, 08 Apr 2019 15:29:13 +0000 - rev 468412
Push 82565 by iireland@mozilla.com at Mon, 08 Apr 2019 18:32:43 +0000
Bug 1533890: Add TemporarilyUnoptimizable support to CallIRGenerator r=mgaudet In some cases we want to avoid attaching a stub, but not count it as a failure. To make it easier to express this (as well as deferred stubs, which will be used to implement ConstStringSplit in a future patch), I rewrote all the tryAttachFoo stubs in CallIRGenerator to return an enum instead of a bool. (This seems better than a bunch of mutually exclusive boolean out-params.) Differential Revision: https://phabricator.services.mozilla.com/D25875
190f9fd0c2a7d6f6a411646ba1c25194b8574a01: Bug 1533890: Add megamorphic native stubs to CacheIR r=mgaudet
Iain Ireland <iireland@mozilla.com> - Mon, 08 Apr 2019 15:29:03 +0000 - rev 468411
Push 82565 by iireland@mozilla.com at Mon, 08 Apr 2019 18:32:43 +0000
Bug 1533890: Add megamorphic native stubs to CacheIR r=mgaudet This patch extends megamorphic support to native functions, which were not previously supported. Differential Revision: https://phabricator.services.mozilla.com/D25874
8664fa8a8a10098284899e8ca8e843072fcce9ab: Bug 1533890: Add megamorphic scripted stubs to CacheIR. r=mgaudet
Iain Ireland <iireland@mozilla.com> - Mon, 08 Apr 2019 15:28:59 +0000 - rev 468410
Push 82565 by iireland@mozilla.com at Mon, 08 Apr 2019 18:32:43 +0000
Bug 1533890: Add megamorphic scripted stubs to CacheIR. r=mgaudet This patch moves CallAnyScripted over to CacheIR. Most of the pieces were already in place to implement FunCall/FunApply. The only new CacheIR op is GuardFunctionIsConstructor. I also took the opportunity to refactor the masm function flag code a little bit. Differential Revision: https://phabricator.services.mozilla.com/D25873
66ea618f7b136044ceb240b1ed8190f6fe42a4b9: Bug 1533890: Add fun_apply support to CacheIR r=mgaudet
Iain Ireland <iireland@mozilla.com> - Mon, 08 Apr 2019 15:28:49 +0000 - rev 468409
Push 82565 by iireland@mozilla.com at Mon, 08 Apr 2019 18:32:43 +0000
Bug 1533890: Add fun_apply support to CacheIR r=mgaudet This patch moves ScriptedApplyArgs and ScriptedApplyArray to CacheIR, and adds NativeApplyArgs and NativeApplyArray. Like a spread call, FunApply updates argc as part of the call op, after we've passed all the guards. Comparisons: - The new code in BaselineCacheIRCompiler::updateArgc corresponds to parts of ICCallStubCompiler::guardFunApply. - BaselineCacheIRCompiler::emitGuardFunApply also corresponds to ICCallStubCompiler::guardFunApply. - BaselineCacheIRCompiler::pushFunApplyArgs corresponds to ICCallStubCompiler::pushCallerArguments - BaselineCacheIRCompiler::pushFunApplyArray corresponds to ICCallStubCompiler::pushArrayArguments - CallIRGenerator::tryAttachFunApply corresponds to TryAttachFunApplyStub + ICCall_ScriptedApplyArray::Compiler::generateStubCode Differential Revision: https://phabricator.services.mozilla.com/D25872
f05cdb03558fb1bdf501bfb77312e864c355ebdf: Bug 1533890: Add native fun_call support to CacheIR r=mgaudet
Iain Ireland <iireland@mozilla.com> - Mon, 08 Apr 2019 16:13:31 +0000 - rev 468408
Push 82565 by iireland@mozilla.com at Mon, 08 Apr 2019 18:32:43 +0000
Bug 1533890: Add native fun_call support to CacheIR r=mgaudet This patch adds support for FunCall with a native target, which the old implementation lacked. Notes: 1. MacroAssembler::branchIfInterpreted had been unused for quite a while. I updated it to match MacroAssembler::branchIfFunctionHasNoJitEntry (and check WASM_OPTIMIZED in the non-constructor case). 2. GuardIsNativeFunction was a confusing name, especially after I added GuardFunctionIsNative. I renamed GuardIsNativeFunction to GuardSpecificNativeFunction to better represent what it does. 3. Native function calls in the simulator need to be wrapped up to trigger a software interrupt. To call an arbitrary native function, we need a trampoline, so I added CallAnyNative. Differential Revision: https://phabricator.services.mozilla.com/D25871
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip