8974adf9926ba3a32263ce48798178e0870099f1: Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp.
Cosmin Sabou <csabou@mozilla.com> - Mon, 06 Apr 2020 20:03:02 +0300 - rev 522427
Push 112120 by csabou@mozilla.com at Mon, 06 Apr 2020 17:16:28 +0000
Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp. Backed out changeset 3a43210e4900 (bug 1616353) Backed out changeset cb77e9149cf8 (bug 1616353) Backed out changeset 3aacc7cfe33f (bug 1616353) Backed out changeset c026b06063a5 (bug 1616353) Backed out changeset 580e790c5d17 (bug 1616353) Backed out changeset 6f09bc1c476d (bug 1616353) Backed out changeset 6955906262c0 (bug 1616353) Backed out changeset a7700472807a (bug 1616353) Backed out changeset a4735096e01b (bug 1616353) Backed out changeset bd1706c57d91 (bug 1616353) Backed out changeset 363c13296fda (bug 1616353) Backed out changeset e414df387524 (bug 1616353) Backed out changeset 765d3364cca0 (bug 1616353) Backed out changeset 8a13355b4ac4 (bug 1616353) Backed out changeset ada17fb8fca7 (bug 1616353) Backed out changeset 6b6b99af186d (bug 1616353) Backed out changeset ea966e78b296 (bug 1616353) Backed out changeset cb88e0bbb3b9 (bug 1616353) Backed out changeset f89a89015114 (bug 1616353) Backed out changeset ae6058552969 (bug 1616353) Backed out changeset f42bb5b48c1b (bug 1616353) Backed out changeset 1ab9d22c73bb (bug 1616353) Backed out changeset 2692c2c1396b (bug 1616353) Backed out changeset 11a279c8da08 (bug 1616353)
b5018ab3b0c1d0881badcd9bfe99e9bb99311447: Bug 1627360 - Document and fix the serialization of the SubmittedFromInfobar crash annotation r=mconley
Gabriele Svelto <gsvelto@mozilla.com> - Mon, 06 Apr 2020 16:33:32 +0000 - rev 522426
Push 112119 by gsvelto@mozilla.com at Mon, 06 Apr 2020 16:34:27 +0000
Bug 1627360 - Document and fix the serialization of the SubmittedFromInfobar crash annotation r=mconley Differential Revision: https://phabricator.services.mozilla.com/D69638
e911977b9bfcdf94eb73d6d3c764bd3e0bddfc53: Bug 1626020 - Fix default browser agent telemetry URL. r=bytesized
Molly Howell <mhowell@mozilla.com> - Mon, 06 Apr 2020 16:26:04 +0000 - rev 522425
Push 112118 by mhowell@mozilla.com at Mon, 06 Apr 2020 16:32:11 +0000
Bug 1626020 - Fix default browser agent telemetry URL. r=bytesized Differential Revision: https://phabricator.services.mozilla.com/D69834
c57ac2e125e8c65e3432fb09fa69ae39abae8161: Bug 1425450 - Only trace JS holders in collecting zones r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 06 Apr 2020 16:14:25 +0000 - rev 522424
Push 112117 by jcoppeard@mozilla.com at Mon, 06 Apr 2020 16:29:55 +0000
Bug 1425450 - Only trace JS holders in collecting zones r=mccr8 Now that we have some per-zone vectors we can skip tracing those for zones that are not being collected. Differential Revision: https://phabricator.services.mozilla.com/D68523
4238c59af7bbe81edf196e4a05e7d2a4be86092a: Bug 1425450 - Use a per-zone vector of JS holders where possible r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 06 Apr 2020 16:14:03 +0000 - rev 522423
Push 112117 by jcoppeard@mozilla.com at Mon, 06 Apr 2020 16:29:55 +0000
Bug 1425450 - Use a per-zone vector of JS holders where possible r=mccr8 Currently the JS holders table is represented as a map which contains pointers to entries in a SegmentedVector. This patch keeps the single map but use a vector per zone and also has a catch-all vector for where we don't know the zone or the holder can have pointers to more than one zone. Differential Revision: https://phabricator.services.mozilla.com/D68522
2a00272e72bae3112dab2b869d756076002ff1fd: Bug 1425450 - Ensure that we call Drop/HoldJSObjects when a preserved wrapper is changed for one in a different zone r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 06 Apr 2020 16:13:51 +0000 - rev 522422
Push 112117 by jcoppeard@mozilla.com at Mon, 06 Apr 2020 16:29:55 +0000
Bug 1425450 - Ensure that we call Drop/HoldJSObjects when a preserved wrapper is changed for one in a different zone r=mccr8 So that we can update the holders table correctly we will need to remove the wrapper from its original vector and add it to the one associated with the new zone. I tried to make SetPreservingWrapper private but there's still a use in layout/style/Rule.cpp that I couldn't see an obvious fix for. Differential Revision: https://phabricator.services.mozilla.com/D68521
3e4a52d596bb25622f748c5c0653a48dbd0d72ad: Bug 1425450 - Pass zone information through when preserving wrappers r=mccr8
Andrew McCreight <continuation@gmail.com> - Mon, 06 Apr 2020 16:13:17 +0000 - rev 522421
Push 112117 by jcoppeard@mozilla.com at Mon, 06 Apr 2020 16:29:55 +0000
Bug 1425450 - Pass zone information through when preserving wrappers r=mccr8 This is bascially the same as your original patch. Differential Revision: https://phabricator.services.mozilla.com/D68520
5da68de6749194c3686dce220392c5e9690ab72d: Bug 1425450 - Remove unused IsJsHolder methods r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 06 Apr 2020 16:12:39 +0000 - rev 522420
Push 112117 by jcoppeard@mozilla.com at Mon, 06 Apr 2020 16:29:55 +0000
Bug 1425450 - Remove unused IsJsHolder methods r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D68519
efac091a3ba4072d550f9a4e3ac56fa856b85c95: Bug 1425450 - Remove dead JSHolderMap entries lazily when the vector is next iterated r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 06 Apr 2020 16:12:21 +0000 - rev 522419
Push 112117 by jcoppeard@mozilla.com at Mon, 06 Apr 2020 16:29:55 +0000
Bug 1425450 - Remove dead JSHolderMap entries lazily when the vector is next iterated r=mccr8 Currently, to remove a holder entry from a vector we swap the entry with the last one in the vector and then shrink the vector (and fix up the map). With per-zone vectors we won't have a reference to the vector to get the last entry. One solution would be to store the zone in the entry and look up the vector in a map but I'd like to avoid this if possible because of the space overhead and the extra lookup. This patch defers clears the entry's pointers when it is removed and actually removes it when the vector is next iterated. Differential Revision: https://phabricator.services.mozilla.com/D68518
a4a083abf45c61262506b39bff1d97d102e30da3: Backed out 2 changesets (bug 1184701) for node(newtab) and xpc failures in test_thumbnails_interfaces.js. on a CLOSED TREE
Oana Pop Rus <opoprus@mozilla.com> - Mon, 06 Apr 2020 19:24:00 +0300 - rev 522418
Push 112116 by opoprus@mozilla.com at Mon, 06 Apr 2020 16:24:58 +0000
Backed out 2 changesets (bug 1184701) for node(newtab) and xpc failures in test_thumbnails_interfaces.js. on a CLOSED TREE Backed out changeset 241a6d4f2f23 (bug 1184701) Backed out changeset f753bddc4131 (bug 1184701)
65d6a90651ce377687e88f93d50a6051bb12a029: Bug 1627707 - Minor cleanup in LoadInfoToLoadInfoArgs. r=ckerschb
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 06 Apr 2020 16:00:44 +0000 - rev 522417
Push 112115 by ealvarez@mozilla.com at Mon, 06 Apr 2020 16:10:37 +0000
Bug 1627707 - Minor cleanup in LoadInfoToLoadInfoArgs. r=ckerschb No need for temporaries, we can just construct the object in place. Depends on D69829 Differential Revision: https://phabricator.services.mozilla.com/D69830
378ec30d99798f60c932b6e6267b089293fcea42: Bug 1627707 - Deindent most of CHECK_PRINCIPAL_CSP_AND_DATA. r=ckerschb
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 06 Apr 2020 16:00:43 +0000 - rev 522416
Push 112115 by ealvarez@mozilla.com at Mon, 06 Apr 2020 16:10:37 +0000
Bug 1627707 - Deindent most of CHECK_PRINCIPAL_CSP_AND_DATA. r=ckerschb It's just a nested if which can be written with &&. Depends on D69828 Differential Revision: https://phabricator.services.mozilla.com/D69829
058a19e11b0621913e8b94704bc0d2578f9a4ddf: Bug 1627707 - Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 06 Apr 2020 16:00:43 +0000 - rev 522415
Push 112115 by ealvarez@mozilla.com at Mon, 06 Apr 2020 16:10:37 +0000
Bug 1627707 - Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb Mostly a matter of: rg -l '\->LoadingPrincipal' | xargs sed -i 's/->LoadingPrincipal/->GetLoadingPrincipal/g' And then clang-format. But I tweaked manually nsHttpChannelAuthProvider (move the variable where it's used, don't take a useless strong ref), AddonContentPolicy (move the declaration of the variable to the if condition), and BackgroundUtils (same). Differential Revision: https://phabricator.services.mozilla.com/D69828
41906e11f2d259c83c5b6c2d1b0c764e490737f9: Bug 40545 - Options to use label attribute when present r=emilio,jfkthame,mats
Chris H-C <chutten@mozilla.com> - Mon, 06 Apr 2020 16:06:36 +0000 - rev 522414
Push 112114 by chutten@mozilla.com at Mon, 06 Apr 2020 16:07:12 +0000
Bug 40545 - Options to use label attribute when present r=emilio,jfkthame,mats According to spec, option elements with label attributes should show and use those labels rather than their element text. So let's do that. Requires some trickery because the option element is a block element (so it lays out its width based on its text content) so we put its label (if it has one) in its ::before and skip frame generation so it measures the text of its label, not of its text node children. Differential Revision: https://phabricator.services.mozilla.com/D63545
a930692de9966a3eeaee371a6ca8db658c3152e3: Bug 1627047 - Use FunctionBox to declare arguments object r=caroline
Matthew Gaudet <mgaudet@mozilla.com> - Sat, 04 Apr 2020 17:12:41 +0000 - rev 522413
Push 112113 by mgaudet@mozilla.com at Mon, 06 Apr 2020 16:01:20 +0000
Bug 1627047 - Use FunctionBox to declare arguments object r=caroline Depends on D69437 Differential Revision: https://phabricator.services.mozilla.com/D69438
a5dbb15d598d538e055c96c31b59f7da61b72ff9: Bug 1627047 - Use FunctionBox to answer if we have thisBinding r=caroline
Matthew Gaudet <mgaudet@mozilla.com> - Sat, 04 Apr 2020 17:12:41 +0000 - rev 522412
Push 112113 by mgaudet@mozilla.com at Mon, 06 Apr 2020 16:01:20 +0000
Bug 1627047 - Use FunctionBox to answer if we have thisBinding r=caroline Depends on D69436 Differential Revision: https://phabricator.services.mozilla.com/D69437
44cd69be9c8d158e165ebebaecbb9bb4f7c7baef: Bug 1627047 - Initialize FunctionBox from lazy function by absorbing flags r=caroline
Matthew Gaudet <mgaudet@mozilla.com> - Sat, 04 Apr 2020 17:12:41 +0000 - rev 522411
Push 112113 by mgaudet@mozilla.com at Mon, 06 Apr 2020 16:01:20 +0000
Bug 1627047 - Initialize FunctionBox from lazy function by absorbing flags r=caroline Differential Revision: https://phabricator.services.mozilla.com/D69436
a12b3c22838f1e4249955fe2a35b4e8821bf769c: Bug 1626636 - Vendor rust-cascade v0.6.0 r=keeler
J.C. Jones <jjones@mozilla.com> - Thu, 02 Apr 2020 20:30:15 +0000 - rev 522410
Push 112112 by jjones@mozilla.com at Mon, 06 Apr 2020 15:48:32 +0000
Bug 1626636 - Vendor rust-cascade v0.6.0 r=keeler Add salts, file format v2, SHA256 hash support, and logic inversion Differential Revision: https://phabricator.services.mozilla.com/D69435
e06dab9259c5dc7c47328e045daa745f7b63d95b: Bug 1627282 - Mark all IndexDB cursor subclasses as potentially containing pointers into more than one JS zone r=sg
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 06 Apr 2020 13:02:52 +0000 - rev 522409
Push 112111 by jcoppeard@mozilla.com at Mon, 06 Apr 2020 15:47:40 +0000
Bug 1627282 - Mark all IndexDB cursor subclasses as potentially containing pointers into more than one JS zone r=sg At this point it's probably worth marking all these subclasses in the same way as I expect they can all contain pointers into multiple zones. Differential Revision: https://phabricator.services.mozilla.com/D69809
dd2aef0bbd415ac3c554c337964f5bcf52a13b11: Bug 1627536 - Avoid silly string copying in nsWebBrowserPersit. r=nika
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 06 Apr 2020 15:37:49 +0000 - rev 522408
Push 112110 by ealvarez@mozilla.com at Mon, 06 Apr 2020 15:39:26 +0000
Bug 1627536 - Avoid silly string copying in nsWebBrowserPersit. r=nika Differential Revision: https://phabricator.services.mozilla.com/D69747
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip