4df15097883c710d5799fe475bd4c927d14b2d5c: Bug 1105111 part 3: Add support for 'flex-basis:content' in layout. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 30 Mar 2018 16:50:49 -0700 - rev 410911
Push 62007 by ecoal95@gmail.com at Mon, 02 Apr 2018 02:30:59 +0000
Bug 1105111 part 3: Add support for 'flex-basis:content' in layout. r=mats BACKGROUND: Early in flex layout, we have to resolve the 'flex-basis' value to produce the "flex base size" (basically, the flex-basis resolved to an absolute length). This resolution happens in two "phases" (which both happen within nsFlexContainer::GenerateFlexItemForChild()): First phase: we try to resolve the flex-basis by creating a ReflowInput for the flex item (which gets us some other things as well). Under the hood, we use the flex-basis when resolving this ReflowInput's main-axis size. The code for this lives in nsFrame::ComputeSize (and in nsFrame::ComputeSizeWithIntrinsicDimensions, via some frame classes' overrides of ComputeSize). Second phase: If the first phase didn't get us a definite size, then that means we have to do reflow to measure the content size & produce a resolved flex base size, which we do via ResolveAutoFlexBasisAndMinSize(). NOTES ON THIS PATCH: To add 'flex-basis:content' support to layout, this patch only needs to modify the first phase discussed above. If it turns out we also have some second-phase work to do (i.e. if we need to do reflow to resolve 'flex-basis:content'), this patch causes that reflow to happen by simply making us use eStyleUnit_Auto in the main axis's nsStyleCoord in the first phase. (And then, if that 'auto' nsStyleCoord really does require reflow, then that first phase will end up producing an unconstrained main-size in the flex item's ReflowInput, which will automatically trigger the second phase.) MozReview-Commit-ID: 2nH4Fh78C81
46097b1d022597132c432e6d01e0deea4daa55b3: Bug 1105111 part 2: Add support for 'flex-basis:content' in the style system (gecko / getComputedStyle side). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 30 Mar 2018 16:50:04 -0700 - rev 410910
Push 62007 by ecoal95@gmail.com at Mon, 02 Apr 2018 02:30:59 +0000
Bug 1105111 part 2: Add support for 'flex-basis:content' in the style system (gecko / getComputedStyle side). r=mats MozReview-Commit-ID: E0crFCy7Jfk
9b1a774f2645ad6c01c900450a96a482c5afd0ef: servo: Merge #20500 - style: Add support for 'flex-basis:content' in the style system (from emilio:1105111); r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 01 Apr 2018 21:18:27 -0400 - rev 410909
Push 62006 by servo-vcs-sync@mozilla.com at Mon, 02 Apr 2018 02:22:28 +0000
servo: Merge #20500 - style: Add support for 'flex-basis:content' in the style system (from emilio:1105111); r=xidorn Bug: 1105111 Reviewed-by: xidorn MozReview-Commit-ID: 5WhgHJJ0mDB Source-Repo: https://github.com/servo/servo Source-Revision: ca7463df9ee6f7d3886c2bbcb2d0842f24c4abf7
a56cd855e314a700d97f5bd81af1cdf34366de0a: Bug 1398537 part 4 - [css-multicol] Implement percentages for 'column-gap' (automated update of devtools).
Mats Palmgren <mats@mozilla.com> - Mon, 02 Apr 2018 01:57:01 +0200 - rev 410908
Push 62005 by ecoal95@gmail.com at Sun, 01 Apr 2018 23:57:20 +0000
Bug 1398537 part 4 - [css-multicol] Implement percentages for 'column-gap' (automated update of devtools).
a00e328cf69a588daf59210a44628418988b615f: Bug 1398537 part 3 - [css-multicol] Implement percentages for 'column-gap' (automated update of WPT results).
Mats Palmgren <mats@mozilla.com> - Mon, 02 Apr 2018 01:56:42 +0200 - rev 410907
Push 62005 by ecoal95@gmail.com at Sun, 01 Apr 2018 23:57:20 +0000
Bug 1398537 part 3 - [css-multicol] Implement percentages for 'column-gap' (automated update of WPT results).
a7ae048e74229a9a077c91d7d337095009765d89: Bug 1398537 part 2 - [css-multicol] Implement percentages for 'column-gap' (Gecko part). r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 02 Apr 2018 01:56:19 +0200 - rev 410906
Push 62005 by ecoal95@gmail.com at Sun, 01 Apr 2018 23:57:20 +0000
Bug 1398537 part 2 - [css-multicol] Implement percentages for 'column-gap' (Gecko part). r=dholbert
bc317449a4e9bc5aaee621c79d25a09d33826e06: servo: Merge #20499 - style: Implement percentages for 'column-gap' (from emilio:1398537); r=emilio,dholbert
Mats Palmgren <mats@mozilla.com> - Sun, 01 Apr 2018 18:59:15 -0400 - rev 410905
Push 62004 by servo-vcs-sync@mozilla.com at Sun, 01 Apr 2018 23:52:38 +0000
servo: Merge #20499 - style: Implement percentages for 'column-gap' (from emilio:1398537); r=emilio,dholbert Bug: 1398537 Reviewed-by: emilio,dholbert Source-Repo: https://github.com/servo/servo Source-Revision: 1e2411d2c50f87e2fbcfc91167029bd345649653
1c333aa384ce47c3e25e380bc133739c0cf90bef: Bug 1428944 - Policy: Set or disable first-run (welcome) page. r=mkaply
Felipe Gomes <felipc@gmail.com> - Sun, 01 Apr 2018 19:46:24 -0300 - rev 410904
Push 62003 by felipc@gmail.com at Sun, 01 Apr 2018 22:49:13 +0000
Bug 1428944 - Policy: Set or disable first-run (welcome) page. r=mkaply MozReview-Commit-ID: LXjJAkzkkpY
f7ad3dd6c01dd79daf7d911b7de62065e3949175: servo: Merge #20495 - Move `text-emphasis-position` outside of mako (from LiHaoTan:move-text-emphasis-position); r=emilio
Li Hao Tan <LiHaoTan@users.noreply.github.com> - Sun, 01 Apr 2018 12:00:08 -0400 - rev 410903
Push 62002 by servo-vcs-sync@mozilla.com at Sun, 01 Apr 2018 16:53:46 +0000
servo: Merge #20495 - Move `text-emphasis-position` outside of mako (from LiHaoTan:move-text-emphasis-position); r=emilio <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` and `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fixes #19961 - [X] These changes do not require tests because this is refactoring. ~Just as a sanity check I ran `./mach test-wpt tests/wpt/web-platform-tests/css/css-text-decor/text-emphasis-position-above-left-001.xht` though I'm not sure if I'm correct since we are also building for `geckolib`. I guess the buildbot will make sure to run all the relevant tests anyway.~ I guess Travis and AppVeyor will run the web platform tests before the buildbot run all the tests later on. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 9677d5c1ba6a5174ff251280a9cb1e88b53bebbe
ef717c03ff54d10b2e30df7e63fc11172c69db44: Merge mozilla-central to autoland
arthur.iakab <aiakab@mozilla.com> - Sun, 01 Apr 2018 00:40:23 +0300 - rev 410902
Push 62001 by aiakab@mozilla.com at Sat, 31 Mar 2018 21:40:43 +0000
Merge mozilla-central to autoland
3f9a70b125f6fb9be2b209159657fd7ae5515c01: Merge autoland to mozilla-central. a=merge
arthur.iakab <aiakab@mozilla.com> - Sun, 01 Apr 2018 00:32:27 +0300 - rev 410901
Push 62001 by aiakab@mozilla.com at Sat, 31 Mar 2018 21:40:43 +0000
Merge autoland to mozilla-central. a=merge
d148dc003b467a0b8d5523bf8c32fde7a614ad32: Bug 1446617 - support the SVG 2 path attribute for textPath elements r=dholbert
Robert Longson <longsonr@gmail.com> - Sat, 31 Mar 2018 18:50:10 +0100 - rev 410900
Push 62001 by aiakab@mozilla.com at Sat, 31 Mar 2018 21:40:43 +0000
Bug 1446617 - support the SVG 2 path attribute for textPath elements r=dholbert
469b253318c17722f4e543cca7580887fb0087eb: Backed out changeset dcd8ba6a9028 (bug 1429394) for build bustages. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Sat, 31 Mar 2018 18:05:52 +0300 - rev 410899
Push 62001 by aiakab@mozilla.com at Sat, 31 Mar 2018 21:40:43 +0000
Backed out changeset dcd8ba6a9028 (bug 1429394) for build bustages. CLOSED TREE
dcd8ba6a9028da11cdcc6f1b9894551dbbc5172a: Bug 1429394 - Remove toolkit/locales/generic/chrome/global/brand.dtd. r=mconley
ui.manish <1991manish.kumar@gmail.com> - Sat, 31 Mar 2018 13:10:50 +0200 - rev 410898
Push 62001 by aiakab@mozilla.com at Sat, 31 Mar 2018 21:40:43 +0000
Bug 1429394 - Remove toolkit/locales/generic/chrome/global/brand.dtd. r=mconley
322f27869c71927f4f1bca6454a184f3beaf060e: Bug 1436413 - Remove inDOMView as it is no longer used. r=bz
Marco Castelluccio <mcastelluccio@mozilla.com> - Wed, 07 Feb 2018 15:46:30 +0100 - rev 410897
Push 62001 by aiakab@mozilla.com at Sat, 31 Mar 2018 21:40:43 +0000
Bug 1436413 - Remove inDOMView as it is no longer used. r=bz
42532117a8c0aa3cc6c55788ef6a964ac988639f: Backed out changeset cd40ea4d0a95 (bug 1446617) for Reftest failure on build/tests/reftest/tests/layout/reftests/svg/textPath-path-attribute-01.svg
Dorel Luca <dluca@mozilla.com> - Sat, 31 Mar 2018 16:02:10 +0300 - rev 410896
Push 62001 by aiakab@mozilla.com at Sat, 31 Mar 2018 21:40:43 +0000
Backed out changeset cd40ea4d0a95 (bug 1446617) for Reftest failure on build/tests/reftest/tests/layout/reftests/svg/textPath-path-attribute-01.svg
cd40ea4d0a95468190833a0e46ae025bd95b3ae3: Bug 1446617 - support the SVG 2 path attribute for textPath elements r=dholbert
Robert Longson <longsonr@gmail.com> - Sat, 31 Mar 2018 11:55:18 +0100 - rev 410895
Push 62001 by aiakab@mozilla.com at Sat, 31 Mar 2018 21:40:43 +0000
Bug 1446617 - support the SVG 2 path attribute for textPath elements r=dholbert
1bd99f784a9441419b9816277e3b2740fc8b85bc: No bug, Automated HPKP preload list update from host bld-linux64-spot-325 - a=hpkp-update
ffxbld - Sat, 31 Mar 2018 14:00:13 -0700 - rev 410894
Push 62001 by aiakab@mozilla.com at Sat, 31 Mar 2018 21:40:43 +0000
No bug, Automated HPKP preload list update from host bld-linux64-spot-325 - a=hpkp-update
c038e883766e1cb0c817420fe40b402e985a45fb: No bug, Automated HSTS preload list update from host bld-linux64-spot-325 - a=hsts-update
ffxbld - Sat, 31 Mar 2018 14:00:10 -0700 - rev 410893
Push 62001 by aiakab@mozilla.com at Sat, 31 Mar 2018 21:40:43 +0000
No bug, Automated HSTS preload list update from host bld-linux64-spot-325 - a=hsts-update
998fb1b803847df1b6933d9cfd442504afa0cadb: Bug 1449504 - Part 1 - Truncate overly long text before sharing via an Intent. r=jchen
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 28 Mar 2018 22:52:14 +0200 - rev 410892
Push 62000 by mozilla@buttercookie.de at Sat, 31 Mar 2018 16:14:35 +0000
Bug 1449504 - Part 1 - Truncate overly long text before sharing via an Intent. r=jchen At least on some devices, there seems to exist some sort of intermediate danger zone where the intent is no longer large enough to be rejected outright by the OS, but still big enough to render Firefox inoperable through some sort of resource exhaustion. From Android 6.0 onwards, this doesn't matter as otherwise we would have crashed anyway, but on previous Android versions a much too large intent will simply be ignored, so if we truncate, but not enough, this actually makes matters worse. The value used in this patch was chosen by attempting to share the whole contents of planet.mozilla.org on a Samsumg S3 Mini running Android 4.1.2. 90k characters led to resource exhaustion and the screen turning black, while 85k characters still worked. On a more modern phone, even larger amounts (e.g. 100k characters, like Chrome) worked. Therefore, to have some additional margin, a maximum limit of 80k characters will be used. MozReview-Commit-ID: 6etHe0KUgig
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip