49bd486c1bda6b86ba95cbfaa0ed0f104025b5a5: Bug 1476724 - Follow up. Mark the css-ui-invalid/**/button.html as fuzzy, not css-invalid/**/button.html. r=me
Ryan Hunt <rhunt@eqrion.net> - Mon, 30 Jul 2018 10:43:57 -0500 - rev 429265
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1476724 - Follow up. Mark the css-ui-invalid/**/button.html as fuzzy, not css-invalid/**/button.html. r=me
5b8d59e9b59ccb25d463978c5b292dac8744ee7c: Bug 1465798: Create a MinGW-Clang toolchain job r=froydnj
Jacek Caban <jacek@codeweavers.com> - Tue, 24 Jul 2018 14:04:53 -0500 - rev 429264
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1465798: Create a MinGW-Clang toolchain job r=froydnj MozReview-Commit-ID: 9OLqKcYtMJi
57c753069162f15283cec14b9cdfe0d6f897d690: Bug 1478834 - Remove duplicated import of Preferences module in aboutTelemetry.js r=janerik
Siddhant <dpsrkp.sid@gmail.com> - Mon, 30 Jul 2018 20:26:28 +0530 - rev 429263
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1478834 - Remove duplicated import of Preferences module in aboutTelemetry.js r=janerik
127e7ceb9d8763e75407712cf6f28f1c459926f2: Bug 1477915 - Prevent netmonitor crash due to invalid URL input r=pbro
David Walsh <dwalsh@mozilla.com> - Wed, 25 Jul 2018 13:46:45 -0500 - rev 429262
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1477915 - Prevent netmonitor crash due to invalid URL input r=pbro
627dfd5ef235b3ea22a1534eedb131a8a333d9b0: Bug 1478904. Remove unused nsGlobalWindowInner::CallerInnerWindow. r=nika
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 30 Jul 2018 11:51:52 -0400 - rev 429261
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1478904. Remove unused nsGlobalWindowInner::CallerInnerWindow. r=nika
7f4dd832985c43d9ff08ef857c15ddb0e222af11: Bug 1478743 part 3. Remove bogus clearing of the response when xhr.overrideMimeType throws. r=baku
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 30 Jul 2018 11:51:52 -0400 - rev 429260
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1478743 part 3. Remove bogus clearing of the response when xhr.overrideMimeType throws. r=baku
2e2e905fdb24de5861b79d750bbab4c661e8942b: Bug 1478743 part 2. Add some test coverage for calling xhr.overrideMimeType() in done state in workers. r=baku
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 30 Jul 2018 11:51:49 -0400 - rev 429259
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1478743 part 2. Add some test coverage for calling xhr.overrideMimeType() in done state in workers. r=baku
565222693850d45b60b64ddc04e7106ae15b027b: Bug 1478743 part 1. Add some test coverage for setting xhr.responseType on workers. r=baku
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 30 Jul 2018 11:51:47 -0400 - rev 429258
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1478743 part 1. Add some test coverage for setting xhr.responseType on workers. r=baku Most of the change is just making the responseType wpt run on workers and annotating the resulting failures. The change to the initial value of mResponseType is a drive-by fix for an easy-to-fix issue the test caught. There is a corresponding mochitest fix to fix our incorrect test for the behavior.
3895fde69249ee14f4f3d55aafe090bcfd0d6cb0: Bug 1347999. Annotate xpidl methods/attributes that can be implemented in script as JS_HAZ_CAN_RUN_SCRIPT. r=froydnj
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 30 Jul 2018 11:51:44 -0400 - rev 429257
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1347999. Annotate xpidl methods/attributes that can be implemented in script as JS_HAZ_CAN_RUN_SCRIPT. r=froydnj
3db40ff608ebd9188a3e85c6e5f92c1305a752fb: Bug 1479426 - improve the efficiency of the CSS selector showing pageActionSeparator, rs=Gijs.
Florian Quèze <florian@queze.net> - Mon, 30 Jul 2018 17:49:12 +0200 - rev 429256
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1479426 - improve the efficiency of the CSS selector showing pageActionSeparator, rs=Gijs.
4c138aecdd4504bfc4ca5b5296866fed64127bed: Bug 1478509 - Restore ordering for EnterScript and CheckGlobalDeclarationConflicts calls, r=jandem.
Brian Hackett <bhackett1024@gmail.com> - Mon, 30 Jul 2018 15:34:14 +0000 - rev 429255
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1478509 - Restore ordering for EnterScript and CheckGlobalDeclarationConflicts calls, r=jandem.
7ce27aa3ce6887c226baa88223c0bf95bc2c3c28: Bug 1474369 - Part 8: Rename from Sequence to Array in xpidl, r=mccr8
Nika Layzell <nika@thelayzells.com> - Tue, 24 Jul 2018 16:31:09 -0400 - rev 429254
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1474369 - Part 8: Rename from Sequence to Array in xpidl, r=mccr8 Summary: This more closely matches the C++ names, and reflects the fact that the reflected type is not WebIDL's mozilla::dom::Sequence. The reasoning behind this type difference is for ergonomics, due to xpidl only being exposed to internal JS code. Depends On D2335 Reviewers: mccr8! Tags: #secure-revision Bug #: 1474369 Differential Revision: https://phabricator.services.mozilla.com/D2337
a8a4e2414daaf4ff66f0b911aefe424f39e917bb: Bug 1474369 - Part 7: Rename [array] to LegacyArray within xpt and xpidl, r=mccr8
Nika Layzell <nika@thelayzells.com> - Tue, 24 Jul 2018 15:16:13 -0400 - rev 429253
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1474369 - Part 7: Rename [array] to LegacyArray within xpt and xpidl, r=mccr8 Summary: This is done so we can use Array as the name for the new nsTArray-based type, rather than having to come up with a new name. LegacyArray was chosen as the [array] attribute is now effectively deprecated, and we'd like to remove it ASAP. Depends On D2334 Reviewers: mccr8! Tags: #secure-revision Bug #: 1474369 Differential Revision: https://phabricator.services.mozilla.com/D2335
13c9626970e23b824edd496c4e56261724dc750a: Bug 1474369 - Part 6: Use RefPtr for Array<T> of interface and WebIDL types, r=mccr8
Nika Layzell <nika@thelayzells.com> - Tue, 24 Jul 2018 15:08:04 -0400 - rev 429252
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1474369 - Part 6: Use RefPtr for Array<T> of interface and WebIDL types, r=mccr8 Summary: This means that using these types involves many fewer footguns, while not requiring any changes to the actual XPConnect implementation! Depends on D2111 Reviewers: mccr8! Tags: #secure-revision Bug #: 1474369 Differential Revision: https://phabricator.services.mozilla.com/D2334
9817819b7765b5bcb115c1a5537e9deff48c4ace: Bug 1475409 - Part 3: Make the different categories of types in xptinfo more explicit, r=mccr8
Nika Layzell <nika@thelayzells.com> - Wed, 11 Jul 2018 14:51:32 -0400 - rev 429251
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1475409 - Part 3: Make the different categories of types in xptinfo more explicit, r=mccr8 Summary: This should make it more clear which types have which behaviours, and should make it easier to add new types without forgetting to handle a special case somewhere. Depends On D2114 Reviewers: mccr8! Tags: #secure-revision Bug #: 1475409 Differential Revision: https://phabricator.services.mozilla.com/D2115
39fcebfe65295fa2f84e8e59734f38fa778bca20: Bug 1475409 - Part 2: Be more explicit about the type of nsXPTType::Tag(), r=mccr8
Nika Layzell <nika@thelayzells.com> - Wed, 11 Jul 2018 11:02:32 -0400 - rev 429250
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1475409 - Part 2: Be more explicit about the type of nsXPTType::Tag(), r=mccr8 This will get us both more clarity as to what types are, but also will improve switch exhaustiveness checks. Summary: Depends On D2113 Reviewers: mccr8! Tags: #secure-revision Bug #: 1475409 Differential Revision: https://phabricator.services.mozilla.com/D2114
c19ca740d3d1535e1469cd5201828dda4af5850e: Bug 1475409 - Part 1: Remove nsXPTType::TagPart(), r=mccr8
Nika Layzell <nika@thelayzells.com> - Wed, 11 Jul 2018 10:30:04 -0400 - rev 429249
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1475409 - Part 1: Remove nsXPTType::TagPart(), r=mccr8 Reviewers: mccr8! Tags: #secure-revision Bug #: 1475409 Differential Revision: https://phabricator.services.mozilla.com/D2113
b26c90518fca1e47ea3805d8a65a21a2c941849d: Bug 1474369 - Part 5: Add tests for new Sequence<T> types, r=mccr8
Nika Layzell <nika@thelayzells.com> - Tue, 10 Jul 2018 21:25:11 -0400 - rev 429248
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1474369 - Part 5: Add tests for new Sequence<T> types, r=mccr8 Summary: Depends On D2110 Reviewers: mccr8! Tags: #secure-revision Bug #: 1474369 Differential Revision: https://phabricator.services.mozilla.com/D2111
cbdde0474521c45931261ad7f843c55bb8511b4a: Bug 1474369 - Part 4: Add support for Sequence<T> types to xpidl and XPConnect, r=mccr8
Nika Layzell <nika@thelayzells.com> - Tue, 10 Jul 2018 21:24:48 -0400 - rev 429247
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1474369 - Part 4: Add support for Sequence<T> types to xpidl and XPConnect, r=mccr8 Summary: This patch adds support for the `Sequence<T>` type. This is largely a straightforward type propagation patch, but there are a few notable things: 1. We allow `[iid_is(x)] Sequence<nsQIResult>`, so Sequence can be Dependent. 2. `Sequence<T>` is reflected into C++ as a `nsTArray<T>`, which is different than WebIDL's `mozilla::dom::Sequence<T>` type. This decision was made for general ergonomics reasons, as `nsTArray<T>` is more prevailent throughout the codebase, and lengths in this case cannot be controlled by content, as XPConnect is only exposed to Chrome JS. 3. Owned pointers in `Sequence<T>` are not reflected as their owned counterparts. For example, `Sequence<nsISupports>` is reflected as `nsTArray<nsISupports*>` rather than `nsTArray<RefPtr<nsISupports>>`. This was done to avoid depending on `RefPtr<T>` and `T*` having the same in-memory representation, however if that is considered an acceptable dependency, it would be nice to support that. 4. We also don't reflect singly-owned pointers as their owned counterparts. For example, `nsTArray<nsIIDPtr>` would be reflected as `nsTArray<nsIID*>` rather than `nsTArray<mozilla::UniquePtr<nsIID>>`. If we are willing to depend on `mozilla::UniquePtr<T>`'s in-memory representation, we could also do this, however. 5. There are no restrictions on what types can appear inside of a `Sequence<T>` or what can appear inside an `[array] T`. We may want to add restrictions either at the xpidl level or in XPConnect. Depends On D2109 Reviewers: mccr8! Tags: #secure-revision Bug #: 1474369 Differential Revision: https://phabricator.services.mozilla.com/D2110
ccea3049fe0f83729787459b0047aed2725d46f4: Bug 1474369 - Part 3: Add generic type parsing support to xpidl, r=mccr8
Nika Layzell <nika@thelayzells.com> - Tue, 10 Jul 2018 21:15:16 -0400 - rev 429246
Push 67094 by ccoroiu@mozilla.com at Mon, 30 Jul 2018 22:02:32 +0000
Bug 1474369 - Part 3: Add generic type parsing support to xpidl, r=mccr8 Summary: This patch allows parsing generic types, such as Sequence<T>, in XPIDL. It does this by introducing a new type, TypeId, which contains both the name string and an optional list of generic parameters. Various places which use the xpidl.py library had to be updated to construct one of these TypeId objects, as TypeId and `str` are not compatible types. Depends On D2106 Reviewers: mccr8! Tags: #secure-revision Bug #: 1474369 Differential Revision: https://phabricator.services.mozilla.com/D2109
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip