45a715e4cf0d31ef2ffa6fcd843112180ba38378: Bug 1467344 - Update tests in test_animation-element-get-animations.html; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:03 +0900 - rev 432281
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Update tests in test_animation-element-get-animations.html; r=hiro This mostly just tidies up these tests to give them sensible titles. The only test with major substantive changes is the first test. This test tests three things: 1) That getAnimations() returns one transition per transitioning property 2) That getAnimations() returns transitions in the order they were generated 3) That CSS transitions have their start time set based on when they were generated. (2) is covered later in this file by the test: 'getAnimations sorts transitions by when they were generated' (3) is really a test for startTime, if anything, not getAnimations(). I'm not sure how necessary it is, but I've added it to test_animation-starttime.html for now. As a result, this patch updates this first test to only cover (1).
ffce5e4f4d45e90f116bb0bf7a4c9953009c6c67: Bug 1467344 - Tidy up test in test_csstransition-transitionproperty.html; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:03 +0900 - rev 432280
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Tidy up test in test_csstransition-transitionproperty.html; r=hiro This is mostly whitespace tidy-ups. The only substantive change is the fix to the test description which previously seemed to be missing some words.
2fcae020385795acd81f858538438708aa3763d0: Bug 1467344 - Update tests in test_animation-starttime.html; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:03 +0900 - rev 432279
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Update tests in test_animation-starttime.html; r=hiro Apart from obvious tidy-ups the substantive changes to tests in this file are as follows: * Skipping forward through animation -> This is really testing two things: (a) That you can seek a transition using the start time. (b) That seeking a transition using the start time triggers dispatching events. This patch splits the above into two separate tests. * Skipping backwards through animation, -> All these tests are really just exercising event dispatch which is already covered by test_event-dispatch.html. As a result this patch drops these tests. * Setting startTime to null -> Covered by 'Setting an unresolved start time sets the hold time' in wpt/web-animations/timing-model/animations/setting-the-start-time-of-an-animation.html * Animation.startTime after pausing -> Covered by 'Pausing clears the start time' in wpt/web-animations/timing-model/animations/pausing-an-animation.html
a4a1c2383121e53bb913333eb04ac6193fa9133c: Bug 1467344 - Update tests in test_animation-ready.html; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:03 +0900 - rev 432278
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Update tests in test_animation-ready.html; r=hiro The test: 'A new ready promise is created each time play() is called the animation property', is covered in: web-animations/interfaces/Animation/ready.html by the 'A new ready promise is created when play()/pause() is called' test. As a result, this patch removes that test.
a611b59253c5c9865119e88e376e5dd8631fe461: Bug 1467344 - Drop test_animation-pausing.html; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:03 +0900 - rev 432277
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Drop test_animation-pausing.html; r=hiro This seems to be adequately covered by: web-animations/timing-model/animations/pausing-an-animation.html (specifically the last test: 'The animation's current time remains fixed after pausing') web-animations/timing-model/animation-effects/simple-iteration-progress.html (which checks that the iteration progress is correctly calculated from the current time)
b023fa315b32aaaea6d59184262f37665b1560cc: Bug 1467344 - Update tests in test_animation-finished.html; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:03 +0900 - rev 432276
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Update tests in test_animation-finished.html; r=hiro For the first test, we really want to check that it is possible to restart transitions (since they are otherwise disassociated once they finish) hence this patch updates the test to the actual output in style rather than timing. The second test is covered in web-animations/timing-model/animations/reversing-an-animation.html by the 'Playing a finished and reversed animation seeks to end' test so this patch removes it from this file.
c5722de174bc37cfd768e62366da5acc22298969: Bug 1467344 - Update tests in test_animation-currenttime.html; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:03 +0900 - rev 432275
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Update tests in test_animation-currenttime.html; r=hiro This patch basically completely rewrites this file to make it simpler and remove unnecessary tests. In particular: * It sets the duration and delay to 100s to match what we use in most tests * All the helper methods at the start are inlined into the relevant tests because doing so makes the tests much easier to read and debug. * The first two tests are combined and extended - Testing the initial current time is zero is not generally useful but it is when we're testing setting it - What the second test really wants to test is that the style updates (i.e. you really can seek a transition, not just that the currentTime value updates) - The trick where we set the start time just to get out of the pending state seems unnecessary, we may as well just wait on ready. In fact, we don't _need_ to do that, but this test is about checking you can seek a transition in motion. * In the fourth test, 'Skipping backwards through transition', we don't check the event is dispatched since that is covered in test_event-dispatch.html in the 'Active -> Before' test. * The final test, 'Animation.currentTime after pausing', is covered by web-animations/timing-model/animations/pausing-an-animation.html
242d779840719472bea5adcd114d2a1bdb08eb96: Bug 1467344 - Fix some minor formatting in test_animation-computed-timing.html; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:02 +0900 - rev 432274
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Fix some minor formatting in test_animation-computed-timing.html; r=hiro
14200486590f8f2e121c74ded7986dccd12ff5ef: Bug 1467344 - Drop some unnecessary <body> elements from test files; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:02 +0900 - rev 432273
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Drop some unnecessary <body> elements from test files; r=hiro We're a bit inconsistent about this, but generally we try to keep this files as minimal as possible. There is still a lot of other cruft in the starttime and currenttime test files but we will remove that when we tidy up those files in later patches in this series.
fbdd599db4490ea7e651ef7f2a05c5f6584f6c0d: Bug 1467344 - Update the titles of each test file; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:02 +0900 - rev 432272
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Update the titles of each test file; r=hiro
9427f6cff88ff691b812846f819c6e93e1ef1aea: Bug 1467344 - Fix the spelling of canceled/canceling in dom/animation/test/css-transitions/; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:02 +0900 - rev 432271
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Fix the spelling of canceled/canceling in dom/animation/test/css-transitions/; r=hiro
5097e03c335b588d7d3a3e369dd4f3785ea908a5: Bug 1467344 - Replace var with const/let in dom/animation/test/css-transitions/; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:02 +0900 - rev 432270
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Replace var with const/let in dom/animation/test/css-transitions/; r=hiro
8d053037352a55cb0ff3f6900e43679901c23d6d: Bug 1467344 - Use async/await in dom/animation/test/css-transitions/; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:02 +0900 - rev 432269
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Use async/await in dom/animation/test/css-transitions/; r=hiro As part of this change, the "Restart transition after cancelling transition immediately" test in test_event-dispatch.html needed significant changes. The reason is that this test was calling: watcher.wait_for([ 'transitioncancel', 'transitionrun', 'transitionstart' ]); However, it was not waiting for the result of that call and hence was not actually checking if the events were being dispatched. And, they are not. There are two problems. Firstly, this test cancels the transition by setting display:none. However, transitions don't run on display:none elements so attempting to restart the transition will not generate transition events. This might be a bug, but it is not a recent regression in any case (I tested back to Firefox 54). However, this test does not require using display:none to cancel. There are _many_ tests that check that display:none generates a transitioncancel event. This test only needs to make the transition idle. As a result, this patch makes that test call transition.cancel() instead. However, even with that change this test will not pass because it sets a transition-delay of 100s (presumably so that it does not need to check for a transitionstart event). As a result this test should not wait on _both_ transitionrun and transitionstart but just transitionrun.
a8ae57ad9f1595a88c75ef0b3c41760c94e1fc27: Bug 1467344 - Use arrow functions in dom/animation/test/css-transitions/; r=hiro
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 14:41:01 +0900 - rev 432268
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1467344 - Use arrow functions in dom/animation/test/css-transitions/; r=hiro This patch also drops the checkStateOnSettingCurrentTimeToZero function since it is no longer used.
f0b7d002a6d545b4aa3390ffa80a00d23faff0e8: Bug 1397768 part 2: Adjust reftests for clarity & to reliably pass on all platforms. (test-only)
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 17 Aug 2018 23:45:39 -0700 - rev 432267
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1397768 part 2: Adjust reftests for clarity & to reliably pass on all platforms. (test-only)
5477aa895b6c983f52325a3841571f4c4ba8f7f6: Bug 1397768 part 1: Make 'display: flex/grid' in a button take up all the available space. r=dholbert
Mihir Iyer <miyer@mozilla.com> - Fri, 17 Aug 2018 07:36:50 -0700 - rev 432266
Push 67953 by dluca@mozilla.com at Sat, 18 Aug 2018 21:39:11 +0000
Bug 1397768 part 1: Make 'display: flex/grid' in a button take up all the available space. r=dholbert
1d20a072ee18eacff4685d7fdd068d10fd650e19: Bug 1484461 - Disable FxA commands r=vladikoff
Edouard Oger <eoger@fastmail.com> - Sat, 18 Aug 2018 18:03:28 +0000 - rev 432265
Push 67952 by eoger@mozilla.com at Sat, 18 Aug 2018 18:04:13 +0000
Bug 1484461 - Disable FxA commands r=vladikoff Differential Revision: https://phabricator.services.mozilla.com/D3703
369762aaed07c4e20d5837219ff55f6f17c28aa8: Bug 1484374 - Update GeckoView to handle the autoplay-media permission request. r=snorp
Randall Barker <rbarker@mozilla.com> - Sat, 18 Aug 2018 17:19:32 +0000 - rev 432264
Push 67951 by rbarker@mozilla.com at Sat, 18 Aug 2018 17:21:02 +0000
Bug 1484374 - Update GeckoView to handle the autoplay-media permission request. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D3680
060ff053ae2764fcbea5f30d39402b6cd33e0789: Bug 1483252 - Replace 0px with 0 throughout menu.css r=dao
Bharat Raghunathan <bharatraghunthan9767@gmail.com> - Sat, 18 Aug 2018 15:20:26 +0000 - rev 432263
Push 67950 by dgottwald@mozilla.com at Sat, 18 Aug 2018 16:01:36 +0000
Bug 1483252 - Replace 0px with 0 throughout menu.css r=dao MozReview-Commit-ID: DiHVfBuSH7V Differential Revision: https://phabricator.services.mozilla.com/D3689
48892db33179b3489126e9097f33b8c96c4c0440: Merge mozilla-central to autoland. a=merge CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Sat, 18 Aug 2018 12:49:03 +0300 - rev 432262
Push 67949 by ncsoregi@mozilla.com at Sat, 18 Aug 2018 09:51:46 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip