4312b2b5dda8c1af7b56ac1c55ab762aff485a2c: Bug 1556556 - Move GetCallbackTransform() into a new ViewportUtils class. r=kats
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:35:05 +0000 - rev 526408
Push 114251 by bballo@mozilla.com at Tue, 28 Apr 2020 07:28:18 +0000
Bug 1556556 - Move GetCallbackTransform() into a new ViewportUtils class. r=kats This function (and helper functions that wrap it) will be used extensively throughout layout code, so keeping it in APZCCallbackHelper seems awkward. nsLayoutUtils would also be a reasonable place but has the downside that adding a new function to it triggers recompiling the world. Differential Revision: https://phabricator.services.mozilla.com/D68296
d11dbf6403a54bd952be24e04c7696415524a02a: Bug 1556556 - Have GetCallbackTransform take just a scroll id rather than an entire guid. r=kats
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:34:48 +0000 - rev 526407
Push 114251 by bballo@mozilla.com at Tue, 28 Apr 2020 07:28:18 +0000
Bug 1556556 - Have GetCallbackTransform take just a scroll id rather than an entire guid. r=kats The implementation was already only using the scroll id, so there is no functional change, but this change will make it easier to new call sites to come up with the function's inputs. Differential Revision: https://phabricator.services.mozilla.com/D68277
95c54c023779ae1f73cbf320bc1e8d4a6c9e6474: Bug 1556556 - Remove APZCCallbackHelper::ApplyCallbackTransform(). r=kats
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:34:35 +0000 - rev 526406
Push 114251 by bballo@mozilla.com at Tue, 28 Apr 2020 07:28:18 +0000
Bug 1556556 - Remove APZCCallbackHelper::ApplyCallbackTransform(). r=kats It has no more callers. Differential Revision: https://phabricator.services.mozilla.com/D68276
80fcb7e711880feb459f82e3869486108859a049: Bug 1556556 - Remove applications of the visual-to-layout transform at the process boundary (and equivalent places for non-e10s). r=kats
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:34:22 +0000 - rev 526405
Push 114251 by bballo@mozilla.com at Tue, 28 Apr 2020 07:28:18 +0000
Bug 1556556 - Remove applications of the visual-to-layout transform at the process boundary (and equivalent places for non-e10s). r=kats Note that the propagation of the target guid to places where the transform will be applied is best-effort at the moment. In particular, the InputAPZContext will result in the correct guid being available in places that are called synchronously from the Recv*() functions, but not places called asynhcronously (e.g. via DelayedFireSingleTapEvent). To mitigate this, places where the transform is applied fall back on the RCD-RSF if a guid is not available via InputAPZContext (added in a subsequent patch). The cases that this gets wrong are fairly edge casey (it requires (a) an asynchronous codepath, (b) an event targeting a subframe, and (c) that subframe having a "could not accept the APZ scroll position" transform), so we just punt on them for now. If it turns out to be important to handle, then options for doing so include (1) propagating the guid through each of the affected asynchronous codepaths, or (2) attaching the guid to the event itself. Differential Revision: https://phabricator.services.mozilla.com/D68723
d75a4ecb0d47cf01b07964aad0e084214f7735c6: Bug 1556556 - Change the default value of InputAPZContext::sApzResponse to nsEventStatus_eSentinel. r=kats
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:34:05 +0000 - rev 526404
Push 114251 by bballo@mozilla.com at Tue, 28 Apr 2020 07:28:18 +0000
Bug 1556556 - Change the default value of InputAPZContext::sApzResponse to nsEventStatus_eSentinel. r=kats Differential Revision: https://phabricator.services.mozilla.com/D70084
903c4de34e7a840063563e0e963d67ba5c0b3c69: Bug 1556556 - Factor out an APZCCallbackHelper::GetCallbackTransform() helper. r=kats
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:33:57 +0000 - rev 526403
Push 114251 by bballo@mozilla.com at Tue, 28 Apr 2020 07:28:18 +0000
Bug 1556556 - Factor out an APZCCallbackHelper::GetCallbackTransform() helper. r=kats This is to facilitate call sites that need to incorporate the transform into a larger transform matrix rather than immediately applying the callback transform to a point. Differential Revision: https://phabricator.services.mozilla.com/D68275
f15334a3e803ee64368625a4730dea103d0a130d: Bug 1556556 - Clarify the documentation of APZCCallbackHelper::ApplyCallbackTransform(). r=kats
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 01:33:40 +0000 - rev 526402
Push 114251 by bballo@mozilla.com at Tue, 28 Apr 2020 07:28:18 +0000
Bug 1556556 - Clarify the documentation of APZCCallbackHelper::ApplyCallbackTransform(). r=kats Differential Revision: https://phabricator.services.mozilla.com/D68274
9553e99137eadc9443532a044a430e82c9efd72f: Bug 1556556 - Remove some cruft related to handling the resolution in non-e10s setups. r=tnikkel
Botond Ballo <botond@mozilla.com> - Tue, 28 Apr 2020 02:03:18 +0000 - rev 526401
Push 114251 by bballo@mozilla.com at Tue, 28 Apr 2020 07:28:18 +0000
Bug 1556556 - Remove some cruft related to handling the resolution in non-e10s setups. r=tnikkel Prior to this bug, it was necessary to handle non-e10s specially, because the resolution was being unapplied at the process boundary, and in non-e10s there was no process boundary. The remaining patches in this bug move the resolution unapplication away from the process boundary in all cases, making special handling for non-e10s unnecessary. Differential Revision: https://phabricator.services.mozilla.com/D68273
55ac8f5b94725889afb734edbc27bc3d799277c7: Bug 1632301 - part4 : rename 'ControlledMediaState' to 'MediaPlaybackState'. r=bryce
alwu <alwu@mozilla.com> - Tue, 28 Apr 2020 07:14:05 +0000 - rev 526400
Push 114250 by alwu@mozilla.com at Tue, 28 Apr 2020 07:14:58 +0000
Bug 1632301 - part4 : rename 'ControlledMediaState' to 'MediaPlaybackState'. r=bryce This patch will do : - rename `ControlledMediaState` to `MediaPlaybackState` - rename the related functions The advantage of doing so : - more consistent with `MediaAudibleState` Differential Revision: https://phabricator.services.mozilla.com/D72060
ddf995c1bb1d16c79e4f48c4537e714f45fcceea: Bug 1632301 - part3 : use MediaAudibleState to replace boolean value. r=bryce
alwu <alwu@mozilla.com> - Tue, 28 Apr 2020 07:14:05 +0000 - rev 526399
Push 114250 by alwu@mozilla.com at Tue, 28 Apr 2020 07:14:58 +0000
Bug 1632301 - part3 : use MediaAudibleState to replace boolean value. r=bryce This patch will do : - replace `boolean` with enum class `MediaAudibleState` The advantage of doing so : - It's easier to understand what actually meaning of the parameter we set Differential Revision: https://phabricator.services.mozilla.com/D72058
636b863fce4b5370f9b306b56b7ffee0257d68e4: Bug 1632301 - part2 : use `ContentControlKeyEventReceiver`'s browsing context to notify any changes. r=bryce
alwu <alwu@mozilla.com> - Tue, 28 Apr 2020 05:10:21 +0000 - rev 526398
Push 114250 by alwu@mozilla.com at Tue, 28 Apr 2020 07:14:58 +0000
Bug 1632301 - part2 : use `ContentControlKeyEventReceiver`'s browsing context to notify any changes. r=bryce This patch will do : - use current broswing context as a parameter when propagate state change to the chrome process. The advantage of doing so : - the chrome process can know which browsing context the state change actually comes from. --- More details about this change : Currently, when we propagate any controlled media related states, we would find the top level browsing context first, then pass it through IPC in order to get the correct media controller in the chrome process. However, we have implemented [1] which can find the correct media controller even if we are not passing the top level browsing context. In addition, in bug1627999, we would like to know which browsing context those states come from. Therefore, we should replace the top browsing context with the current browsing context where controlled media exists. [1] https://searchfox.org/mozilla-central/rev/41c3ea3ee8eab9ce7b82932257cb80b703cbba67/docshell/base/CanonicalBrowsingContext.cpp#511-515 Differential Revision: https://phabricator.services.mozilla.com/D72056
48ef712d80172a1cc578bc1a4ba529490ab70b5c: Bug 1632301 - part1 : decouple ContentMediaController from MediaControlKeysEventListener/MediaControlKeysEventSource. r=bryce
alwu <alwu@mozilla.com> - Tue, 28 Apr 2020 05:10:03 +0000 - rev 526397
Push 114250 by alwu@mozilla.com at Tue, 28 Apr 2020 07:14:58 +0000
Bug 1632301 - part1 : decouple ContentMediaController from MediaControlKeysEventListener/MediaControlKeysEventSource. r=bryce This patch will do : - remove the inheritance relationship for `ContentControlKeyEventReceiver` and `ContentMediaAgent` and manually implement the methods we need - `MediaControlEventListener` will inherit from `ContentControlKeyEventReceiver` directly The advantage of doing so : - increase the flexibilty of modification of `ContentMediaAgent` and those modification won't affect other classes inherited from `MediaControlKeysEventListener` --- More details about this change : As we would like to extend the class `ContentMediaAgent` and allow the `ContentMediaController` to call its extended method, but if we want to do so in current implementation, the extended method would also affect other classes inherited from `MediaControlKeysEventListener` and that is something we don't want to see. Considering that, I decided to decouple the inheritance relationship and manually create the function I need (which will be implemented in the next patch) Differential Revision: https://phabricator.services.mozilla.com/D72054
064453fc2dac1435319bf0441d442a614137e0f3: Bug 1633391 - Remove tp6-facebook-old test and replace the recording in tp6-facebook desktop tests r=perftest-reviewers,davehunt
Florin Strugariu <fstrugariu@mozilla.com> - Mon, 27 Apr 2020 13:27:48 +0000 - rev 526396
Push 114249 by fstrugariu@mozilla.com at Tue, 28 Apr 2020 07:06:23 +0000
Bug 1633391 - Remove tp6-facebook-old test and replace the recording in tp6-facebook desktop tests r=perftest-reviewers,davehunt Differential Revision: https://phabricator.services.mozilla.com/D72648
a99c73301874690830624ae0a98c7940bc754c7d: Backed out changeset 14568f3c84b6 (bug 1575356) for failures on test_iframe_referrer.html. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Tue, 28 Apr 2020 10:01:30 +0300 - rev 526395
Push 114248 by ncsoregi@mozilla.com at Tue, 28 Apr 2020 07:03:49 +0000
Backed out changeset 14568f3c84b6 (bug 1575356) for failures on test_iframe_referrer.html. CLOSED TREE
14568f3c84b6b7f1c15b940aee0b2a28725530d9: Bug 1575356: Update Mixed Content Blocker to rely on BrowsingContext instead of nsIDocShellTreeItem. r=baku,smaug
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 28 Apr 2020 05:18:28 +0000 - rev 526394
Push 114247 by mozilla@christophkerschbaumer.com at Tue, 28 Apr 2020 05:20:02 +0000
Bug 1575356: Update Mixed Content Blocker to rely on BrowsingContext instead of nsIDocShellTreeItem. r=baku,smaug Differential Revision: https://phabricator.services.mozilla.com/D71547
172220e6d12a5d10bab48c24ce9c87c455ba88e1: Bug 1632500 - Part 2: Add a test case for ensuring the sub-iframes won't get storage access if the cookie behavior is REJECT_TRACKER. r=baku
Tim Huang <tihuang@mozilla.com> - Mon, 27 Apr 2020 14:22:23 +0000 - rev 526393
Push 114246 by tihuang@mozilla.com at Tue, 28 Apr 2020 05:06:47 +0000
Bug 1632500 - Part 2: Add a test case for ensuring the sub-iframes won't get storage access if the cookie behavior is REJECT_TRACKER. r=baku Differential Revision: https://phabricator.services.mozilla.com/D72310
9345d8adcd6a740c0fe76970305e4c29ab78671f: Bug 1632500 - Part 1: Add a first-level iframe check in ContentBlocking::ShouldAllowAccessFor() for cookie behavior REJECT_TRACKER. r=baku
Tim Huang <tihuang@mozilla.com> - Mon, 27 Apr 2020 14:22:16 +0000 - rev 526392
Push 114246 by tihuang@mozilla.com at Tue, 28 Apr 2020 05:06:47 +0000
Bug 1632500 - Part 1: Add a first-level iframe check in ContentBlocking::ShouldAllowAccessFor() for cookie behavior REJECT_TRACKER. r=baku Differential Revision: https://phabricator.services.mozilla.com/D72309
f028f48db9301bebc26f796589fa8852762f1206: Bug 1626128 - Change Golden Gate to depend on `sync15_traits`. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 28 Apr 2020 04:13:04 +0000 - rev 526391
Push 114245 by kcambridge@mozilla.com at Tue, 28 Apr 2020 04:32:24 +0000
Bug 1626128 - Change Golden Gate to depend on `sync15_traits`. r=markh Now that `BridgedEngine` has been moved to `sync15_traits`, we can remove `golden_gate_traits` from the tree, and change Golden Gate to depend on `sync15_traits` directly. This commit also adds a Cargo feature, `services_sync`, which reflects the `MOZ_SERVICES_SYNC` config option. In the future, we'll use this feature to gate implementations of `mozIBridgedSyncEngine`. Differential Revision: https://phabricator.services.mozilla.com/D72784
c54fde7ed1587ad174f6418579847f79c06675a0: Bug 1633639 - Fix new warnings about unused doc comments with rustc 1.43. r=lina
Mike Hommey <mh+mozilla@glandium.org> - Tue, 28 Apr 2020 04:11:09 +0000 - rev 526390
Push 114244 by mh@glandium.org at Tue, 28 Apr 2020 04:22:17 +0000
Bug 1633639 - Fix new warnings about unused doc comments with rustc 1.43. r=lina Differential Revision: https://phabricator.services.mozilla.com/D72793
63a755d0e9b187c54a662e8ffd74bf7476cea905: Bug 1594529 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/media. r=bryce
Chris Peterson <cpeterson@mozilla.com> - Mon, 27 Apr 2020 15:18:07 +0000 - rev 526389
Push 114243 by cpeterson@mozilla.com at Tue, 28 Apr 2020 03:45:31 +0000
Bug 1594529 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/media. r=bryce Depends on D72565 Differential Revision: https://phabricator.services.mozilla.com/D72566
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip