387d8415d05e7f1dc96ed3adb441c54f232baf0d: Bug 1362148 - Call generate_build_props() as part of build(); r=ted
Gregory Szorc <gps@mozilla.com> - Thu, 04 May 2017 17:24:06 -0700 - rev 357854
Push 42518 by gszorc@mozilla.com at Thu, 11 May 2017 19:48:49 +0000
Bug 1362148 - Call generate_build_props() as part of build(); r=ted Previously, this ran during postflight_build(). The magic postflight_* methods are called automagically by BaseScript.run_action() and are only called if the main action method didn't raise. So there should be no functional difference with this commit. The reason I changed this is that a subsequent commit will perform metrics generation from build() and without the build properties file loaded, at least the OS X 64 opt buildbot build doesn't have packageFilename defines, which breaks metrics collection. MozReview-Commit-ID: 54ftuQqGKVi
266e09e18a8e7ba8e9da62d819985e484f939dcb: Bug 1363653 - Make AltDataOutputStreamParent not send any messages after object destruction r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 11 May 2017 21:35:37 +0200 - rev 357853
Push 42517 by valentin.gosu@gmail.com at Thu, 11 May 2017 19:47:57 +0000
Bug 1363653 - Make AltDataOutputStreamParent not send any messages after object destruction r=mayhemer This patch prevents the following error: AltDataOutputStreamChild::Close -> SendClose() AltDataOutputStreamChild::Release -> Send__delete__() AltDataOutputStreamParent::RecvClose() -> SendError() AltDataOutputStreamParent::ActorDestroy -> mIPCOpen = false AltDataOutputStreamChild::RecvError -> === Crash - object was deleted === We introduce the DeleteSelf message. AltDataOutputStreamChild::Release -> SendDeleteSelf() AltDataOutputStreamParent::RecvDeleteSelf -> mIPCOpen = false; SendDeleteSelf() AltDataOutputStreamChild::RecvDeleteSelf -> Send__delete__() The parent will not send any more messages after receiving the DeleteSelf message. MozReview-Commit-ID: I9RQ5I7eSt9
6a82d640aa274f6532528bd45d9e86ede901f44d: Bug 1361912 - Don't invoke `mach build` through bash.exe; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 03 May 2017 18:16:58 -0700 - rev 357852
Push 42516 by gszorc@mozilla.com at Thu, 11 May 2017 19:45:31 +0000
Bug 1361912 - Don't invoke `mach build` through bash.exe; r=ted Executing `mach build` through bash.exe was introduced by 5f379c98b962 / bug 1279011. Why, I don't know. Literally every other invocation of `mach` in mozharness does it directly or via a Python executable (the latter is necessary on Windows since `mach` is not a win32 executable). So, this commit removes bash.exe and executes `mach` via Python like everyone else. MozReview-Commit-ID: GFNUVbfHZdq
23050ffaf6490bb3d7811d586eb174b3c85fd4d6: Bug 1361912 - Stop defining python2.7 executable as sys.executable; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 03 May 2017 18:10:33 -0700 - rev 357851
Push 42516 by gszorc@mozilla.com at Thu, 11 May 2017 19:45:31 +0000
Bug 1361912 - Stop defining python2.7 executable as sys.executable; r=ted The "python2.7" executable is always defined as sys.executable in mozharness configs. This abstraction is not necessary. This commit removes the "python2.7" executable from mozharness configs and just inlines sys.executable instead. MozReview-Commit-ID: 4xiEkoFwekr
402ef9d842a347123d2ba8acf22679272b330f8c: Bug 1361912 - Resolve mach arguments in mozharness action, not in configs; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 03 May 2017 18:04:00 -0700 - rev 357850
Push 42516 by gszorc@mozilla.com at Thu, 11 May 2017 19:45:31 +0000
Bug 1361912 - Resolve mach arguments in mozharness action, not in configs; r=ted Every TaskCluster Windows mozharness config was defining an identical executable entry for "mach-build." For something that's used exactly once and is identical, this is not necessary. This commit moves the login inline into the mozharness Python module. It assumes that if MOZILLABUILD is defined that it points to a MozillaBuild path and we should invoke mach through it using the same mechanism that was defined in the config files. This commit changes behavior on buildbot because it also defines MOZILLABUILD but didn't define "mach-build" before. For whatever reason, TC configs involved bash.exe from their moment of inception (5f379c98b962 / bug 1279011). This commit restores consistency between the environments. I do question whether bash.exe needs to be involved at all. But that's for another commit. MozReview-Commit-ID: I5GXHRJ1Eq0
22e82ca6c1155483303bed7ed67a6cb412a999d2: Backed out changeset fa3f3b08ec2b (bug 1361912) for build bustage. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 11 May 2017 21:40:55 +0200 - rev 357849
Push 42515 by archaeopteryx@coole-files.de at Thu, 11 May 2017 19:41:08 +0000
Backed out changeset fa3f3b08ec2b (bug 1361912) for build bustage. r=backout on a CLOSED TREE
005a8efca0bae931bced9c18c4ab46aa79c99050: Backed out changeset a7a7eb83f9cb (bug 1361912)
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 11 May 2017 21:40:15 +0200 - rev 357848
Push 42515 by archaeopteryx@coole-files.de at Thu, 11 May 2017 19:41:08 +0000
Backed out changeset a7a7eb83f9cb (bug 1361912)
feafde9d5fcab8f690df2fd3be43113db0bce628: Backed out changeset ca3dddda32b0 (bug 1361912)
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 11 May 2017 21:40:11 +0200 - rev 357847
Push 42515 by archaeopteryx@coole-files.de at Thu, 11 May 2017 19:41:08 +0000
Backed out changeset ca3dddda32b0 (bug 1361912)
19aa5a4ceb3c739f460179913bd6309773f1f4e7: Backed out changeset 508966268fab (bug 1362364) for unused variable at toolkit/mozapps/extensions/test/addons/test_cache_certdb/bootstrap.js:74 (linting failure). r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 11 May 2017 21:39:48 +0200 - rev 357846
Push 42515 by archaeopteryx@coole-files.de at Thu, 11 May 2017 19:41:08 +0000
Backed out changeset 508966268fab (bug 1362364) for unused variable at toolkit/mozapps/extensions/test/addons/test_cache_certdb/bootstrap.js:74 (linting failure). r=backout on a CLOSED TREE
c79085f94c572c014be098398450caec68049140: servo: Merge #16807 - Fix clamping of scroll position in window.scrollBy (from mrobinson:scroll-clamping); r=emilio
Martin Robinson <mrobinson@igalia.com> - Thu, 11 May 2017 13:23:39 -0500 - rev 357845
Push 42514 by servo-vcs-sync@mozilla.com at Thu, 11 May 2017 19:27:08 +0000
servo: Merge #16807 - Fix clamping of scroll position in window.scrollBy (from mrobinson:scroll-clamping); r=emilio For rightward and downward overflow the spec says: Let x be max(0, min(x, viewport scrolling area width - viewport width)). Let y be max(0, min(y, viewport scrolling area height - viewport height)). Previously, those operations were reversed, which created negative overflow even when the overflow direction was downward. This change ensures that Servo matches spec behavior. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: e196776c2477f5f204ce1333bd15070afbf9a7f6
508966268fab932a33c9c77be039b6a1b8d3d4ec: Bug 1362364: Lazily load the certificate database into the add-ons manager. r=rhelmer
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 05 May 2017 14:41:31 -0700 - rev 357844
Push 42513 by dtownsend@mozilla.com at Thu, 11 May 2017 19:25:29 +0000
Bug 1362364: Lazily load the certificate database into the add-ons manager. r=rhelmer The lazy loading is a little more complex because we want this to be a constant in the scope so extensions can't trivially replace it. This also changes the test to be more like the proof of concept from bug 1244248. MozReview-Commit-ID: 2P890uRY1Si
ca3dddda32b0274d2ed8d700527b2383da36be2c: Bug 1361912 - Don't invoke `mach build` through bash.exe; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 03 May 2017 18:16:58 -0700 - rev 357843
Push 42512 by gszorc@mozilla.com at Thu, 11 May 2017 19:24:36 +0000
Bug 1361912 - Don't invoke `mach build` through bash.exe; r=ted Executing `mach build` through bash.exe was introduced by 5f379c98b962 / bug 1279011. Why, I don't know. Literally every other invocation of `mach` in mozharness does it directly or via a Python executable (the latter is necessary on Windows since `mach` is not a win32 executable). So, this commit removes bash.exe and executes `mach` via Python like everyone else. MozReview-Commit-ID: GFNUVbfHZdq
a7a7eb83f9cbf1e6dda8472af8aa35fda2edff88: Bug 1361912 - Stop defining python2.7 executable as sys.executable; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 03 May 2017 18:10:33 -0700 - rev 357842
Push 42512 by gszorc@mozilla.com at Thu, 11 May 2017 19:24:36 +0000
Bug 1361912 - Stop defining python2.7 executable as sys.executable; r=ted The "python2.7" executable is always defined as sys.executable in mozharness configs. This abstraction is not necessary. This commit removes the "python2.7" executable from mozharness configs and just inlines sys.executable instead. MozReview-Commit-ID: 4xiEkoFwekr
fa3f3b08ec2bd9932e675c979068cdef8a677127: Bug 1361912 - Resolve mach arguments in mozharness action, not in configs; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 03 May 2017 18:04:00 -0700 - rev 357841
Push 42512 by gszorc@mozilla.com at Thu, 11 May 2017 19:24:36 +0000
Bug 1361912 - Resolve mach arguments in mozharness action, not in configs; r=ted Every TaskCluster Windows mozharness config was defining an identical executable entry for "mach-build." For something that's used exactly once and is identical, this is not necessary. This commit moves the login inline into the mozharness Python module. It assumes that if MOZILLABUILD is defined that it points to a MozillaBuild path and we should invoke mach through it using the same mechanism that was defined in the config files. This commit changes behavior on buildbot because it also defines MOZILLABUILD but didn't define "mach-build" before. For whatever reason, TC configs involved bash.exe from their moment of inception (5f379c98b962 / bug 1279011). This commit restores consistency between the environments. I do question whether bash.exe needs to be involved at all. But that's for another commit. MozReview-Commit-ID: I5GXHRJ1Eq0
5d4eb3398998c30a07708a967a96947beef48718: Bug 1360328 - Dispatch a runnable to RecheckCaptivePortal instead of calling it immediately r=mcmanus
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 08 May 2017 13:19:40 +0200 - rev 357840
Push 42511 by valentin.gosu@gmail.com at Thu, 11 May 2017 19:23:30 +0000
Bug 1360328 - Dispatch a runnable to RecheckCaptivePortal instead of calling it immediately r=mcmanus MozReview-Commit-ID: HUPJUtho7g8
124ed3f87792c21242672f35ff9ad6ff078e16d6: Bug 1361504 - Record compiler warning count in Perfherder; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 03 May 2017 20:30:50 -0700 - rev 357839
Push 42510 by gszorc@mozilla.com at Thu, 11 May 2017 19:20:41 +0000
Bug 1361504 - Record compiler warning count in Perfherder; r=ted `mach build` maintains a persisted database of parsed compiler warnings. The database should be accurate for both clobber and incremental builds. Since we generally want to discourage compiler warnings in the build, it makes sense to collect the number of compiler warnings as a build metric. This commit modifies mozharness to run `mach warnings-list` during post-build metrics collection and report the number of warnings as a Perfherder metric. The alert threshold is set to 1.0, which I think means we should get a Perfherder alert any time the absolute value of compiler warnings changes. Of course, this won't catch instances where we fix 1 compiler warning and add a new one, not changing the absolute count. But it is better than nothing. MozReview-Commit-ID: CKPCeRGs6ot
9240e979a42a63146d552c9e8f089c09273f04e8: Bug 1355927 - Notification bars should use the photon animation curve when appearing/disappearing r=dao,jaws
Jim Porter <jporter@mozilla.com> - Wed, 03 May 2017 15:16:12 -0500 - rev 357838
Push 42509 by squibblyflabbetydoo@gmail.com at Thu, 11 May 2017 19:19:49 +0000
Bug 1355927 - Notification bars should use the photon animation curve when appearing/disappearing r=dao,jaws This patch uses the new Photon animation curve for notification bars as well as supporting `toolkit.cosmeticAnimations.enabled` to disable the animations on notification bars entirely. MozReview-Commit-ID: AHSQR32g6hf
5498721c72fac8b739114f47305efb3de172fc3a: Bug 1364002 - Store the user-made search suggestion choice along with userMadeSearchSuggestionChoice. r=past
Marco Bonardo <mbonardo@mozilla.com> - Thu, 11 May 2017 11:15:47 +0200 - rev 357837
Push 42508 by mak77@bonardo.net at Thu, 11 May 2017 19:10:26 +0000
Bug 1364002 - Store the user-made search suggestion choice along with userMadeSearchSuggestionChoice. r=past MozReview-Commit-ID: 46vXbafZvq9
79f6ba23157ed61893b5ec55624824a07d11abd4: Bug 1364090 - Detach the reload and stop buttons from the location bar. r=johannh
Dão Gottwald <dao@mozilla.com> - Thu, 11 May 2017 19:16:05 +0200 - rev 357836
Push 42507 by dgottwald@mozilla.com at Thu, 11 May 2017 19:05:21 +0000
Bug 1364090 - Detach the reload and stop buttons from the location bar. r=johannh MozReview-Commit-ID: Ltp6EghiI44
1bd9e6b07fc06336d9b4e43586850475648b905d: Part 2: Bug 1348733 - Update tests for site data manager now that we use quota storage manager, r=Gijs
Fischer.json <fischer.json@gmail.com> - Wed, 10 May 2017 09:46:46 -0400 - rev 357835
Push 42506 by ryanvm@gmail.com at Thu, 11 May 2017 18:54:33 +0000
Part 2: Bug 1348733 - Update tests for site data manager now that we use quota storage manager, r=Gijs The patch does - update both the in-content and in-content-old tests - add the offline test page for appcache testing case - update tests for switching to Quota Manager from Permission Manager to get sites list - add one test case of grouping sites across scheme, port and origin attributes by host - add one test case of list site using quota usage or site using appcache MozReview-Commit-ID: 6brLVwzmSgf
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip