37372e77b28202eed1ad2ae0f1b2994b36a02614: Bug 1739114 - Moved privileged WebExtensions permissions in their own JSONSchema type and added a new custom privileged keyword on each privileged manifest fields. r=robwu,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Fri, 20 May 2022 08:55:03 +0000 - rev 618366
Push 163226 by luca.greco@alcacoop.it at Fri, 20 May 2022 08:57:26 +0000
Bug 1739114 - Moved privileged WebExtensions permissions in their own JSONSchema type and added a new custom privileged keyword on each privileged manifest fields. r=robwu,mixedpuppy This patch includes only the subset of D145687 changes related to the reworked JSONSchema data, plus some minor changes to Schemas.jsm to take the new JSONSchema type ("PrivilegedPermissions") and the new custom JSONSchema keyword (the boolean "privileged" property used to identify manifest fields only allowed in privileged extensions). Besides the changes to the schema data, this patch is not expected to introduce any difference in behavior and so it could also land on its own if needed (and the rest of the changes landed separately). Differential Revision: https://phabricator.services.mozilla.com/D146800
3909db95d93498a131619cb5c9ff6fe33b2a8d54: Bug 1766355 - part 6: Make `HTMLEditor::MoveOneHardLineContents` return `MoveNodeResult` with caret point suggestion r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 08:51:41 +0000 - rev 618365
Push 163225 by masayuki@d-toybox.com at Fri, 20 May 2022 08:54:53 +0000
Bug 1766355 - part 6: Make `HTMLEditor::MoveOneHardLineContents` return `MoveNodeResult` with caret point suggestion r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D146402
e65edbe39b68d5ec9a61200e85b7f1b0d27baed0: Bug 1770268 - Add missing Zone-inl.h include in Shape.cpp. r=jandem
Mike Hommey <mh+mozilla@glandium.org> - Fri, 20 May 2022 08:50:54 +0000 - rev 618364
Push 163224 by mh@glandium.org at Fri, 20 May 2022 08:53:25 +0000
Bug 1770268 - Add missing Zone-inl.h include in Shape.cpp. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D146856
e4d0bdba5d61c1e88f6ffe98a4ac8d16b4e5e697: Bug 1766355 - part 5: Make `HTMLEditor::MoveChildrenWithTransaction` and `HTMLEditor::MoveNodeOrChildrenWithTransaction` stop touching `Selection` directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 08:40:59 +0000 - rev 618363
Push 163223 by masayuki@d-toybox.com at Fri, 20 May 2022 08:43:21 +0000
Bug 1766355 - part 5: Make `HTMLEditor::MoveChildrenWithTransaction` and `HTMLEditor::MoveNodeOrChildrenWithTransaction` stop touching `Selection` directly r=m_kato Unfortunately, they call each other. Therefore, this patch updates these 2 methods once. Differential Revision: https://phabricator.services.mozilla.com/D146401
9d61e59261a963188364327a1bf4d207ad910824: Bug 1770302 - Consolidate how the clang targets are configured. r=firefox-build-system-reviewers,andi
Mike Hommey <mh+mozilla@glandium.org> - Fri, 20 May 2022 08:33:15 +0000 - rev 618362
Push 163222 by mh@glandium.org at Fri, 20 May 2022 08:35:42 +0000
Bug 1770302 - Consolidate how the clang targets are configured. r=firefox-build-system-reviewers,andi Differential Revision: https://phabricator.services.mozilla.com/D146874
7fdf0634967b64f5dd517c82e8e9bd7577ed6000: Bug 1770302 - Remove build_libcxx. r=firefox-build-system-reviewers,andi
Mike Hommey <mh+mozilla@glandium.org> - Fri, 20 May 2022 08:33:15 +0000 - rev 618361
Push 163222 by mh@glandium.org at Fri, 20 May 2022 08:35:42 +0000
Bug 1770302 - Remove build_libcxx. r=firefox-build-system-reviewers,andi Bug 1744890 moved build_libcxx out of the individual json configs, and bug 1748056 made it always True. We can now remove it. Differential Revision: https://phabricator.services.mozilla.com/D146873
79c8174b22e49fb91455e822fa867bbb81f117c6: Bug 1770251 - Centralize PGO mozconfig bits. r=firefox-build-system-reviewers,andi
Mike Hommey <mh+mozilla@glandium.org> - Fri, 20 May 2022 08:31:46 +0000 - rev 618360
Push 163221 by mh@glandium.org at Fri, 20 May 2022 08:34:11 +0000
Bug 1770251 - Centralize PGO mozconfig bits. r=firefox-build-system-reviewers,andi Differential Revision: https://phabricator.services.mozilla.com/D146852
f018103a7c22ca7b5f51ac72c50865a6cb621690: Bug 1766355 - part 4: Make `HTMLEditor::MoveNodeWithTransaction` and `HTMLEditor::MoveNodeToEndWithTransaction` return `MoveNodeResult` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 08:28:09 +0000 - rev 618359
Push 163220 by masayuki@d-toybox.com at Fri, 20 May 2022 08:30:48 +0000
Bug 1766355 - part 4: Make `HTMLEditor::MoveNodeWithTransaction` and `HTMLEditor::MoveNodeToEndWithTransaction` return `MoveNodeResult` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D146400
18cc1b0df88f2c8c473e6370cbcff17efd3c4a22: Bug 1766355 - part 3: Make `MoveNodeResult` store caret point suggestion r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 08:28:09 +0000 - rev 618358
Push 163220 by masayuki@d-toybox.com at Fri, 20 May 2022 08:30:48 +0000
Bug 1766355 - part 3: Make `MoveNodeResult` store caret point suggestion r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D146399
95f6971b0c8b0e79c7d75e7e4265d8d093b357ee: Bug 1766355 - part 2: Make `MoveNodeResult` method names alinging to `Result` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 08:28:08 +0000 - rev 618357
Push 163220 by masayuki@d-toybox.com at Fri, 20 May 2022 08:30:48 +0000
Bug 1766355 - part 2: Make `MoveNodeResult` method names alinging to `Result` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D146398
0a70ca805cf39b8a0e570ab7e8e606c226bee620: Bug 1766355 - part 1: Add `MoveNodeTransaction` to handle delete node and insert node in a transaction class instance r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 08:28:08 +0000 - rev 618356
Push 163220 by masayuki@d-toybox.com at Fri, 20 May 2022 08:30:48 +0000
Bug 1766355 - part 1: Add `MoveNodeTransaction` to handle delete node and insert node in a transaction class instance r=m_kato Creating both `DeleteNodeTransaction` and `InsertNodeTransaction` wastes memory. They should be done in an instance instead. Fortunately, no edit action listener checks whether the deleted node is still in the composed document or not, etc. Therefore, we can simply notify them of both deletion and insertion which were done in `EditorBase::InsertNodeWithTransaction` and `EditorBase::DeleteNodeWithTransaction`. Note that previously, the range updater needs to ignore the notifications from them while the node is being moved. However, it does not require anymore. Therefore, this patch makes it stop locking, and that would fix minor problem in the case of legacy mutation event listeners run another edit action. On the other hand, this changes some edge cases handling of `MoveNodeWithTransaction` which are detected by the WPT. According to the previous result of applying this patch, `nsINode::InsertBefore` fails and that leads some errors at updating the changed range. I guess that the cause is that there is some bugs at updating insertion point after deleting the node from the DOM tree around here: https://searchfox.org/mozilla-central/rev/0ffae75b690219858e5a45a39f8759a8aee7b9a2/editor/libeditor/HTMLEditor.cpp#5058-5071 However, it's safely fixed by the new code which does not remove the node from the DOM tree explicitly. So, I think that it's safe to accept this behavior change for web apps in the wild. Differential Revision: https://phabricator.services.mozilla.com/D146397
9570d7e20b59ae9c233048654cae3084abeb05c3: Bug 1769033 - Add OpenBSD sandboxing support r=gaston
Alexandre Lissy <lissyx+mozillians@lissyx.dyndns.org> - Fri, 20 May 2022 08:25:04 +0000 - rev 618355
Push 163219 by alissy@mozilla.com at Fri, 20 May 2022 08:27:33 +0000
Bug 1769033 - Add OpenBSD sandboxing support r=gaston Differential Revision: https://phabricator.services.mozilla.com/D146568
fd2fdaf884e2c805b20216d0fafb8d8a63be0ad3: Bug 1769033 - Dont use major version for libavcodec on OpenBSD r=gaston,media-playback-reviewers,padenot
Alexandre Lissy <lissyx+mozillians@lissyx.dyndns.org> - Fri, 20 May 2022 08:25:03 +0000 - rev 618354
Push 163219 by alissy@mozilla.com at Fri, 20 May 2022 08:27:33 +0000
Bug 1769033 - Dont use major version for libavcodec on OpenBSD r=gaston,media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D146444
dafaccab50af037201040634ce865661981eaa5c: Bug 1730442 - part 7: Rewrite `HTMLEditor::InsertTableRowsWithTransaction()` to collect any cell information before touching the DOM tree r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 07:39:53 +0000 - rev 618353
Push 163218 by masayuki@d-toybox.com at Fri, 20 May 2022 07:44:13 +0000
Bug 1730442 - part 7: Rewrite `HTMLEditor::InsertTableRowsWithTransaction()` to collect any cell information before touching the DOM tree r=m_kato This patch also makes it inserts table rows immediately after the previous row element of the found reference row element to make it insert new table rows immediately after there when inserting position is "after". Typically, it's the parent `<tr>` element of `aCellElement`. Therefore, this approach can preserve text nodes immediately after it which was intentionally inserted by the web apps. Differential Revision: https://phabricator.services.mozilla.com/D146365
9282a4bfd86f95899477c321ce4699df35eb7dee: Bug 1730442 - part 6: Make `HTMLEditor::InsertTableColumnsWithTransaction()` collect all necessary data before touching the DOM tree r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 07:39:53 +0000 - rev 618352
Push 163218 by masayuki@d-toybox.com at Fri, 20 May 2022 07:44:13 +0000
Bug 1730442 - part 6: Make `HTMLEditor::InsertTableColumnsWithTransaction()` collect all necessary data before touching the DOM tree r=m_kato It needs to work with the latest layout information to consider which cell element is the insertion point due to rowspan and colspan. Therefore, this patch makes it collects all cell data before touching the DOM except the case that it needs to normalize the table to make it rectanble. Note that the case requiring the normalizer should be fixed in a later patch. This method is corresponding to an XPCOM method. Therefore, this is tested by `test_nsITableEditor_insertTableColumn.html`. And also it's used by the inline table editor, but we don't have automated tests for this because of no API to get the buttons. Therefore, I tested it by my hand. Note that the old code fails to put caret to newly inserted cell at the reftest situation. This fixes the bug too. Therefore, this changes the reftest's reference. Differential Revision: https://phabricator.services.mozilla.com/D146364
e44e3784a8f29d04635da696998db9558d122581: Bug 1730442 - part 5: Rewrite `HTMLEditor::GetNextTableRowElement()` as returning `Result<RefPtr<Element>, nsresult>` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 07:39:52 +0000 - rev 618351
Push 163218 by masayuki@d-toybox.com at Fri, 20 May 2022 07:44:13 +0000
Bug 1730442 - part 5: Rewrite `HTMLEditor::GetNextTableRowElement()` as returning `Result<RefPtr<Element>, nsresult>` r=m_kato There is no direct test because of no corresponding XPCOM method, but this is called only by `HTMLEditor::InsertTableColumnsWithTransaction()` which is tested by `test_nsITableEditor_insertTableColumn.html`. Anyway, the chagne is really simple. Differential Revision: https://phabricator.services.mozilla.com/D146363
0d370e2abf6d46811b100b6bf4f6dde1da0b6744: Bug 1730442 - part 4: Rewrite `HTMLEditor::GetFirstTableRowElement()` as returing `Result<RefPtr<Element>, nsresult>` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 07:39:52 +0000 - rev 618350
Push 163218 by masayuki@d-toybox.com at Fri, 20 May 2022 07:44:13 +0000
Bug 1730442 - part 4: Rewrite `HTMLEditor::GetFirstTableRowElement()` as returing `Result<RefPtr<Element>, nsresult>` r=m_kato This change is tested by `test_nsITableEditor_getFirstRow.html` and `test_nsITableEditor_insertTableColumn.html`. Differential Revision: https://phabricator.services.mozilla.com/D146362
d51b14fb40ed4eafed16d992bf610eabb6c572cd: Bug 1730442 - part 3: Make `HTMLEditor::InsertTableCellsWithTransaction()` work without layout information r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 07:39:52 +0000 - rev 618349
Push 163218 by masayuki@d-toybox.com at Fri, 20 May 2022 07:44:13 +0000
Bug 1730442 - part 3: Make `HTMLEditor::InsertTableCellsWithTransaction()` work without layout information r=m_kato It refers the layout information for getting row/column index of selected cell element or a cell element which contains selection. However, it can stop referring it if all callers can specify insertion point of new cells, and it's possible. Therefore, we can make it free from layout information. Note that this blocks legacy mutation events during inserting table cell elements, but perhaps this does not cause problems in the wild. `DOMNodeInserted` will be fired after all cell elements are inserted, so from point of view of the event listeners, editor content is different from traditional behavior, but this works only when user uses inline table editor which is disabled by default. I.e., in the wild, this path is rarely run. Additionally, this patch makes it return `CreateElementResult` for the latter changes which want to put caret to first inserted cell element. Note that the changes are tested by `test_nsITableEditor_insertTableColumn.html` and `test_nsITableEditor_insertTableCell.html`. Differential Revision: https://phabricator.services.mozilla.com/D146361
76fac2be98e70e8ebc8f7d972a8a5fd4efb3c34d: Bug 1730442 - part 2: Rewrite `HTMLEditor::GetSelectedOrParentTableElement()` as returing `Result<RefPtr<Element>, nsresult>` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 07:39:51 +0000 - rev 618348
Push 163218 by masayuki@d-toybox.com at Fri, 20 May 2022 07:44:13 +0000
Bug 1730442 - part 2: Rewrite `HTMLEditor::GetSelectedOrParentTableElement()` as returing `Result<RefPtr<Element>, nsresult>` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D146360
b4dcdb40970da4f20b476eb683e491f082ee14b8: Bug 1730442 - part 1: Make all `nsITableEditor` features flush pending layout at start to handle their jobs r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 May 2022 07:39:51 +0000 - rev 618347
Push 163218 by masayuki@d-toybox.com at Fri, 20 May 2022 07:44:13 +0000
Bug 1730442 - part 1: Make all `nsITableEditor` features flush pending layout at start to handle their jobs r=m_kato Our table editor depends on layout information for getting raw/column position of a cell, checking rawspan/colspan information and table size. Therefore, they require the latest information, but they don't flush pending layout by themselves. Therefore, this patch makes them do it by themselves and deleting unnecessary hack from their tests. Differential Revision: https://phabricator.services.mozilla.com/D146359
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip