246124863988e9a247024d8673d378e195231a30: Bug 1348099 part 3 - Fix the codegen so the methods for clearing cached attribute values are not unforgeable. r=bz
Ting-Yu Chou <janus926@gmail.com> - Thu, 29 Jun 2017 17:54:20 +0800 - rev 366826
Push 45755 by tchou@mozilla.com at Fri, 30 Jun 2017 05:37:58 +0000
Bug 1348099 part 3 - Fix the codegen so the methods for clearing cached attribute values are not unforgeable. r=bz Current codegen list the methods for clearing cached attribute values in both chrome only unforgeable methods and chrome only normal methods, but they should exist only in the normal ones. MozReview-Commit-ID: Il2JvCLZ2v3
c2b306e943293cf36b7b5ad5245e4577408c6c07: Bug 1348099 part 2 - Add tests for DOM Xrays that properties are exposed to only proper object types. r=bz
Ting-Yu Chou <janus926@gmail.com> - Thu, 22 Jun 2017 14:43:11 +0800 - rev 366825
Push 45755 by tchou@mozilla.com at Fri, 30 Jun 2017 05:37:58 +0000
Bug 1348099 part 2 - Add tests for DOM Xrays that properties are exposed to only proper object types. r=bz MozReview-Commit-ID: Iu86lAviFJK
3c9580f796845cc704ba5bc3a5e5f9dc80e1bf0e: Bug 1348099 part 1 - Binary search property id when resolve DOM Xrays own property. r=bz
Ting-Yu Chou <janus926@gmail.com> - Mon, 12 Jun 2017 12:13:38 +0800 - rev 366824
Push 45755 by tchou@mozilla.com at Fri, 30 Jun 2017 05:37:58 +0000
Bug 1348099 part 1 - Binary search property id when resolve DOM Xrays own property. r=bz Currently we resolve a property by iterating every prefable and check whether it is enabled. If it is, we linear search the ids that it manages. This patch changes that to binary searching to find whether the id being resolved is present first, and checking whether its prefable is enabled only when we find it. This improves the performance of property resolution, especially when the property is not present. The patch stores all the property ids a NativePropertiesN owns in a single array of PropertyInfo structs. Each struct contains an id and the information needed to find the corresponding Prefable for the enabled check, as well as the information needed to find the correct property descriptor in the Prefable. We also store an array of indices into the PropertyInfo array, sorted by bits of the corresponding jsid. Given a jsid, this allows us to binary search for the index of the corresponding PropertyInfo, if any. The index array requires 2 bytes for each property, which is ~20k across all our bindings. The extra information stored in each PropertyInfo requires 4 bytes for each property, which is about 40k across all our bindings in 32-bit builds, or 80k in 64-bit builds due to alignment requirements on PropertyInfo. However we save a bit of memory from changing NativePropertiesN's trios to duos. The array of unsorted ids is kept because XrayOwnPropertyKeys() includes only properties that are enabled. Without it, we will need to check every single property to know whether its prefable is enabled or not, which is inefficient. With this patch, initializing property ids takes longer because of the sorting. I measured also insertion sort because I thought the ids should be nearly sorted as they are generated sequentially at run time, but that's not the case and NS_QuickSort() runs faster. MozReview-Commit-ID: Lc4Z1ui3t0o
e0882faffdd74c73d746c302a28ff6d296f73ba5: Bug 1373256 - Changes to support -fsanitize=integer in the codebase. r=froydnj
Christian Holler <choller@mozilla.com> - Sun, 09 Apr 2017 12:59:26 +0200 - rev 366823
Push 45754 by choller@mozilla.com at Fri, 30 Jun 2017 05:24:49 +0000
Bug 1373256 - Changes to support -fsanitize=integer in the codebase. r=froydnj The -fsanitize=integer analysis from UBSan can be helpful to detect signed and unsigned integer overflows in the codebase. Unfortunately, those occur very frequently, making it impossible to test anything with it without the use of a huge blacklist. This patch includes a blacklist that is broad enough to silence everything that would drain performance too much. But even with this blacklist, neither tests nor fuzzing is "clean". We can however in the future combine this with static analysis to limit ourselves to interesting places to look at, or improve the dynamic analysis to omit typical benign overflows. It also adds another attribute that can be used on functions. It is not used right now because it was initially easier to add things to the compile-time blacklist to get started. Finally, it includes a runtime suppression list and patches various parts in the test harnesses to support that. It is currently empty and it should not be used on frequent overflows because it is expensive. However, it has the advantage that it can be used to differentiate between signed and unsigned overflows while the compile-time blacklist cannot do that. So it can be used to e.g. silence unsigned integer overflows on a file or function while still reporting signed issues. We can also use this suppression list for any other UBSan related suppressions, should we ever want to use other features from that sanitizer. MozReview-Commit-ID: C5ofhfJdpCS
31f204fd055003ec1487597a79be89147452ab74: Bug 1363059 - Add a test for images loaded at startup vs. images shown at startup. r=florian,jwatt
Johann Hofmann <jhofmann@mozilla.com> - Thu, 15 Jun 2017 00:11:48 +0200 - rev 366822
Push 45753 by jhofmann@mozilla.com at Fri, 30 Jun 2017 05:02:59 +0000
Bug 1363059 - Add a test for images loaded at startup vs. images shown at startup. r=florian,jwatt This patch enables startupRecorder.js to collect data on loaded and shown raster and SVG images on startup via events from native code. It also adds a test that uses this data to find images that are unnecessarily loaded. I've not fixed any of the affected images yet, there's a fairly comprehensive whitelist that I want to gradually decrease by opening bugs in the respective components. MozReview-Commit-ID: 9KqQvKLtZhu
23c4b7136fd65e8dc167493eb4806350372e3fd9: Bug 1354336 - Require all browser_style elements to have the browser-style class r=mikedeboer
Matthew Wein <mwein@mozilla.com> - Fri, 23 Jun 2017 13:54:19 -0400 - rev 366821
Push 45752 by jwein@mozilla.com at Fri, 30 Jun 2017 04:49:42 +0000
Bug 1354336 - Require all browser_style elements to have the browser-style class r=mikedeboer MozReview-Commit-ID: 6bQZDa3zZA3
999d51686767d7e61e6b9e2efc51fd8a8308a37c: Bug 1213414 - Implement channelCount audio constraint. r=jib,padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 29 Jun 2017 21:01:17 -0700 - rev 366820
Push 45751 by achronop@gmail.com at Fri, 30 Jun 2017 04:04:22 +0000
Bug 1213414 - Implement channelCount audio constraint. r=jib,padenot MozReview-Commit-ID: K95iBYOE1nR
d696d4dde21c164170b83ddee73ef2147bf4f9f6: Bug 1213414 - Add channelCount constraint in webidl file. r=jib,padenot,smaug
Alex Chronopoulos <achronop@gmail.com> - Thu, 29 Jun 2017 20:59:30 -0700 - rev 366819
Push 45751 by achronop@gmail.com at Fri, 30 Jun 2017 04:04:22 +0000
Bug 1213414 - Add channelCount constraint in webidl file. r=jib,padenot,smaug MozReview-Commit-ID: G8r11l1lEYr
144114baf865f75b8bccf4d5290de62e975f92d2: Backed out changeset 07b3b72fe522 (bug 1373159) for failures in context-fill-opacity and context-stroke-opacity reftests on Windows 8
Phil Ringnalda <philringnalda@gmail.com> - Thu, 29 Jun 2017 19:56:20 -0700 - rev 366818
Push 45750 by philringnalda@gmail.com at Fri, 30 Jun 2017 02:56:28 +0000
Backed out changeset 07b3b72fe522 (bug 1373159) for failures in context-fill-opacity and context-stroke-opacity reftests on Windows 8 MozReview-Commit-ID: FC6LKD9ZegJ
a4d028c197ef201b335cbd950fc8065e7587a374: Bug 1344910, part 2 - Add a '-moz-win-accentcolortext' color keyword to color text that will be drawn over an accent color background. r=jimm
Jonathan Watt <jwatt@jwatt.org> - Thu, 29 Jun 2017 18:54:07 -0700 - rev 366817
Push 45749 by ecoal95@gmail.com at Fri, 30 Jun 2017 01:57:59 +0000
Bug 1344910, part 2 - Add a '-moz-win-accentcolortext' color keyword to color text that will be drawn over an accent color background. r=jimm on a CLOSED TREE, because it failed to autoland before bug 1344917 landed. MozReview-Commit-ID: 9l2NsQlewIJ
963efb32d8224c3cb57f5dbd65556b946bc06151: Bug 1344910, part 1 - Add a '-moz-win-accentcolor' color keyword to expose the Win10 accent color. r=jimm
Jonathan Watt <jwatt@jwatt.org> - Thu, 29 Jun 2017 18:51:56 -0700 - rev 366816
Push 45749 by ecoal95@gmail.com at Fri, 30 Jun 2017 01:57:59 +0000
Bug 1344910, part 1 - Add a '-moz-win-accentcolor' color keyword to expose the Win10 accent color. r=jimm on a CLOSED TREE, because it failed to autoland before bug 1344917 landed. MozReview-Commit-ID: 9jMMVnnSF5h
1d14a426b9af04d65c1636ec0551522d11a6c0c9: Bug 1377025. P2 - dispatch intrinsic size changes to the main thread. r=cpearce
JW Wang <jwwang@mozilla.com> - Thu, 29 Jun 2017 10:27:38 +0800 - rev 366815
Push 45748 by jwwang@mozilla.com at Fri, 30 Jun 2017 01:51:14 +0000
Bug 1377025. P2 - dispatch intrinsic size changes to the main thread. r=cpearce So we can remove the use of mMutex from InvalidateWithFlags(). MozReview-Commit-ID: 75pHDM5xYYb
c1b4b68e161a2a6faa031cd6e22572dd56a8766c: Bug 1377025. P1 - dispatch image size changes to the main thread so mImageSizeChanged is for main thread only. r=cpearce
JW Wang <jwwang@mozilla.com> - Wed, 28 Jun 2017 23:04:49 +0800 - rev 366814
Push 45748 by jwwang@mozilla.com at Fri, 30 Jun 2017 01:51:14 +0000
Bug 1377025. P1 - dispatch image size changes to the main thread so mImageSizeChanged is for main thread only. r=cpearce MozReview-Commit-ID: 6rpxjSVAY2h
d7dca95a5bc8406da48488876094ce113e50aae7: Bug 1344917, part 2 - Add tests for the '-moz-windows-accent-color-applies' media query. r=heycam
Jonathan Watt <jwatt@jwatt.org> - Thu, 08 Jun 2017 15:05:37 +0100 - rev 366813
Push 45747 by ecoal95@gmail.com at Fri, 30 Jun 2017 01:36:44 +0000
Bug 1344917, part 2 - Add tests for the '-moz-windows-accent-color-applies' media query. r=heycam MozReview-Commit-ID: 5lzVIVucvj2
d07b25fd6533f06a5f887b96320a334e85c7693d: Bug 1344917, part 1 - Add a '-moz-windows-accent-color-applies' media query. r=heycam
Jonathan Watt <jwatt@jwatt.org> - Thu, 08 Jun 2017 14:49:21 +0100 - rev 366812
Push 45747 by ecoal95@gmail.com at Fri, 30 Jun 2017 01:36:44 +0000
Bug 1344917, part 1 - Add a '-moz-windows-accent-color-applies' media query. r=heycam The '-moz-windows-accent-color-applies' media query matches when the Windows 10 accent color should be used as the background of the title bar. MozReview-Commit-ID: GM7nZij6MhQ
990cbc0aaded791bf33810088ea47f28fd748ff7: servo: Merge #17571 - style: Update Stylo bindings for new LookAndFeel_ColorID variants (from emilio:jwatt); r=emilio
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Jun 2017 17:39:23 -0700 - rev 366811
Push 45746 by servo-vcs-sync@mozilla.com at Fri, 30 Jun 2017 01:28:23 +0000
servo: Merge #17571 - style: Update Stylo bindings for new LookAndFeel_ColorID variants (from emilio:jwatt); r=emilio Rebase of https://github.com/servo/servo/pull/17449 Source-Repo: https://github.com/servo/servo Source-Revision: 8029f1a1bbe9721f5bd1a3772c9573e2b700dcc6
96d2fe764ef8e35d01f51bfa781de114cd03cd45: Bug 1354159 - Part 4 - Implement the style changes necessary to properly view the new Bookmarks view inside the Library Panel. r=Gijs,mak
Mike de Boer <mdeboer@mozilla.com> - Thu, 29 Jun 2017 17:57:28 -0700 - rev 366810
Push 45745 by mdeboer@mozilla.com at Fri, 30 Jun 2017 01:09:40 +0000
Bug 1354159 - Part 4 - Implement the style changes necessary to properly view the new Bookmarks view inside the Library Panel. r=Gijs,mak MozReview-Commit-ID: 2tPH89DXbcp
28e8a3011a4cd3979929af8e7c52a1587746203b: Bug 1354159 - Part 3 - Add a Bookmarks button to the Library panel that shows a subview with a list of most recent bookmarks. r=Gijs,mak
Mike de Boer <mdeboer@mozilla.com> - Thu, 29 Jun 2017 17:57:25 -0700 - rev 366809
Push 45745 by mdeboer@mozilla.com at Fri, 30 Jun 2017 01:09:40 +0000
Bug 1354159 - Part 3 - Add a Bookmarks button to the Library panel that shows a subview with a list of most recent bookmarks. r=Gijs,mak This patch changes the Recent Bookmarks flow in browser-places.js to use the new PlacesPanelview to provide a rich view that support drag and drop and context actions. A new button 'Search Bookmarks' was added, which prefills the urlbar with '* ', which is a shortcut for searching bookmarks using the Awesomebar. MozReview-Commit-ID: 1XlO8HMKEJs
17a5f1a17cbd968a4434b61021a230c0956bdd91: Bug 1354159 - Part 2 - Introduce a new Places view type, PlacesPanelview, which can visualize query results inside panelview nodes. r=Gijs,mak
Mike de Boer <mdeboer@mozilla.com> - Thu, 29 Jun 2017 17:57:24 -0700 - rev 366808
Push 45745 by mdeboer@mozilla.com at Fri, 30 Jun 2017 01:09:40 +0000
Bug 1354159 - Part 2 - Introduce a new Places view type, PlacesPanelview, which can visualize query results inside panelview nodes. r=Gijs,mak MozReview-Commit-ID: Ft1RC7dsqKD
e4f311094669b6e4b88b1f0d76e0df55c6f37b40: Bug 1354159 - Part 1 - Remove the unneeded third 'view' argument from PlacesUIUtils.openNodeWithEvent(). r=mak
Mike de Boer <mdeboer@mozilla.com> - Thu, 29 Jun 2017 17:57:22 -0700 - rev 366807
Push 45745 by mdeboer@mozilla.com at Fri, 30 Jun 2017 01:09:40 +0000
Bug 1354159 - Part 1 - Remove the unneeded third 'view' argument from PlacesUIUtils.openNodeWithEvent(). r=mak MozReview-Commit-ID: Jema2qMYEdX
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip