1cf96914dd193a3a596e6b35a12fdaeb816e095a: Bug 1586165 - Null check ionCounts_ before calling sizeOfIncludingThis on it. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Fri, 04 Oct 2019 12:46:20 +0000 - rev 496328
Push 97169 by jdemooij@mozilla.com at Fri, 04 Oct 2019 12:48:11 +0000
Bug 1586165 - Null check ionCounts_ before calling sizeOfIncludingThis on it. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D48163
fc32527395e2f6c83fe7c84708f08abe8ef04fae: Bug 1583479 - Fix case-insensitive comparison when comparing against the home page ignore list when setting the home page value. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Fri, 04 Oct 2019 11:45:19 +0000 - rev 496327
Push 97168 by mbanner@mozilla.com at Fri, 04 Oct 2019 12:39:27 +0000
Bug 1583479 - Fix case-insensitive comparison when comparing against the home page ignore list when setting the home page value. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D48169
4fc14159ba6925ee071ec7d1a2425b4612f5bc0d: Bug 1585529 - Fix invoke getter button for properties with quotes. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 04 Oct 2019 12:08:28 +0000 - rev 496326
Push 97167 by nchevobbe@mozilla.com at Fri, 04 Oct 2019 12:10:30 +0000
Bug 1585529 - Fix invoke getter button for properties with quotes. r=Honza. Bug 1584244 fixed some of the issue for getters, but not all of them. Instead of trying to unescape the node name, we put the actual property name into the node, so we can reuse it later. Differential Revision: https://phabricator.services.mozilla.com/D47876
2ced9171e5e9f5fce85e8ee301f477ae6c58b990: Bug 1572717 - Add margin after the bookmark icon in the bookmark toolbar when in Customize mode r=dao
Itiel <itiel_yn8@walla.com> - Fri, 04 Oct 2019 11:05:39 +0000 - rev 496325
Push 97166 by dgottwald@mozilla.com at Fri, 04 Oct 2019 11:51:20 +0000
Bug 1572717 - Add margin after the bookmark icon in the bookmark toolbar when in Customize mode r=dao Differential Revision: https://phabricator.services.mozilla.com/D42012
f8cb03296bac00d553fbd1d6dd3e9bd0a578a3dc: Bug 1586136 - enable browser_customization_context_menus.js for fission r=zbraniecki
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 04 Oct 2019 09:36:16 +0000 - rev 496324
Push 97165 by gijskruitbosch@gmail.com at Fri, 04 Oct 2019 10:11:28 +0000
Bug 1586136 - enable browser_customization_context_menus.js for fission r=zbraniecki Differential Revision: https://phabricator.services.mozilla.com/D48160
65774de3c491c531230d0e4bc9027996f9af6aa3: Bug 1586225 - Allow wpt metadata update to use fisson setting, r=ato
James Graham <james@hoppipolla.co.uk> - Fri, 04 Oct 2019 09:48:35 +0000 - rev 496323
Push 97164 by james@hoppipolla.co.uk at Fri, 04 Oct 2019 09:51:13 +0000
Bug 1586225 - Allow wpt metadata update to use fisson setting, r=ato Differential Revision: https://phabricator.services.mozilla.com/D48162
f4d6ae41f3877454525a05bd53a618d978f0215a: bug 1585949: geckodriver: get rid of regex use in tests; r=webdriver-reviewers,whimboo
Andreas Tolfsen <ato@sny.no> - Fri, 04 Oct 2019 09:48:23 +0000 - rev 496322
Push 97163 by atolfsen@mozilla.com at Fri, 04 Oct 2019 09:50:42 +0000
bug 1585949: geckodriver: get rid of regex use in tests; r=webdriver-reviewers,whimboo Regular expressions are expensive, both in runtime cost and compile-time cost of the regex crate. This is the first step towards getting rid of the regex dependency in geckodriver. Differential Revision: https://phabricator.services.mozilla.com/D48053
d8211c6625d66a64a86ee5e29f00d19d41014e3f: Bug 1547961 - [remote] Unskip browser_runtime_executionContext.js on Mac and Windows. r=remote-protocol-reviewers,ato
Henrik Skupin <mail@hskupin.info> - Fri, 04 Oct 2019 09:35:48 +0000 - rev 496321
Push 97162 by hskupin@mozilla.com at Fri, 04 Oct 2019 09:39:01 +0000
Bug 1547961 - [remote] Unskip browser_runtime_executionContext.js on Mac and Windows. r=remote-protocol-reviewers,ato Differential Revision: https://phabricator.services.mozilla.com/D48161
718ef1098af5c0d5a9b39a33944b8647b0c56a49: Bug 1571487 - Implement MathML DOM r=bzbarsky
Frederic Wang <fred.wang@free.fr> - Fri, 04 Oct 2019 08:45:04 +0000 - rev 496320
Push 97161 by nbeleuzu@mozilla.com at Fri, 04 Oct 2019 09:28:08 +0000
Bug 1571487 - Implement MathML DOM r=bzbarsky See https://groups.google.com/forum/#!topic/mozilla.dev.platform/ssTytf-pT7k Differential Revision: https://phabricator.services.mozilla.com/D45034
d7ab956c296257c99630aa0d4e91d41434c55137: Bug 1582407 - Fix MediaRecorder-pause-resume.html to avoid start() ambiguities. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 22:11:07 +0000 - rev 496319
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1582407 - Fix MediaRecorder-pause-resume.html to avoid start() ambiguities. r=jib The spec allows for MediaRecorder.start() to hold the "start" event until it has collected some actual data. This means "pause" and "resume" events can occur before "start", on the contrary of this testcase. This patch avoids this ambiguity by: 1) Drawing a frame to the canvas so that the track contains some real data. 2) Wait for "start" before pause()ing, to ensure "start" comes first. Note that without 1), 2) could wait indefinitely, resulting in a timeout. Differential Revision: https://phabricator.services.mozilla.com/D46470
8104d82879e2f73ba695ee0a8b6c7005418f0819: Bug 1582408 - Fix MediaRecorderErrorEvent boilerplate in idlharness.window.js. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 22:11:00 +0000 - rev 496318
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1582408 - Fix MediaRecorderErrorEvent boilerplate in idlharness.window.js. r=jib Differential Revision: https://phabricator.services.mozilla.com/D46468
8f67e6f39d7bd5e8525f879dff78d5b17658931f: Bug 1512175 - Make test_mr_creation_fail.html spec compliant and test the error name. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 22:10:52 +0000 - rev 496317
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1512175 - Make test_mr_creation_fail.html spec compliant and test the error name. r=jib Differential Revision: https://phabricator.services.mozilla.com/D48106
d65b19aacfbdb5d211c7ede90a95ddd12f5eef25: Bug 1512175 - Ensure there is data available immediately after the "start" event. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 22:10:43 +0000 - rev 496316
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1512175 - Ensure there is data available immediately after the "start" event. r=jib This patch does two things: 1) Extracts data before firing "start", instead of after, so that any `requestData()` or timeslice-based "dataavailable" event fired immediately after "start" contains data. 2) Sets mLastBlobTimeStamp on encoder initialization instead of session construction, so that any "dataavailable" events are held back until some actual data has been gathered. Differential Revision: https://phabricator.services.mozilla.com/D46466
343e4bf9c1ed04c018f54cfa1bf9a242c2ed0e6f: Bug 1512175 - Don't remove tracks from the MediaEncoder on stream-removal. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 22:10:31 +0000 - rev 496315
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1512175 - Don't remove tracks from the MediaEncoder on stream-removal. r=jib We're immediately after explicitly stopping the recording anyway. Differential Revision: https://phabricator.services.mozilla.com/D46465
b43a92f049c198d0de2ee8d485d9a476bb2505df: Bug 1512175 - Expand on MediaRecorder DOM exception throwing with messages. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 22:10:24 +0000 - rev 496314
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1512175 - Expand on MediaRecorder DOM exception throwing with messages. r=jib Differential Revision: https://phabricator.services.mozilla.com/D46464
85af0c8641abb9516e88c3e72244f98da7465c3f: Bug 1512175 - Adapt mochitests to spec compliant mime type handling. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 22:10:11 +0000 - rev 496313
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1512175 - Adapt mochitests to spec compliant mime type handling. r=jib Differential Revision: https://phabricator.services.mozilla.com/D17812
dca395faee362d831f36cda88562d346d441fb3a: Bug 1512175 - Rename and adapt test_mr_unsupported_src.html. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 22:10:04 +0000 - rev 496312
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1512175 - Rename and adapt test_mr_unsupported_src.html. r=jib With spec compliant mime type handling we no longer fire "error" on start for a audio-only recording of a (currently) video-only MediaStream. This patch adapts the test to more accurately name what we originally wanted to test - that pause() after an error doesn't crash but throws. It does this by triggering another kind of error, one that happens because we try to remove the recorded track from the recorded stream. We still keep the behavior of start()ing the recording before any supported tracks are available, because we support that. To clarify what this test is actually testing, this patch also modernizes the code with async/await to linearize the testing of events and their order. Differential Revision: https://phabricator.services.mozilla.com/D17811
d3c6648507db2ba484b1e872bf4e52ca8a2eea3b: Bug 1512175 - Remove test_mr_getencodeddata.html. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 22:09:52 +0000 - rev 496311
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1512175 - Remove test_mr_getencodeddata.html. r=jib This test relied on us choosing to record audio/ogg because of the only audio track, which would fail and result in an error with ogg support disabled. We now per spec select mime type synchronously on construction instead of after detecting the stream's tracks - and so fall back to video/webm when the mime type is defaulted. With this the test times out because we're recording fine. When disabling also webm encoding we follow the spec's "note that this case is essentially equivalent to leaving up to the UA the choice of container and codecs on constructor", and choose some unknown mime type that is not supported (none are), thus ending up throwing NotSupportedError. Not much remains of this test with these changes, and what actually remains is covered by other tests, which warrants removal. Differential Revision: https://phabricator.services.mozilla.com/D17810
3bc62d21ad37821aa7d448f6cb5a1bc3a14697ca: Bug 1512175 - Extend the constrained MediaRecorder mime type when needed. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Fri, 04 Oct 2019 09:06:08 +0000 - rev 496310
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1512175 - Extend the constrained MediaRecorder mime type when needed. r=jib This is the last step to making the MediaRecorder's mime type handling up to spec, and has a real effect only if the constrained mime type is empty, or doesn't contain any codecs. Differential Revision: https://phabricator.services.mozilla.com/D17809
c08c0b553f15230b8e6944181cdd9c1c25cb8fbf: Bug 1512175 - Implement MediaRecorder MIME type constraining to spec. r=jib,smaug,bryce
Andreas Pehrson <apehrson@mozilla.com> - Thu, 03 Oct 2019 22:09:38 +0000 - rev 496309
Push 97160 by pehrsons@gmail.com at Fri, 04 Oct 2019 09:26:59 +0000
Bug 1512175 - Implement MediaRecorder MIME type constraining to spec. r=jib,smaug,bryce This leaves out support for extending the mime type with the selected container and codecs, and support in MediaEncoder for using a specific mime type. Differential Revision: https://phabricator.services.mozilla.com/D46463
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip