1cf1f3a90672c2c0db5492d8f3ad699d94324fa7: Bug 1351926. Set the resize flags to false at the beginning of InitResizeFlags, so stale values from an old (incorrect) computed bsize won't keep being propagated in cases when we SetComputedWidth or SetComputedHeight on the ReflowInput. r=dbaron
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 05 Apr 2017 23:07:40 -0400 - rev 351551
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 1351926. Set the resize flags to false at the beginning of InitResizeFlags, so stale values from an old (incorrect) computed bsize won't keep being propagated in cases when we SetComputedWidth or SetComputedHeight on the ReflowInput. r=dbaron MozReview-Commit-ID: 56YFAw3KOmi
dad7b2f08efdc23bc1234055c05a7c1c4d107b09: Bug 1352996. Remove vestige of AvailableIn/CheckAnyPermissions/CheckAllPermissions from WebIDL.py. r=qdot
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 05 Apr 2017 23:04:26 -0400 - rev 351550
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 1352996. Remove vestige of AvailableIn/CheckAnyPermissions/CheckAllPermissions from WebIDL.py. r=qdot MozReview-Commit-ID: HsvhRefytXQ
001fd3755ac1810318bb7118b96ebbcc2a3e4a83: Bug 812687 part 9: Add tests for "order" property's influence on list-numbering, baseline, and focus order in a flexbox. (no review, test-only)
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 19:31:48 -0700 - rev 351549
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 812687 part 9: Add tests for "order" property's influence on list-numbering, baseline, and focus order in a flexbox. (no review, test-only) MozReview-Commit-ID: EEkPlCgzknG
0a1df59228cbd98e22f729670b70901164ed8e1f: Bug 812687 part 8: Add a test for "order" on flex items with abspos siblings. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 19:31:48 -0700 - rev 351548
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 812687 part 8: Add a test for "order" on flex items with abspos siblings. r=mats MozReview-Commit-ID: aCBQER5r2G
51504aea09b0792729e49ff82460e41789a520f6: Bug 812687 part 7: Minor cleanup in existing test_flexbox_order mochitests. (no review, test-only)
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 19:31:47 -0700 - rev 351547
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 812687 part 7: Minor cleanup in existing test_flexbox_order mochitests. (no review, test-only) This patch: - does s/var/let/ to upgrade to modern JS best-practices. - Wraps some lines that are too long. - Changes loops to "for (let foo of [...])" rather than foreach+function-pointer. - Changes some copypasted cleanup code to use a loop instead (which will be especially useful in a forthcoming version of this test that'll add another thing to clean up). MozReview-Commit-ID: DWK8jFbfqeB
c1034f23ceb83fc5c1e60109cf56187d9ed14641: Bug 812687 part 6: Rename & invert polarity of a flexbox frame-state-bit, for consistency with grid. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 19:31:47 -0700 - rev 351546
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 812687 part 6: Rename & invert polarity of a flexbox frame-state-bit, for consistency with grid. r=mats This patch is just flipping some logic in a way that should produce the same outcome, so it shouldn't affect behavior. MozReview-Commit-ID: LM4HbJD3D9w
173a4f49dfe3db98a490a037db937cb06da5170d: Bug 812687 part 5: Adjust nsFlexContainerFrame to use CSSOrderAwareFrameIterator instead of reordering its child frame list. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 19:31:47 -0700 - rev 351545
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 812687 part 5: Adjust nsFlexContainerFrame to use CSSOrderAwareFrameIterator instead of reordering its child frame list. r=mats This patch shouldn't change our layout order or paint order for flex items (though it will change our behavior for the better when an abspos child is present, as discussed in bug 1345873). This patch *will* change the tab-index behavior of flex items. Previously, the default tab order would match the visual order (i.e. it would respect "order"), because it depends on the frame tree, and we sorted the frame tree by "order". Now, the tab-index will come from the DOM order (the unmodified frame tree), as the spec requires. MozReview-Commit-ID: 9OsqQX1sEn3
f6cc0dd3e7b8d90d0b1d29d5835a1bc4075211e4: Bug 812687 part 4: Add an optional parameter which can make CSSOrderAwareFrameIterator use the legacy "box-ordinal-group" property. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 19:31:47 -0700 - rev 351544
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 812687 part 4: Add an optional parameter which can make CSSOrderAwareFrameIterator use the legacy "box-ordinal-group" property. r=mats This patch just adds an optional codepath that isn't taken yet, so it shouldn't affect our behavior. (The next patch in the series will make use of this new codepath.) Note: the large code-comment that this patch adds is taken mostly-verbatim from some nsFlexContainerFrame.cpp code. (The original copy will be removed by the next patch in this series, when we switch to take advantage of this new mechanism.) MozReview-Commit-ID: 9pkJ346rrXg
947d5e737c2d05f038f01ddc2f02a01289db7ba8: Bug 812687 part 3: Move CSSOrderAwareFrameIterator code to its own .h/.cpp file. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 19:31:47 -0700 - rev 351543
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 812687 part 3: Move CSSOrderAwareFrameIterator code to its own .h/.cpp file. r=mats This patch just moves code, so it should not affect our behavior at all. MozReview-Commit-ID: 4yxSR5rWUV1
1732e9dd1f9e28ec85eecb1ae45730a3d36e2dd5: Bug 812687 part 2: Rename GridItemCSSOrderIterator to CSSOrderAwareFrameIterator (& similar for its Reverse form). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 19:31:47 -0700 - rev 351542
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 812687 part 2: Rename GridItemCSSOrderIterator to CSSOrderAwareFrameIterator (& similar for its Reverse form). r=mats This patch is purely type-renames, so it should not affect our behavior at all. MozReview-Commit-ID: 51zRGFyVDtT
5a6f0d546c631ada21d8109eccbb48b64b3be048: Bug 812687 part 1: Rename GridItemCSSOrderIteratorT to CSSOrderAwareFrameIteratorT, and drop "Grid" from its method names. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 19:31:47 -0700 - rev 351541
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 812687 part 1: Rename GridItemCSSOrderIteratorT to CSSOrderAwareFrameIteratorT, and drop "Grid" from its method names. r=mats This patch is purely type-renames & method-renames, so it should not affect our behavior at all. MozReview-Commit-ID: 5N7zru0uPfD
f5dbc3ffb11f850eeb23ab84037b1b6678130587: Backed out changeset 6933cdfb5186 (bug 1351910) for OSX bustage.
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 05 Apr 2017 21:26:47 -0400 - rev 351540
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Backed out changeset 6933cdfb5186 (bug 1351910) for OSX bustage.
6ccd3fd0f5e644e018d73f37c1bffc68a0cb7d2f: Bug 1353544 - Replace usage of PR_BEGIN_MACRO in xpcom. r=froydnj
Eric Rahm <erahm@mozilla.com> - Wed, 05 Apr 2017 18:06:44 -0700 - rev 351539
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 1353544 - Replace usage of PR_BEGIN_MACRO in xpcom. r=froydnj
6933cdfb51860d1d3ac693240593fd41756ff780: Bug 1351910 - Build more files as unified in ipc/glue. r=billm
Eric Rahm <erahm@mozilla.com> - Wed, 05 Apr 2017 18:01:45 -0700 - rev 351538
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 1351910 - Build more files as unified in ipc/glue. r=billm One file was excluded for using plarena which it did not. The other was excluded for "clashes with strdup," it does not use strdup. MozReview-Commit-ID: 5X5H9S4j903
a50a4f9e972bf614f48732975214709c003d1ac8: Bug 1322554: Interpose kernel32!BaseThreadInitThunk to add verification of thread start addresses; r=dmajor
Carl Corcoran <carlco@gmail.com> - Wed, 29 Mar 2017 17:07:37 +0200 - rev 351537
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 1322554: Interpose kernel32!BaseThreadInitThunk to add verification of thread start addresses; r=dmajor MozReview-Commit-ID: CvqZ3gXJyvo
5806128b981e017cd27872ec17ccd1246e2603ce: Bug 1291954 - Report added tsan failures, r=jseward
Steve Fink <sfink@mozilla.com> - Thu, 23 Feb 2017 19:36:33 -0800 - rev 351536
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 1291954 - Report added tsan failures, r=jseward
dccd52fb0a8d1fe62bfb0b6eefe6c8ea382f1a94: Bug 1291954 - Turn tsan into a canary, r=jseward
Steve Fink <sfink@mozilla.com> - Thu, 16 Feb 2017 14:43:45 -0800 - rev 351535
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 1291954 - Turn tsan into a canary, r=jseward
97001563a3b52662f4356684d33ffbd13e8c05ae: bug 1353246 adjust int/float comparison to treat floats just outside the range of int as outside r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 04 Apr 2017 16:10:26 +1200 - rev 351534
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
bug 1353246 adjust int/float comparison to treat floats just outside the range of int as outside r=padenot float(numeric_limits<int>::max()) can round up and so this inequality was false even when f was (float)0x80000000 (without rounding) and could not be represented by an int.
2dc4150c15c88a48a335d613fc88193866ff86b7: crashtest for bug 1274083 r=jesup
Karl Tomlinson <karlt+@karlt.net> - Tue, 04 Apr 2017 16:18:19 +1200 - rev 351533
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
crashtest for bug 1274083 r=jesup This needed some fine tuning to produce the crash, and so is a very specific test. It is still of value because this specific situation is not otherwise tested, and it provides input to fuzzers for potential similar situations.
383e9b30083441f9094fba161e62fcaec80bdcb1: Bug 1352926 - Make sure to check the right character for being semicolor or comma. r=farre
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 04 Apr 2017 16:24:46 -0400 - rev 351532
Push 40200 by cbook@mozilla.com at Thu, 06 Apr 2017 11:12:31 +0000
Bug 1352926 - Make sure to check the right character for being semicolor or comma. r=farre MozReview-Commit-ID: DOb1qYb8Tz4
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip