1cc3c2eee37ec2c9cd23d6327b8d8f6ca51dccf3: Bug 1574415 - Part 6: Use ScratchTagScope for CacheIRCompiler::emitGuardToInt32Index. r=jandem
André Bargull <andre.bargull@gmail.com> - Mon, 07 Oct 2019 11:57:54 +0000 - rev 496558
Push 97326 by archaeopteryx@coole-files.de at Mon, 07 Oct 2019 16:46:32 +0000
Bug 1574415 - Part 6: Use ScratchTagScope for CacheIRCompiler::emitGuardToInt32Index. r=jandem Similar to emitGuardToInt32ModUint32 and emitGuardToUint8Clamped, ScratchTagScope can be used in emitGuardToInt32Index to avoid splitting the tag two times. The next part will move this code into a shared helper function. Differential Revision: https://phabricator.services.mozilla.com/D47754
f3b48a00be455786162394ad78a8d044349af958: Bug 1574415 - Part 5: Avoid unnecessary move when source and temporary registers are equal. r=jandem
André Bargull <andre.bargull@gmail.com> - Mon, 07 Oct 2019 11:57:30 +0000 - rev 496557
Push 97326 by archaeopteryx@coole-files.de at Mon, 07 Oct 2019 16:46:32 +0000
Bug 1574415 - Part 5: Avoid unnecessary move when source and temporary registers are equal. r=jandem This avoids emitting `movapd %xmm0, %xmm0` for clamp-uint8 code. Differential Revision: https://phabricator.services.mozilla.com/D47753
ef1f7213e654816da44e0963a27adf1510e1ea03: Bug 1574415 - Part 4: Move emitGuardToInt32ModUint32 and emitGuardToUint8Clamped into CacheIRCompiler. r=jandem
André Bargull <andre.bargull@gmail.com> - Mon, 07 Oct 2019 11:57:10 +0000 - rev 496556
Push 97326 by archaeopteryx@coole-files.de at Mon, 07 Oct 2019 16:46:32 +0000
Bug 1574415 - Part 4: Move emitGuardToInt32ModUint32 and emitGuardToUint8Clamped into CacheIRCompiler. r=jandem IonCacheIRCompiler used `MacroAssembler::truncateConstantOrRegisterToInt32` resp. `clampConstantOrRegisterToUint8`, which allowed to handle more types than just int32 and double, but since `SetPropIRGenerator::tryAttachSetTypedElement` only allows number inputs, this code was probably never taken in practice. Therefore the CacheIRCompiler implementation for both methods only handles int32 and double inputs. As an optimisation to generate better assembly and to reduce register pressure, both methods have special-cases for known int32 inputs and are using `ScratchTagScope` to avoid splitting the tag two times. Part 7 will move the duplicated code into a shared helper function. Differential Revision: https://phabricator.services.mozilla.com/D47752
3f73e398ca61d24ddb9f8de379e1c077452ff9b1: Bug 1574415 - Part 3: Add AutoScratchFloatRegister. r=jandem
André Bargull <andre.bargull@gmail.com> - Mon, 07 Oct 2019 11:56:44 +0000 - rev 496555
Push 97326 by archaeopteryx@coole-files.de at Mon, 07 Oct 2019 16:46:32 +0000
Bug 1574415 - Part 3: Add AutoScratchFloatRegister. r=jandem Add a RAII class to spill and restore `Float0` when used as a scratch register when generating Ion CacheIR assembly. It's still possible to generate incorrect code which doesn't properly restore `Float0`, for example through jump instructions, but the RAII class should at least prevent bugs like in `CacheIRCompiler::emitLoadDoubleTruthyResult` where `Float0` wasn't restored for the truthy case. Differential Revision: https://phabricator.services.mozilla.com/D47751
6067d1828df8f7ca054c4a57430e466e1987aa75: Bug 1574415 - Part 2: Remove no longer used template argument and rename 'StoreToTypedArray'. r=jandem
André Bargull <andre.bargull@gmail.com> - Mon, 07 Oct 2019 11:56:29 +0000 - rev 496554
Push 97326 by archaeopteryx@coole-files.de at Mon, 07 Oct 2019 16:46:32 +0000
Bug 1574415 - Part 2: Remove no longer used template argument and rename 'StoreToTypedArray'. r=jandem `StoreToTypedArray` is now only used for TypedObjects and always passes `Address` for the `dest` argument. Differential Revision: https://phabricator.services.mozilla.com/D42811
d2008fdba4af17f45aad4d2ed3f99b21296fb248: Bug 1574415 - Part 1: Move argument conversion for StoreTypedElement to happen before range checks. r=jandem
André Bargull <andre.bargull@gmail.com> - Mon, 07 Oct 2019 11:56:27 +0000 - rev 496553
Push 97326 by archaeopteryx@coole-files.de at Mon, 07 Oct 2019 16:46:32 +0000
Bug 1574415 - Part 1: Move argument conversion for StoreTypedElement to happen before range checks. r=jandem This ensures CacheIR doesn't completely ignore out-of-bounds writes to TypedArray objects and also enables to use additional scratch registers for bounds-checking. Differential Revision: https://phabricator.services.mozilla.com/D42810
a0d28ade0bb377f5e99b1ac4b3b87edb535c96c2: Bug 1584548 - Fixes "modulus" item collapse and adds a test to check it.r=johannh
Carolina <carolina.jimenez.g@gmail.com> - Mon, 07 Oct 2019 15:28:24 +0000 - rev 496552
Push 97325 by archaeopteryx@coole-files.de at Mon, 07 Oct 2019 16:44:35 +0000
Bug 1584548 - Fixes "modulus" item collapse and adds a test to check it.r=johannh Differential Revision: https://phabricator.services.mozilla.com/D47487
54fa3474aca1c0674eba17bfeaa4f14536b9b20e: Bug 1562283 - FTP fuzzing target for the Necko fuzzing layer. r=michal
Christian Holler <choller@mozilla.com> - Mon, 07 Oct 2019 10:18:50 +0000 - rev 496551
Push 97324 by choller@mozilla.com at Mon, 07 Oct 2019 16:40:57 +0000
Bug 1562283 - FTP fuzzing target for the Necko fuzzing layer. r=michal Depends on D47448 Differential Revision: https://phabricator.services.mozilla.com/D47449
8d95f2c8867b13432cf2e0c51c7765e6592441ea: Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=nalexander
Ricky Stewart <rstewart@mozilla.com> - Mon, 07 Oct 2019 15:31:05 +0000 - rev 496550
Push 97323 by rstewart@mozilla.com at Mon, 07 Oct 2019 16:33:16 +0000
Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=nalexander This patch doesn't remove all references to GENERATED_FILES, but does remove most of them, leaving only those which can't be trivially translated to the new template. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a25230c3992b9c5519ceb351fb37f6b2bf605e Differential Revision: https://phabricator.services.mozilla.com/D48230
b739370f346d53aafce4709bb5ce8dc040edca2f: Backed out changeset c9b71d1747ea (bug 1552814) for assertion failures on nsBaseDragService.cpp CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Mon, 07 Oct 2019 19:02:02 +0300 - rev 496549
Push 97322 by btara@mozilla.com at Mon, 07 Oct 2019 16:09:20 +0000
Backed out changeset c9b71d1747ea (bug 1552814) for assertion failures on nsBaseDragService.cpp CLOSED TREE
b904c4625a368833405d576154ad60d0fd76ebc2: Bug 1580554 - AbuseReporter.openDialog should close and resolve as user cancelled a previous report dialog. r=mstriemer
Luca Greco <lgreco@mozilla.com> - Mon, 07 Oct 2019 16:03:20 +0000 - rev 496548
Push 97321 by luca.greco@alcacoop.it at Mon, 07 Oct 2019 16:04:38 +0000
Bug 1580554 - AbuseReporter.openDialog should close and resolve as user cancelled a previous report dialog. r=mstriemer Depends on D46019 Differential Revision: https://phabricator.services.mozilla.com/D46362
31e7850298c50fe028d814df0e647bf2bb7823ac: Bug 1580554 - Move common report test cases into head_abuse_report.js and run them on sub-frame and dialog mode. r=mstriemer
Luca Greco <lgreco@mozilla.com> - Mon, 07 Oct 2019 16:03:08 +0000 - rev 496547
Push 97321 by luca.greco@alcacoop.it at Mon, 07 Oct 2019 16:04:38 +0000
Bug 1580554 - Move common report test cases into head_abuse_report.js and run them on sub-frame and dialog mode. r=mstriemer Move test helpers and the common abuse report test cases (the ones that should run in sub-frame and dialog window mode) into an head_abuse_report.js support file, then run all the common test cases from browser_html_abuse_report.js (in sub-frame mode) and browser_html_abuse_report_dialog.js (in dialog window mode). Depends on D45571 Differential Revision: https://phabricator.services.mozilla.com/D46019
f155ba067300c8f553246750188e169457fcbd59: Bug 1580554 - Set a localized title on the abuse report dialog window. r=fluent-reviewers,flod,mstriemer
Luca Greco <lgreco@mozilla.com> - Mon, 07 Oct 2019 16:02:50 +0000 - rev 496546
Push 97321 by luca.greco@alcacoop.it at Mon, 07 Oct 2019 16:04:38 +0000
Bug 1580554 - Set a localized title on the abuse report dialog window. r=fluent-reviewers,flod,mstriemer Depends on D45570 Differential Revision: https://phabricator.services.mozilla.com/D45571
bd009ebbf5fce0f3852f20367db9ab0c66945e67: Bug 1580554 - Open abuse report panel in a separate dialog window. r=mstriemer
Luca Greco <lgreco@mozilla.com> - Mon, 07 Oct 2019 16:02:38 +0000 - rev 496545
Push 97321 by luca.greco@alcacoop.it at Mon, 07 Oct 2019 16:04:38 +0000
Bug 1580554 - Open abuse report panel in a separate dialog window. r=mstriemer Introduced a new "extensions.abuseReport.openDialog" pref: - when set to false (current default): the abuse report panel is opened as a subframe of the about:addons tab - when set to true: the abuse report panel is opened in its own dialog window Differential Revision: https://phabricator.services.mozilla.com/D45570
2e7ce1c4f3f01c2f5009313fcdf32d4e55adbae8: Bug 1583616 - Some numbers are searched and not autofilled. r=Standard8
Marco Bonardo <mbonardo@mozilla.com> - Mon, 07 Oct 2019 14:16:02 +0000 - rev 496544
Push 97320 by mak77@bonardo.net at Mon, 07 Oct 2019 16:02:44 +0000
Bug 1583616 - Some numbers are searched and not autofilled. r=Standard8 The tokenizer currently thinks large numbers are "broken" IPs, thus it says they can't be an origin. Unfortunately we use that same code path to identify possible origin prefixes, and origins can start with a number. Thus we end up searching rather than autofilling the origin. For now fix the heuristic for IPs, in the future we may evaluate splitting these code paths. Differential Revision: https://phabricator.services.mozilla.com/D48187
0139bcb25a7456d3f466d689204094a9823223ad: Bug 1586775 - Basic debugger code cleanup r=jlast
David Walsh <dwalsh@mozilla.com> - Mon, 07 Oct 2019 15:55:55 +0000 - rev 496543
Push 97319 by dwalsh@mozilla.com at Mon, 07 Oct 2019 16:01:01 +0000
Bug 1586775 - Basic debugger code cleanup r=jlast Differential Revision: https://phabricator.services.mozilla.com/D48244
b13503a2ce5f8a80a2e8046601c060d05777599b: Bug 1584545 - Clear the autofill placeholder if the first result is not an autofill one. r=Standard8
Marco Bonardo <mbonardo@mozilla.com> - Mon, 07 Oct 2019 14:43:31 +0000 - rev 496542
Push 97318 by mak77@bonardo.net at Mon, 07 Oct 2019 15:59:13 +0000
Bug 1584545 - Clear the autofill placeholder if the first result is not an autofill one. r=Standard8 Fixes a problem where the autofill placeholder is applied regardless of the first result. This is particularly critical for keywords and aliases. It also changes the title of keyword results without a search string, because currently it looks like they browse to the root of the host, but instead they visit the bookmark url. It's better to show the bookmark url so the user knows what will be visited. Differential Revision: https://phabricator.services.mozilla.com/D48111
c13a124f1515a6f13ef3dd2599b0d1d3623027f5: Bug 1586297 - Fix debugger's jest failures. r=jlast.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 07 Oct 2019 15:34:14 +0000 - rev 496541
Push 97317 by nchevobbe@mozilla.com at Mon, 07 Oct 2019 15:51:02 +0000
Bug 1586297 - Fix debugger's jest failures. r=jlast. Some tests were failing because we `require` an absolute path from the debugger source. We add a new entry in jest config's moduleNameMapper to reroute all the absolute require of devtools modules to the right path. To fix the failures we also need to add a fixture for `Services` as it's loaded in one of the fail we use in the debugger. We take this opportunity to fix debugger's try runner. Currently, we were only checking the `numFailedTests` property of the resulting JSON when running tests. But in some case, this property would still be 0, but other properties would indicate the some tests fail. In order to not have to go through all those properties, we simply check that the array of error messages we build is empty to assert if the tests were successfully ran. Differential Revision: https://phabricator.services.mozilla.com/D48295
0ff644ae9d66c24d49861f78a0be3061c87160f9: Bug 1584249 - Update enabled sync engines before opening CWTS dialog. r=markh
Edouard Oger <eoger@fastmail.com> - Mon, 07 Oct 2019 15:25:38 +0000 - rev 496540
Push 97316 by eoger@mozilla.com at Mon, 07 Oct 2019 15:26:23 +0000
Bug 1584249 - Update enabled sync engines before opening CWTS dialog. r=markh Differential Revision: https://phabricator.services.mozilla.com/D48272
59e1ccf2ff04a68d0718099ae3e5e13b5c0fe4c7: Backed out changeset 8001cd377d20 (bug 1586775) for ES lint failure on utils/editor/index.js CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Mon, 07 Oct 2019 18:17:25 +0300 - rev 496539
Push 97315 by btara@mozilla.com at Mon, 07 Oct 2019 15:18:16 +0000
Backed out changeset 8001cd377d20 (bug 1586775) for ES lint failure on utils/editor/index.js CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip