1a4aac2956cf01f4280b9179cb495ac66cdf84ea: bug 1382749 - remove the "old way" of signing add-ons r=aklotz,mossop
David Keeler <dkeeler@mozilla.com> - Wed, 19 Jul 2017 13:09:46 -0700 - rev 378054
Push 50170 by dkeeler@mozilla.com at Thu, 31 Aug 2017 21:18:10 +0000
bug 1382749 - remove the "old way" of signing add-ons r=aklotz,mossop In particular, this removes the nsIZipReader.getSigningCert API. MozReview-Commit-ID: JPSz0pvsA5n
58f4ecda0d4ad434241d7dbe30bcf60ce261d8f7: Bug 1394975 - Remove the tabbrowser-tabbox xbl binding;r=mossop
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 31 Aug 2017 09:31:36 -0700 - rev 378053
Push 50169 by bgrinstead@mozilla.com at Thu, 31 Aug 2017 20:52:06 +0000
Bug 1394975 - Remove the tabbrowser-tabbox xbl binding;r=mossop This is used to change the tabs property on the tabbox, which can be done on the tabbox binding directly by passing an attribute MozReview-Commit-ID: EViFT4O4ozl
8daf204f77fbf183e3660fd89e170f076967d245: Bug 1394935: Add a special case for marking something as dirty from invalidation code. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:26 +0200 - rev 378052
Push 50168 by ecoal95@gmail.com at Thu, 31 Aug 2017 20:39:34 +0000
Bug 1394935: Add a special case for marking something as dirty from invalidation code. r=bholley Not sure about the name, or whether making it a static or not (a static seemed slightly clearer, but nbd, feel free to bikeshed about it). MozReview-Commit-ID: FHGmcoprN2Q
c3f9a3e2ce9649289fd0e2e527e09206426f2730: Bug 1394935: Assert that if we find a common ancestor using the dirty bits, it is the actual common flattened tree ancestor. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:25 +0200 - rev 378051
Push 50168 by ecoal95@gmail.com at Thu, 31 Aug 2017 20:39:34 +0000
Bug 1394935: Assert that if we find a common ancestor using the dirty bits, it is the actual common flattened tree ancestor. r=bholley MozReview-Commit-ID: GRJ539QXS9e
3b1074717dac63fd1e2d2128f522c35ad9e59899: Bug 1394935: Fix a little typo in NoteDirtyElement. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:23 +0200 - rev 378050
Push 50168 by ecoal95@gmail.com at Thu, 31 Aug 2017 20:39:34 +0000
Bug 1394935: Fix a little typo in NoteDirtyElement. r=bholley MozReview-Commit-ID: LMQlNcJjz80
089cbcabf67aee48a15d86b7db992f15883b92b4: Bug 1394935: Assert that we don't call into NoteDirtyElement with extra bits on the restyle root's parent chain. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:22 +0200 - rev 378049
Push 50168 by ecoal95@gmail.com at Thu, 31 Aug 2017 20:39:34 +0000
Bug 1394935: Assert that we don't call into NoteDirtyElement with extra bits on the restyle root's parent chain. r=bholley MozReview-Commit-ID: Kt5aZSRBvlE
9fad64b68cbcad16f98e00cb026366bd40cc0bc9: Bug 1394935: Assert that the content we're marking dirty is under the restyle root. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:21 +0200 - rev 378048
Push 50168 by ecoal95@gmail.com at Thu, 31 Aug 2017 20:39:34 +0000
Bug 1394935: Assert that the content we're marking dirty is under the restyle root. r=bholley This would also have catched the bug earlier. MozReview-Commit-ID: 8uNXPnpXk6m
5ededad9baca82c9f00e2a2d0232d021a8c5890b: Bug 1394935: Add a (commented out for now) assertion about clobbering dirty bits. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:20 +0200 - rev 378047
Push 50168 by ecoal95@gmail.com at Thu, 31 Aug 2017 20:39:34 +0000
Bug 1394935: Add a (commented out for now) assertion about clobbering dirty bits. r=bholley Will get this fixed tomorrow, I have patches but forgot to push to try. MozReview-Commit-ID: 3Dcb1MTo8g5
88227ffe3c6eb33739cc7b54e46a30870be514d2: Bug 1394935: Assert that the new root is always higher up in the tree than the old root. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:19 +0200 - rev 378046
Push 50168 by ecoal95@gmail.com at Thu, 31 Aug 2017 20:39:34 +0000
Bug 1394935: Assert that the new root is always higher up in the tree than the old root. r=bholley The bug here is that we're clobbering a restyle root with another one which is down in the tree, when calling NoteDirtyElement on the document element with the flags already propagated. This assertion would've catched it earlier, and make it more obvious. MozReview-Commit-ID: 3mucQvr7A1x
f8c9e983f36cd636af4771e8df81f3d409fdde8a: Bug 1394935: Introduce nsContentUtils::CommonFlattenedTreeAncestorForStyle. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:24 +0200 - rev 378045
Push 50168 by ecoal95@gmail.com at Thu, 31 Aug 2017 20:39:34 +0000
Bug 1394935: Introduce nsContentUtils::CommonFlattenedTreeAncestorForStyle. r=bholley MozReview-Commit-ID: GThZUOIe30o
d4830b06540fbe4bfc15a3c408d8f40a4bd73546: Bug 1394935: Introduce ContentIsFlattenedTreeDescendantOfForStyle. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 19:42:06 +0200 - rev 378044
Push 50168 by ecoal95@gmail.com at Thu, 31 Aug 2017 20:39:34 +0000
Bug 1394935: Introduce ContentIsFlattenedTreeDescendantOfForStyle. r=bholley MozReview-Commit-ID: 69w9nnRJsIy
23e8ef26bb4066c71f78b107481426e12d05d79c: Bug 1394935: Return the document as the flattened tree parent of doc-level NAC. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 20:05:03 +0200 - rev 378043
Push 50168 by ecoal95@gmail.com at Thu, 31 Aug 2017 20:39:34 +0000
Bug 1394935: Return the document as the flattened tree parent of doc-level NAC. r=bholley MozReview-Commit-ID: 1m3BBU14MNe
a3689ab6e5be6b53c2c018c6e2ecac4646ad979e: Bug 1395398 - Send to Device notification shouldn't appear after clicking "Sign in" and other non-device menu items. r=jaws
Drew Willcoxon <adw@mozilla.com> - Thu, 31 Aug 2017 09:38:37 -0700 - rev 378042
Push 50167 by dwillcoxon@mozilla.com at Thu, 31 Aug 2017 20:37:57 +0000
Bug 1395398 - Send to Device notification shouldn't appear after clicking "Sign in" and other non-device menu items. r=jaws MozReview-Commit-ID: Gm35IfZCJPQ
9c13f2c5b9515e456a2a9abd1107affeb3709b93: Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 31 Aug 2017 10:45:38 -0700 - rev 378041
Push 50166 by dholbert@mozilla.com at Thu, 31 Aug 2017 20:36:35 +0000
Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r=jfkthame Some benchmarks & use-cases cause nsTextFrame::CharacterDataChanged to be called multiple times for the same text between reflows. Each call triggers a slightly-expensive call to shell->FrameNeedsReflow(), for each affected nsTextFrame in the continuation chain. (OK, it's not quite that bad -- we skip the FrameNeedsReflow calls for siblings, since the ancestor notifications/tweaks would all be the same.) This patch makes us set a flag on the nsTextFrame to indicate that a reflow has *already* been requested by this chunk of code, and we'll now use that to skip the FrameNeedsReflow() call (and the dirty-bit-setting for siblings) on the next invocation. And we clear this new flag when the pending reflow actually happens. This shouldn't change behavior in a web-observable way, but it should speed things up by removing redundant work. MozReview-Commit-ID: 5nmbZHEFFDi
007b471778c310660823bf7680e116a828bcb1e5: Bug 1393098 part 0: Refactor logic (add helper bool & reduce GetParent calls), in nsTextFrame::CharacterDataChanged. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 31 Aug 2017 10:45:36 -0700 - rev 378040
Push 50166 by dholbert@mozilla.com at Thu, 31 Aug 2017 20:36:35 +0000
Bug 1393098 part 0: Refactor logic (add helper bool & reduce GetParent calls), in nsTextFrame::CharacterDataChanged. r=jfkthame This patch doesn't affect behavior at all -- it just adjusts the logic slightly. Specifically, this patch: (a) Changes some code that currently tracks a frame, to now instead track that frame's parent, since we only ever call GetParent() on it anyway. (b) Drops a null-check that becomes unnecessary as a result of that change. (It was only there to protect us from calling GetParent() on a null pointer during the first loop iteration, and now that's not a risk since we're tracking the parent itself, and a null value will fail the equality comparison and do the right thing.) (c) Captures the "are ancestors already aware of a reflow request for my subtree" if-condition in a named boolean helper-variable. (d) Adds/improves documentation. MozReview-Commit-ID: 7dEflfiERYB
8ab1649365bb4e3cb484fb3bfc76364a1f800cd6: servo: Merge #18330 - stylo: Add a special case for marking something as dirty from invalidation code (from emilio:invalidation-stuff); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 14:14:15 -0500 - rev 378039
Push 50165 by servo-vcs-sync@mozilla.com at Thu, 31 Aug 2017 20:35:04 +0000
servo: Merge #18330 - stylo: Add a special case for marking something as dirty from invalidation code (from emilio:invalidation-stuff); r=bholley Source-Repo: https://github.com/servo/servo Source-Revision: 09df9c4316779899c7820cac56ecd18793f1f4a3
eff91b4e33156ebcb56b52eb22a87cf034cd8619: Bug 1395613 - import bundles from devtools-source-map 0.12.0; r=bgrins
Tom Tromey <tom@tromey.com> - Thu, 31 Aug 2017 11:44:56 -0600 - rev 378038
Push 50164 by ttromey@mozilla.com at Thu, 31 Aug 2017 20:21:29 +0000
Bug 1395613 - import bundles from devtools-source-map 0.12.0; r=bgrins MozReview-Commit-ID: n5XTA3YN3G
63b87e31320db96a4af189dfcd468f8134ae1ebd: Bug 1393274 - bustage: Add gravity=start where textAlignment to appease lint. r=mcomella
Michael Comella <michael.l.comella@gmail.com> - Thu, 31 Aug 2017 13:07:32 -0700 - rev 378037
Push 50163 by michael.l.comella@gmail.com at Thu, 31 Aug 2017 20:10:45 +0000
Bug 1393274 - bustage: Add gravity=start where textAlignment to appease lint. r=mcomella Lint passes locally. MozReview-Commit-ID: 8f6hBwjzoYJ
a1a1f209f8256e0a9742805d9d832e322b7e5b25: Bug 1393274: Correct webpage RTL padding/margins. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 13:27:20 -0700 - rev 378036
Push 50163 by michael.l.comella@gmail.com at Thu, 31 Aug 2017 20:10:45 +0000
Bug 1393274: Correct webpage RTL padding/margins. r=liuche Previously, I added a comment to explain why the explicit 0dp padding/margins are necessary for RTL but since it's required everywhere padding/margins are used, it's unsustainable and I chose not to do it here. MozReview-Commit-ID: H7H9xgeLy8b
2a39f7aa9629f1871d5ce205093419f1dcc73fa0: Bug 1393274: Align webpage item row text to right in RTL, left in LTR. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 13:24:46 -0700 - rev 378035
Push 50163 by michael.l.comella@gmail.com at Thu, 31 Aug 2017 20:10:45 +0000
Bug 1393274: Align webpage item row text to right in RTL, left in LTR. r=liuche MozReview-Commit-ID: 6VSF73V6Mda
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip