author Michael Hofmann <mh@ubhofmann.de>
Mon, 25 Jan 2021 09:29:42 +0000
changeset 564424 1edc48b99c803413e5057d6dacbe12d0d4dc246e
parent 502292 f7679d8469b66ed60ad902806b67ebfff4c58e5f
permissions -rw-r--r--
Bug 1684365 - Add a null pointer check so that Firefox won't crash when it can't initialize mRemoteServer r=stransky Firefox 84.0.1 crashes under Gentoo Linux if it is started in Wayland mode and if it was compiled WITH Wayland support and WITHOUT dbus support. I traced down the problem to line 172 of toolkit/components/remote/nsRemoteService.cpp: nsresult rv = mRemoteServer->Startup(mProgram.get(), mProfile.get()); mRemoteServer is NULL and Firefox crashes. This patch adds a NULL pointer check before that line. See: - Mozilla's Bugzilla, bug 1684365 - https://bugs.gentoo.org/762035 - https://forums.gentoo.org/viewtopic-t-1126235.html Differential Revision: https://phabricator.services.mozilla.com/D101536

/* vim:set ts=4 sw=2 et cindent: */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#ifndef nsHttpNegotiateAuth_h__
#define nsHttpNegotiateAuth_h__

#include "nsIHttpAuthenticator.h"
#include "nsIURI.h"
#include "mozilla/Attributes.h"
#include "mozilla/LazyIdleThread.h"
#include "mozilla/StaticPtr.h"

// The nsHttpNegotiateAuth class provides responses for the GSS-API Negotiate
// method as specified by Microsoft in draft-brezak-spnego-http-04.txt

class nsHttpNegotiateAuth final : public nsIHttpAuthenticator {

  static already_AddRefed<nsIHttpAuthenticator> GetOrCreate();

  ~nsHttpNegotiateAuth() {}

  // returns the value of the given boolean pref
  bool TestBoolPref(const char* pref);

  // tests if the host part of an uri is fully qualified
  bool TestNonFqdn(nsIURI* uri);

  // Singleton pointer
  static mozilla::StaticRefPtr<nsHttpNegotiateAuth> gSingleton;
#endif /* nsHttpNegotiateAuth_h__ */