testing: remove `venv` cache in testing Docker image (Bug 1598958) r=zeid
authorConnor Sheehan <sheehan@mozilla.com>
Fri, 15 May 2020 20:17:21 +0000
changeset 7552 9182861f3c888abb04a5dc52e705b8e058acf1e8
parent 7551 86e7f508187737d570b9e5465fcbbdd153be9fb2
child 7553 0611d5c901dda958acef9f645f9a34836d0009aa
push id3756
push usercosheehan@mozilla.com
push dateFri, 15 May 2020 20:18:52 +0000
treeherderversion-control-tools@9182861f3c88 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerszeid
bugs1598958
testing: remove `venv` cache in testing Docker image (Bug 1598958) r=zeid After landing the native Docker test image patches I attempted to rebuild the images to install Mercurial 5.4 instead of 5.4rc0. I noticed the old release candidate build persisted despite the updated version in the `install_mercurials` function. Since the image virtualenv is saved as a Docker volume in `docker-compose`, changes made after rebuilding are essentially ignored when re-running the tests. This commit removes the volume, since the virtualenv should be considered part of the Docker image itself, and not something that should persist between image rebuilds. Differential Revision: https://phabricator.services.mozilla.com/D75618
docker-compose.yml
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -44,17 +44,16 @@ services:
     command: ["/app/vct/run-tests", "--no-docker"]
     network_mode: "host"
     user: vct
     environment:
       - PYTHONUNBUFFERED=1
       - USER=vct
     volumes:
       - ./:/app/vct
-      - test_runner_venv_py2:/app/venv
       - test_runner_cache_py2:/app/vct/.cache
       - /var/run/docker.sock:/var/run/docker.sock
 
   test-runner:
     build:
       context: ./
       dockerfile: ./testing/docker/test-runner/Dockerfile
       args:
@@ -65,18 +64,15 @@ services:
     command: ["/app/vct/run-tests", "--no-docker"]
     network_mode: "host"
     user: vct
     environment:
       - PYTHONUNBUFFERED=1
       - USER=vct
     volumes:
       - ./:/app/vct
-      - test_runner_venv:/app/venv
       - test_runner_cache:/app/vct/.cache
       - /var/run/docker.sock:/var/run/docker.sock
 
 volumes:
-  test_runner_venv_py2:
-  test_runner_venv:
   test_runner_cache_py2:
   test_runner_cache: