searching for reviewer(gps)
c8beb8e1bbc42a7e5c44fe3cc73d3e0babeeb289: hgmo: return default manifest if there are no entries for a region r=gps
Connor Sheehan <sheehan@mozilla.com> - Fri, 07 Dec 2018 16:16:30 +0000 - rev 6782
Push 3370 by gszorc@mozilla.com at Fri, 07 Dec 2018 16:16:46 +0000
hgmo: return default manifest if there are no entries for a region r=gps When we resolve the AWS region for an IP address and that region has no manifest entries, we continue to iterate through the possible AWS IP blocks despite having already found the origin region. We should consider this a failure and return early instead. Differential Revision: https://phabricator.services.mozilla.com/D13955
c55c2fa5e5e4255e138bfbf577eece1f1d954c8c: mozext: remove critic (bug 1511439), r=gps
Axel Hecht <axel@pike.org> - Fri, 07 Dec 2018 15:46:01 +0000 - rev 6781
Push 3369 by gszorc@mozilla.com at Fri, 07 Dec 2018 15:46:17 +0000
mozext: remove critic (bug 1511439), r=gps critic is buggy (see bug 1508686 about passing wrong data in). Fixing the bugs seems to be a rabbit hole, so gps would rather remove it. Use ./mach lint instead. Differential Revision: https://phabricator.services.mozilla.com/D13673
994670fde7bdc7270f9e59d4bf469f350a16e849: terraform: add s3 module for various S3 buckets (Bug 1510795) r=gps
Connor Sheehan <sheehan@mozilla.com> - Thu, 06 Dec 2018 16:32:54 +0000 - rev 6775
Push 3364 by gszorc@mozilla.com at Thu, 06 Dec 2018 16:33:10 +0000
terraform: add s3 module for various S3 buckets (Bug 1510795) r=gps This commit adds an S3 module which configures buckets for various hg projects within different regions. As of now, we only create the clone/pull bundle packages in this module. In the near future we will add IAM policies to this module that allow storing wire protocol responses as well. We also create an associated logging bucket with the `log-delivery-write` ACL to log bucket events. Differential Revision: https://phabricator.services.mozilla.com/D13856
2713b7bee65fb06c4447427e0dfe43c70cf423ac: terraform: add root module files (Bug 1509039) r=gps
Connor Sheehan <sheehan@mozilla.com> - Wed, 05 Dec 2018 21:26:11 +0000 - rev 6772
Push 3361 by gszorc@mozilla.com at Wed, 05 Dec 2018 22:59:36 +0000
terraform: add root module files (Bug 1509039) r=gps This commit adds the files for the Terraform root module. When running Terraform commands from a directory, any `.tf` files in that directory are considered to be within the `root` module, and all other infrastructure should be contained within the root module. We add the necessary module files and configure a single `ci-only` module, assigned to the `us-west-2` AWS region. As we expand our infrastructure to new AWS regions or new cloud providers (GCP, etc), we will simply add new module entries to the root module (for example add a new `ci-only` module entry for the us-east-1 region). Differential Revision: https://phabricator.services.mozilla.com/D12920
5843de78b826d96858246610f05238d6e100246c: terraform: add the `ci-only` module (Bug 1509039) r=gps
Connor Sheehan <sheehan@mozilla.com> - Wed, 05 Dec 2018 21:26:03 +0000 - rev 6771
Push 3361 by gszorc@mozilla.com at Wed, 05 Dec 2018 22:59:36 +0000
terraform: add the `ci-only` module (Bug 1509039) r=gps This commit adds the `ci-only` module, which applies the config for a VPC containing all CI-only resources in a single AWS region. The module creates a VPC and attaches an internet gateway with an assigned elastic IP address. A route table is created with a rule to send all public subnet traffic to the internet gateway. We then create a public and private subnet for each AZ withing the region, assigning a /19 CIDR block to each. A bastion host is created within a public subnet in the VPC to facilitate SSH access to mirrors in the VPC (for both administrative access and Ansible deployments). Finally we create a security group and network ACls for the hosts and assign relevant security rules to each. Differential Revision: https://phabricator.services.mozilla.com/D12919
1ab302cec741aa8a496a554afd4d5013136a5bf4: terraform: add an `hgweb-mirror` module (Bug 1509039) r=gps
Connor Sheehan <sheehan@mozilla.com> - Wed, 05 Dec 2018 21:25:54 +0000 - rev 6770
Push 3361 by gszorc@mozilla.com at Wed, 05 Dec 2018 22:59:36 +0000
terraform: add an `hgweb-mirror` module (Bug 1509039) r=gps This commit adds an `hgweb-mirror` module to the Terraform configs. This module creates a single EC2 instance intended to be configured as an hgweb mirror. The new instance is created using the CentOS7 AMI and are intended to be assigned to a private subnet within a VPC. The instances use the c4.2xl instance type and are assigned to security groups via the `security_group_ids` variable. Differential Revision: https://phabricator.services.mozilla.com/D12918
c560e78724f1e5b22d4ca45e4ac99a2f0a2bd3b4: terraform: add a `bastion` module (Bug 1509039) r=gps
Connor Sheehan <sheehan@mozilla.com> - Wed, 05 Dec 2018 21:25:51 +0000 - rev 6769
Push 3361 by gszorc@mozilla.com at Wed, 05 Dec 2018 22:59:36 +0000
terraform: add a `bastion` module (Bug 1509039) r=gps This commit adds a `bastion` module for configuring bastion hosts within a VPC. The module currently only creates a single host using the Ubuntu 18.04 AMI. A security group is created which allows only SSH inbound traffic to the host, and an elastic IP address is assigned to the host. Differential Revision: https://phabricator.services.mozilla.com/D12917
51c9d896efb00837ad304ce6a50b620e10023eb8: terraform: add `pubsubnet` module (Bug 1509039) r=gps
Connor Sheehan <sheehan@mozilla.com> - Wed, 05 Dec 2018 21:25:48 +0000 - rev 6768
Push 3361 by gszorc@mozilla.com at Wed, 05 Dec 2018 22:59:36 +0000
terraform: add `pubsubnet` module (Bug 1509039) r=gps This commit adds a `pubsubnet` module to the Terraform configs. The module configures a public subnet within a specified VPC, and attaches a NAT gateway that can receive traffic from a private subnet (from the same AZ in practice). A route table is taken as input, which should include a rule that sends outbound traffic within the subnet (including traffic sent from a private subnet through the NAT gateway) to the internet gateway attached to the VPC. Differential Revision: https://phabricator.services.mozilla.com/D12916
5af7c52c365a60d3091c606b78366e0afdb0f1ac: terraform: create terraform directory with `privsubnet` module (Bug 1509039) r=gps
Connor Sheehan <sheehan@mozilla.com> - Wed, 05 Dec 2018 21:25:45 +0000 - rev 6767
Push 3361 by gszorc@mozilla.com at Wed, 05 Dec 2018 22:59:36 +0000
terraform: create terraform directory with `privsubnet` module (Bug 1509039) r=gps This commit creates a top-level `terraform` directory which will serve as the root module (with root module files to be added in a later commit) for all vcs-related Terraform configs going forward. Within this directory we add a `modules` subdirectory and populate it with the `privsubnet` module. This module configures a private subnet within a specified VPC, region and availability zone. The subnet creates a route table, which causes all outbound traffic from instances within the subnet to be routed to a specified NAT gateway (in practice this will be the NAT gateway of a public subnet in the same AZ). As this is the first addition of the "terraform" directory, and Terraform itself creates local state files, we add an entry to `.hgignore` to avoid tracking unnecessary files. Differential Revision: https://phabricator.services.mozilla.com/D12915
0a10bba61844f925f1b82b627423c607b2ad98b7: push-to-try: check for new `hg verify` output in tests (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Fri, 30 Nov 2018 00:27:07 +0000 - rev 6756
Push 3350 by gszorc@mozilla.com at Fri, 30 Nov 2018 00:27:15 +0000
push-to-try: check for new `hg verify` output in tests (Bug 1501686) r=gps `hg verify` has reformatted the summary text that displays at the end of the command. Updating the output makes tests pass under Mercurial 4.8. Differential Revision: https://phabricator.services.mozilla.com/D12757
fd98cbc165eab2e1cb20b50e82610fba428f5bb6: ansible/hg-web: add `gcc` to system packages (Bug 1511058) r=gps
Connor Sheehan <sheehan@mozilla.com> - Fri, 30 Nov 2018 00:23:42 +0000 - rev 6755
Push 3349 by gszorc@mozilla.com at Fri, 30 Nov 2018 00:23:54 +0000
ansible/hg-web: add `gcc` to system packages (Bug 1511058) r=gps This was removed in an previous commit as it was accompanied by a comment which implied it was only needed for hg-experimental. It is also needed to build Mercurial. Differential Revision: https://phabricator.services.mozilla.com/D13424
4746932b4cf6f045a2a9fe04de6b53da7748f6e7: mozext: use `makedate` from new module on modern Mercurial (Bug 1482325) r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 26 Nov 2018 17:11:24 +0000 - rev 6739
Push 3339 by gszorc@mozilla.com at Mon, 26 Nov 2018 17:12:41 +0000
mozext: use `makedate` from new module on modern Mercurial (Bug 1482325) r=gps The tests pass for mozext, but this failure was mentioned in the bug report for the bug. We must be missing some test coverage here. Differential Revision: https://phabricator.services.mozilla.com/D12725
8624be27fa494785d8294fe4fb336b38d0b6caa4: mozext: wrap relevant output in `template.hybridlist` (Bug 1482325) r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 26 Nov 2018 17:12:17 +0000 - rev 6738
Push 3339 by gszorc@mozilla.com at Mon, 26 Nov 2018 17:12:41 +0000
mozext: wrap relevant output in `template.hybridlist` (Bug 1482325) r=gps This commit makes mozext template keywords wrap output in `hybridlist` wrappers on modern versions of Mercurial. This also makes mozext tests pass under version 4.7, so we mark as compatible. Differential Revision: https://phabricator.services.mozilla.com/D12724
4c231b256afe9ddbf18083d713440673aa576a0b: extensions: introduce `wireprotocache` extension; r=gps
Connor Sheehan <sheehan@mozilla.com> - Thu, 15 Nov 2018 16:39:33 -0800 - rev 6732
Push 3333 by gszorc@mozilla.com at Fri, 16 Nov 2018 00:39:53 +0000
extensions: introduce `wireprotocache` extension; r=gps Mercurial 4.8 has been released and will soon be deployed to hg.mo. Once that happens, we will want to make changes to the web heads to leverage the new wire protocol and all it's crazy features. One of the key features of this new protocol is the ability to generically cache command responses by monkeypatching several key functions. Another is the ability to issue a content redirect response to clients, telling them the data they need can be found at some other locations. This commit introduces the `wireprotocache` extension. This extension provides a set of drop-in plugins (currently limited to S3) which implement cachers of various types for wire protocol responses. The only implemented plugin thus far is an S3 plugin. Servers add their AWS access key and key ID to an hgrc config, and specify the name of the S3 bucket which holds the objects. When a cache lookup request comes in, the cacher sends a HEAD request to S3 which will return a 404 if the object does not exist (ie a cache miss). If the request is a cache hit, a presigned url for the object is generated and used to issue a content redirect response which is sent to the client. If the response indicates a cache miss, the response is generated by the server and buffered in the cache until `onfinished` is called. During `onfinished`, we calculate the size of the response and can optionally avoid caching if the response is below a configured minimum threshold. Otherwise we insert the object into the cache bucket using the `put_object` API. To test the S3 plugin, we require the `moto` mock AWS library. Specifically, we use the "standalone server" functionality, which creates a Flask application that imitates S3. A new hghave predicate is added to check for this functionality before testing. Should we choose to switch cache providers in the future, (for example, GCP's blob store, Redis, memcached, etc) we will simply need to write the plugin and drop it into the extension directory. Differential Revision: https://phabricator.services.mozilla.com/D11109
b6afa72eb7014c25d4eaec9a26d1794737ad93bf: docs: replace MozReview with Phabricator in recommended workflow (Bug 1506530) r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 12 Nov 2018 18:55:51 +0000 - rev 6727
Push 3331 by gszorc@mozilla.com at Mon, 12 Nov 2018 18:56:02 +0000
docs: replace MozReview with Phabricator in recommended workflow (Bug 1506530) r=gps Differential Revision: https://phabricator.services.mozilla.com/D11649
d78e5c52a0228c3dc8ed03fe43bf749c8e68bd20: robustcheckout: reference `testedwith` in `supported_hg` assertion r=gps
Connor Sheehan <sheehan@mozilla.com> - Wed, 07 Nov 2018 18:49:04 +0000 - rev 6720
Push 3325 by gszorc@mozilla.com at Wed, 07 Nov 2018 18:49:16 +0000
robustcheckout: reference `testedwith` in `supported_hg` assertion r=gps Now we only need to update the supported Mercurial versions in a single location. Differential Revision: https://phabricator.services.mozilla.com/D11197
2725b127690efdb69ff34ab26a38e5cb0bbaf447: hgweb: use fastannotate from core Mercurial (Bug 1504794) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 06 Nov 2018 22:34:36 +0000 - rev 6714
Push 3320 by gszorc@mozilla.com at Tue, 06 Nov 2018 22:34:50 +0000
hgweb: use fastannotate from core Mercurial (Bug 1504794) r=gps `fastannotate` is now shipped with core Mercurial. We no longer need to pull down and build the hg-experimental repo as part of our deploy process. This commit purges hg-experimental from vct (with the exception of a few extensions recommended in the docs). We also flip the `server = True` flag to serve the annotate cache over the wire protocol. Differential Revision: https://phabricator.services.mozilla.com/D11124
a604d7375ed71457c10f76a25c76cb78f69b4a4c: testing: upgrade Python packages and Mercurial to 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 06 Nov 2018 03:26:13 +0000 - rev 6713
Push 3319 by gszorc@mozilla.com at Tue, 06 Nov 2018 21:55:57 +0000
testing: upgrade Python packages and Mercurial to 4.8 (Bug 1501686) r=gps Differential Revision: https://phabricator.services.mozilla.com/D10975
517d07ca95c860981e698d3ef862fed2c6118a72: hgssh: upgrade to Mercurial 4.8 in virtualenvs (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 06 Nov 2018 03:25:35 +0000 - rev 6712
Push 3319 by gszorc@mozilla.com at Tue, 06 Nov 2018 21:55:57 +0000
hgssh: upgrade to Mercurial 4.8 in virtualenvs (Bug 1501686) r=gps Differential Revision: https://phabricator.services.mozilla.com/D10974
d495609b21ef2a8f805cb26ac9f8728d7d4714a3: hgweb: upgrade to Mercurial 4.8 in virtualenvs (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 06 Nov 2018 03:24:31 +0000 - rev 6711
Push 3319 by gszorc@mozilla.com at Tue, 06 Nov 2018 21:55:57 +0000
hgweb: upgrade to Mercurial 4.8 in virtualenvs (Bug 1501686) r=gps Differential Revision: https://phabricator.services.mozilla.com/D10973
084a352be3be5bb9e23fc994efd80ca282ff46bf: templates: upgrade templates for Mercurial 4.8 compatibility (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 06 Nov 2018 03:24:03 +0000 - rev 6710
Push 3319 by gszorc@mozilla.com at Tue, 06 Nov 2018 21:55:57 +0000
templates: upgrade templates for Mercurial 4.8 compatibility (Bug 1501686) r=gps Following the process at `docs/hgmo/upgrading.rst`, this commit upgrades `gitweb_mozilla` for use with Mercurial 4.8. Differential Revision: https://phabricator.services.mozilla.com/D10972
3f850cc85162d426f0da2cc3c3dbaf986166098c: serverlog: update number of served bytes in test (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 06 Nov 2018 03:23:06 +0000 - rev 6707
Push 3316 by gszorc@mozilla.com at Tue, 06 Nov 2018 03:26:29 +0000
serverlog: update number of served bytes in test (Bug 1501686) r=gps I believe this is a side effect of some of the other changes landed today. Differential Revision: https://phabricator.services.mozilla.com/D10971
a93dc26bace63af59e93e583d98eecbdb3da9f0d: vcsreplicator: update output in `test-served-heads.t` (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 06 Nov 2018 03:22:52 +0000 - rev 6706
Push 3316 by gszorc@mozilla.com at Tue, 06 Nov 2018 03:26:29 +0000
vcsreplicator: update output in `test-served-heads.t` (Bug 1501686) r=gps Erroring via `raise ErrorResponse` now returns a JSON object instead of a raw string. Differential Revision: https://phabricator.services.mozilla.com/D10970
1c2dfc347631f4d543815a9b83139142cafca00b: hgserver: fix `test-clonebundles.t` test output in 4.8+ (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 05 Nov 2018 19:05:06 +0000 - rev 6689
Push 3311 by gszorc@mozilla.com at Mon, 05 Nov 2018 19:05:18 +0000
hgserver: fix `test-clonebundles.t` test output in 4.8+ (Bug 1501686) r=gps Several of the function line numbers in the clonebundles test have been updated under Mercurial 4.8, as well as a new layer on the call stack. This commit makes the line numbers generic using regular expressions and adds a conditional check for the extra function call under 4.8+. Differential Revision: https://phabricator.services.mozilla.com/D10939
6b67bef46badcbb90eab545e35f9134dfd24aea0: serverlog: use `req.apppath` instead of deprecated `env['REPO_NAME']` (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 05 Nov 2018 19:04:46 +0000 - rev 6688
Push 3311 by gszorc@mozilla.com at Mon, 05 Nov 2018 19:05:18 +0000
serverlog: use `req.apppath` instead of deprecated `env['REPO_NAME']` (Bug 1501686) r=gps `env.get('REPO_NAME')` now resolves to the full local repo path under Mercurial 4.8 (ie `mozilla-central` is now `/repo_local/mozilla/mozilla/mozilla-central`. Recent versions of Mercurial now support `req.apppath` which returns values similar to the old behaviour, so we switch to that value and updates tests accordingly. Differential Revision: https://phabricator.services.mozilla.com/D10938
d36fea6ba0b5ae373c75e562bc71ae7437d6930a: pushlog: fix test output difference between 4.8rc0 and 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 05 Nov 2018 19:03:13 +0000 - rev 6687
Push 3311 by gszorc@mozilla.com at Mon, 05 Nov 2018 19:05:18 +0000
pushlog: fix test output difference between 4.8rc0 and 4.8 (Bug 1501686) r=gps As with the previous commit, error output is now in a JSON object format instead of a raw string. Differential Revision: https://phabricator.services.mozilla.com/D10937
2ee5f7e7ca11c3cb0e1ac67777a8d952ebc7f3e9: hgmo: fix breakages between candidate and official 4.8 release (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 05 Nov 2018 19:03:00 +0000 - rev 6686
Push 3311 by gszorc@mozilla.com at Mon, 05 Nov 2018 19:05:18 +0000
hgmo: fix breakages between candidate and official 4.8 release (Bug 1501686) r=gps It seems there were a few breakages between 4.8rc0 and 4.8, mainly with regard to using the "error" template. The template now takes an string as the `error` kwarg, instead of a dict with a redundant `error` key in previous releases. Differential Revision: https://phabricator.services.mozilla.com/D10936
0b7651251a49dab87836055182187b4a2317ab4d: firefoxtree: enable compatibility with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 05 Nov 2018 18:11:16 +0000 - rev 6685
Push 3310 by gszorc@mozilla.com at Mon, 05 Nov 2018 18:11:26 +0000
firefoxtree: enable compatibility with Mercurial 4.8 (Bug 1501686) r=gps In versions above 4.8, the old-style template keyword definitions will be deprecated. This commit forces the `fxheads` template keyword to be dynamically defined with the new API in versions above 4.6, and with the old API for versions below 4.6. Doing so fixes a deprecation warning in tests on version 4.8 and makes us compatible with modern hg. Differential Revision: https://phabricator.services.mozilla.com/D10917
fb334ef4adbbe3cc7fa1c4d0fae3bc29c55fbd8c: firefoxtree: remove 4.3 compatibility code r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 05 Nov 2018 18:10:09 +0000 - rev 6684
Push 3310 by gszorc@mozilla.com at Mon, 05 Nov 2018 18:11:26 +0000
firefoxtree: remove 4.3 compatibility code r=gps Now that 4.8 is out, we support versions 4.4+. Differential Revision: https://phabricator.services.mozilla.com/D10916
00ccbed63e76757e89cfdbd03af39ae2fa0e6cc9: vcsreplicator: update test output and mark as 4.8 compatible (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 05 Nov 2018 18:08:59 +0000 - rev 6683
Push 3309 by gszorc@mozilla.com at Mon, 05 Nov 2018 18:09:32 +0000
vcsreplicator: update test output and mark as 4.8 compatible (Bug 1501686) r=gps vcsreplicator has some changed output in tests under Mercurial 4.8, with no other changes required for passing tests. Marking as 4.8 compatible. Differential Revision: https://phabricator.services.mozilla.com/D10408
b532527b7bf847a57e1c03e6b34bfe55671ec7c8: hgserver: update tests for 4.8 compatibility (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Wed, 31 Oct 2018 18:22:17 +0000 - rev 6572
Push 3294 by gszorc@mozilla.com at Wed, 31 Oct 2018 18:22:26 +0000
hgserver: update tests for 4.8 compatibility (Bug 1501686) r=gps The tests under `hgserver/` pass, with the exception of some extra output under 4.8. There is also a test which checks for `mozreview-ldap-associate` which is EOL and failing under 4.7 as well, this commit removes that section. `test-bookmarks-replication.t` is still intermittently failing due to a bookmark not showing up as replicated on the first call to the `json-bookmarks` webcommand - subsequent calls show it exists so I suspect there is a race condition there. Differential Revision: https://phabricator.services.mozilla.com/D10390
a7729414ad9687a8ec644bbb9d47a6d51bc41973: apache: set `X-Content-Type-Options` header on hg.mo r=gps
Connor Sheehan <sheehan@mozilla.com> - Wed, 31 Oct 2018 18:21:24 +0000 - rev 6571
Push 3293 by gszorc@mozilla.com at Wed, 31 Oct 2018 18:21:34 +0000
apache: set `X-Content-Type-Options` header on hg.mo r=gps Setting this header will force browsers to ignore any sniffed MIME type from the served content and respect the advertised type. Differential Revision: https://phabricator.services.mozilla.com/D7032
007ef7fac088bb26cc4b8b63be3974e8a66e17e8: pash: add `scm_versioncontrol` to ssh group membership check r=gps
Connor Sheehan <sheehan@mozilla.com> - Wed, 31 Oct 2018 18:20:55 +0000 - rev 6570
Push 3292 by gszorc@mozilla.com at Wed, 31 Oct 2018 18:21:06 +0000
pash: add `scm_versioncontrol` to ssh group membership check r=gps :jlund came into #vcs this week and requested a way to test if someone has push access to a repo. :kwierso mentioned the `ssh hg.mozilla.org` tool, but noted that it did not mention his ability to push to version control tools. This is likely due to the pash utility being fairly old and predating the scm_versioncontrol group. This commit adds scm_versioncontrol to the mapping of groups to repositories, so people with access to version control tools can verify using pash. Differential Revision: https://phabricator.services.mozilla.com/D9913
c928898cfb6825c7efc952f5a99d5fc3c15fa2b0: robustcheckout: remove incompatible versions marked as compatible r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 17:29:04 +0000 - rev 6541
Push 3280 by gszorc@mozilla.com at Tue, 30 Oct 2018 17:29:16 +0000
robustcheckout: remove incompatible versions marked as compatible r=gps The `supported_hg` check requires versions 4.3+, yet the `testedwith` and `minimumhgversion` strings reference versions as old as 3.7. Might as well make those accurate. Differential Revision: https://phabricator.services.mozilla.com/D10265
5817fed504a94217e27f8508f2fc60f6c81d8803: robustcheckout: enable compatibility with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 16:42:36 +0000 - rev 6540
Push 3279 by gszorc@mozilla.com at Tue, 30 Oct 2018 16:42:49 +0000
robustcheckout: enable compatibility with Mercurial 4.8 (Bug 1501686) r=gps `mercurial.sparse.parseconfig` now takes an extra `action` parameter which specifies which action is triggering the config read - either `narrow` or `sparse`. Adding the extra parameter under 4.8+ and specifying 4.8 compatibility in the `supported_hg` check makes us compatible with the newest version of hg. Differential Revision: https://phabricator.services.mozilla.com/D10246
4cb032c36ece1af68d93cb277742e0859c138cf1: hghooks: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 16:41:14 +0000 - rev 6539
Push 3278 by gszorc@mozilla.com at Tue, 30 Oct 2018 16:41:36 +0000
hghooks: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps No changes needed for passing tests under 4.8. Differential Revision: https://phabricator.services.mozilla.com/D10255
eba8a6936653ce13a8a2ae3c9e35662dbdc48479: hgmo: convert repo path to byte string (Bug 1503308) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 16:41:02 +0000 - rev 6538
Push 3278 by gszorc@mozilla.com at Tue, 30 Oct 2018 16:41:36 +0000
hgmo: convert repo path to byte string (Bug 1503308) r=gps Under Mercurial 4.8, the repo path passed to the `hg.repository` constructor must be string-like instead of unicode (the format the data is in while in the `data` dict). Converting to `bytes` aligns us with the conversions in this function and makes the hgmo extension compatible with Mercurial 4.8. Differential Revision: https://phabricator.services.mozilla.com/D10254
67f34c42ba3d7a961c2f894556902d86ca20bb22: hgmo: add no-op arguments to `allparents` call under 4.8 (Bug 1503308) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 16:37:05 +0000 - rev 6537
Push 3278 by gszorc@mozilla.com at Tue, 30 Oct 2018 16:41:36 +0000
hgmo: add no-op arguments to `allparents` call under 4.8 (Bug 1503308) r=gps In the previous commit we removed the 4.6 version of this function, and in this commit we add the 4.8 version. The new signature takes `context` and `mapping` to align with other templatekeywords, however neither are used as the function will take `ctx` from the closure instead. We pass `None` as both arguments and function executes as expected. Differential Revision: https://phabricator.services.mozilla.com/D10253
729096878cc2bf9ed4eeb30c42d070c9b0f7eb7a: hgmo: remove compatibility with Mercurial 4.6 (Bug 1503308) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 16:36:31 +0000 - rev 6536
Push 3278 by gszorc@mozilla.com at Tue, 30 Oct 2018 16:41:36 +0000
hgmo: remove compatibility with Mercurial 4.6 (Bug 1503308) r=gps This function call changed between 4.6-4.7, and also changed between 4.7-4.8. Rather than have an ever-increasing number of method signatures to call, let's just remove the obsolete 4.6 version. Differential Revision: https://phabricator.services.mozilla.com/D10252
58129ace07318e71827d068c29a2ac5aa4cf5423: manualoverlay: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 16:36:22 +0000 - rev 6535
Push 3278 by gszorc@mozilla.com at Tue, 30 Oct 2018 16:41:36 +0000
manualoverlay: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps No changes needed for passing tests. Removed a few unused imports as well. Differential Revision: https://phabricator.services.mozilla.com/D10247
b71997b03107fb9321897ed132081bab80ad9b3c: serverlog: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 00:41:20 +0000 - rev 6534
Push 3277 by gszorc@mozilla.com at Tue, 30 Oct 2018 00:41:49 +0000
serverlog: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps This commit removes the Mercurial 4.6 output from the serverlog tests and adds output from version 4.8. There is still a `TRACKING` flag related to the potential unification of SSH and HTTP log events - since the extension works under 4.8 that code is left as-is until we find time to implement that change. Differential Revision: https://phabricator.services.mozilla.com/D10108
0da7107ba5ffb0b24259f960d79c325f0a2fe0af: readonly: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 00:41:19 +0000 - rev 6533
Push 3277 by gszorc@mozilla.com at Tue, 30 Oct 2018 00:41:49 +0000
readonly: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps No changes required for passing tests. Differential Revision: https://phabricator.services.mozilla.com/D10107
85754c3b811dc0ec850f1ca5a38e364a1a29eeee: obsolescencehacks: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 00:41:17 +0000 - rev 6532
Push 3277 by gszorc@mozilla.com at Tue, 30 Oct 2018 00:41:49 +0000
obsolescencehacks: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps No changes required to get tests passing here. Differential Revision: https://phabricator.services.mozilla.com/D10106
3a7297e04758c6d7b487bd925c04d7decfd37286: overlay: make compatible with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 00:40:22 +0000 - rev 6531
Push 3277 by gszorc@mozilla.com at Tue, 30 Oct 2018 00:41:49 +0000
overlay: make compatible with Mercurial 4.8 (Bug 1501686) r=gps Importing `parsemeta` from it's new location in `storageutil` makes this extension compatible with 4.8. Differential Revision: https://phabricator.services.mozilla.com/D10105
8cdc436e379d0a6e2531795e9aaede1a1f00a21b: overlay: remove pre-4.7 compatibility code (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 00:39:39 +0000 - rev 6530
Push 3277 by gszorc@mozilla.com at Tue, 30 Oct 2018 00:41:49 +0000
overlay: remove pre-4.7 compatibility code (Bug 1501686) r=gps The current version of overlay supports Mercurial as far back as 4.1. We only need compatibility with our currently deployed version, 4.7. Differential Revision: https://phabricator.services.mozilla.com/D10104
6194efe47503e3583927382bc11cd43002807000: pushlog: remove Mercurial 4.6 compatibility code (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 00:38:55 +0000 - rev 6529
Push 3277 by gszorc@mozilla.com at Tue, 30 Oct 2018 00:41:49 +0000
pushlog: remove Mercurial 4.6 compatibility code (Bug 1501686) r=gps Since we are on 4.7 by the time this commit lands, and will be moving to 4.8 shortly, we can get rid of this code for simplicity's sake. Differential Revision: https://phabricator.services.mozilla.com/D10068
b586c69675b92567153bb622bbfcf84d8bf9f6a8: pushlog: enable compatibility with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Mon, 29 Oct 2018 19:26:47 +0000 - rev 6528
Push 3277 by gszorc@mozilla.com at Tue, 30 Oct 2018 00:41:49 +0000
pushlog: enable compatibility with Mercurial 4.8 (Bug 1501686) r=gps This commit makes pushlog tests pass under Mercurial 4.8rc0. The only code change required is calling `report` as a private method under Mercurial 4.8, as not doing so causes the rollback to fail without explanation why. The other changes are related to differing test output in the new version, notably a fixed bug that caused phase data to not be transferred during a stream clone has been changed - the test for that behaviour in `test-pull-obsolete.t` is put under a 4.8 conditional. Differential Revision: https://phabricator.services.mozilla.com/D10067
d67ed0f56a696c54856cafe1c8e7eb7ad08a1161: replicateowner: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 00:37:36 +0000 - rev 6527
Push 3277 by gszorc@mozilla.com at Tue, 30 Oct 2018 00:41:49 +0000
replicateowner: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps No changes required for passing tests. Differential Revision: https://phabricator.services.mozilla.com/D10066
ba497509ac79d6023f974294529abaec73f92212: unifyrepo: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 00:37:18 +0000 - rev 6526
Push 3277 by gszorc@mozilla.com at Tue, 30 Oct 2018 00:41:49 +0000
unifyrepo: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps Extension passes tests without any required changes. Differential Revision: https://phabricator.services.mozilla.com/D10065
a127d3f78633b9798232aeebb185c9fa1de9a2cb: firefoxreleases: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps
Connor Sheehan <sheehan@mozilla.com> - Tue, 30 Oct 2018 00:37:10 +0000 - rev 6525
Push 3277 by gszorc@mozilla.com at Tue, 30 Oct 2018 00:41:49 +0000
firefoxreleases: mark as compatible with Mercurial 4.8 (Bug 1501686) r=gps No changes required for tests to pass. Differential Revision: https://phabricator.services.mozilla.com/D9942