Backed out changeset a41cffeea0d9 (bug 1513110); rs=backout
authorGeoff Lankow <geoff@darktrojan.net>
Tue, 11 Dec 2018 21:38:07 +1300
changeset 25367 fa11fa3237109466511798ad6fc80aac517981c0
parent 25366 a41cffeea0d91ffd1411ae09f75ab3d949352bed
child 25368 713a7a7a6cdb2552020fb9fca9e88da4e752ce41
push id15219
push usergeoff@darktrojan.net
push dateTue, 11 Dec 2018 08:39:12 +0000
treeherdercomm-central@713a7a7a6cdb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1513110
backs outa41cffeea0d91ffd1411ae09f75ab3d949352bed
Backed out changeset a41cffeea0d9 (bug 1513110); rs=backout
mail/test/mozmill/attachment/test-attachment-events.js
mail/test/mozmill/attachment/test-attachment.js
mail/test/mozmill/cloudfile/test-cloudfile-notifications.js
mail/test/mozmill/composition/test-attachment.js
--- a/mail/test/mozmill/attachment/test-attachment-events.js
+++ b/mail/test/mozmill/attachment/test-attachment-events.js
@@ -203,17 +203,16 @@ function test_attachments_removed_on_sin
   assert_true(subjects instanceof Ci.nsIMutableArray);
   assert_equals(1, subjects.length);
   assert_equals(subjects.queryElementAt(0, Ci.nsIMsgAttachment).url,
                 "http://www.example.com/2");
 
   cw.e("attachmentBucket").removeEventListener(kAttachmentsRemoved, listener);
   close_compose_window(cw);
 }
-test_attachments_removed_on_multiple.__force_skip__ = true;
 
 /**
  * Test that the attachments-removed event is fired when removing multiple
  * files all at once.
  */
 function test_attachments_removed_on_multiple() {
   // Prepare to listen for attachments-removed
   let eventCount = 0;
--- a/mail/test/mozmill/attachment/test-attachment.js
+++ b/mail/test/mozmill/attachment/test-attachment.js
@@ -386,17 +386,16 @@ function test_selected_attachments_are_c
   select_click_row(2);
 
   // Expand the attachment list again.
   mc.click(mc.eid("attachmentToggle"));
 
   assert_equals(attachmentList.selectedItems.length, 1,
                 "After loading a new message the first item should be selected");
 }
-test_selected_attachments_are_cleared.__force_skip__ = true;
 
 function test_attachment_toolbar_customize() {
   // This tests that removing the "save all" button from the attachment bar
   // works correctly (i.e. it doesn't throw an error in the middle of processing
   // the attachments when loading a later message).
   be_in_folder(folder);
 
   // First, select the message with one attachment.
@@ -434,17 +433,16 @@ function test_select_all_attachments_key
   // Expand the attachment list.
   mc.click(mc.eid("attachmentToggle"));
 
   let attachmentList = mc.e("attachmentList");
   mc.keypress(new elib.Elem(attachmentList), "a", {accelKey: true});
   assert_equals(attachmentList.selectedItems.length, 2,
                 "Should have selected all attachments!");
 }
-test_select_all_attachments_key.__force_skip__ = true;
 
 function test_delete_attachment_key() {
   be_in_folder(folder);
 
   // First, select the message with two attachments.
   select_none();
   select_click_row(3);
 
@@ -532,17 +530,16 @@ function test_attachments_compose_menu()
 
   // Focus back to the attachmentBucket
   force_focus("attachmentBucket");
   assert_equals("Remove Attachments", cwc.e("cmd_delete").getAttribute("label"),
                 "Multiple attachments are selected!");
 
   close_compose_window(cwc);
 }
-test_attachments_compose_menu.__force_skip__ = true;
 
 function test_delete_from_toolbar() {
   be_in_folder(folder);
 
   // First, select the message with two attachments.
   select_none();
   select_click_row(3);
 
--- a/mail/test/mozmill/cloudfile/test-cloudfile-notifications.js
+++ b/mail/test/mozmill/cloudfile/test-cloudfile-notifications.js
@@ -333,17 +333,16 @@ function test_offer_then_upload_notifica
   // And the upload notification should be displayed.
   assert_upload_notification_displayed(cw, true);
 
   close_compose_window(cw);
 
   // Now put the old threshold back.
   Services.prefs.setIntPref(kOfferThreshold, maxSize);
 }
-test_offer_then_upload_notifications.__force_skip__ = true;
 
 /**
  * Test that when we first upload some files, we get the privacy warning
  * message. We should only get this the first time.
  */
 function test_privacy_warning_notification() {
   gMockPromptService.register();
   gMockPromptService.returnValue = false;
--- a/mail/test/mozmill/composition/test-attachment.js
+++ b/mail/test/mozmill/composition/test-attachment.js
@@ -202,17 +202,16 @@ function test_delete_attachments() {
     check_attachment_size(cwc, i, files[i].size);
   }
 
   delete_attachment(cwc, 0);
   check_total_attachment_size(cwc, files.length-1);
 
   close_compose_window(cwc);
 }
-test_delete_attachments.__force_skip__ = true;
 
 function subtest_rename_attachment(cwc) {
   cwc.e("loginTextbox").value = "renamed.txt";
   cwc.window.document.documentElement.getButton('accept').doCommand();
 }
 
 function test_rename_attachment() {
   let cwc = open_compose_new_mail();
@@ -232,17 +231,16 @@ function test_rename_attachment() {
 
   assert_equals(node.getAttribute("name"), "renamed.txt");
 
   check_attachment_size(cwc, 0, size);
   check_total_attachment_size(cwc, 1);
 
   close_compose_window(cwc);
 }
-test_rename_attachment.__force_skip__ = true;
 
 function subtest_open_attachment(cwc) {
   cwc.window.document.documentElement.getButton("cancel").doCommand();
 }
 
 function test_open_attachment() {
   let cwc = open_compose_new_mail();
 
@@ -260,17 +258,16 @@ function test_open_attachment() {
   let bucket = cwc.e("attachmentBucket");
   let node = bucket.querySelector("attachmentitem");
   plan_for_modal_dialog("unknownContentType", subtest_open_attachment);
   cwc.doubleClick(new elib.Elem(node));
   wait_for_modal_dialog("unknownContentType");
 
   close_compose_window(cwc);
 }
-test_open_attachment.__force_skip__ = true;
 
 function test_forward_raw_attachment() {
   be_in_folder(folder);
   let curMessage = select_click_row(1);
 
   let cwc = open_compose_with_forward();
   check_attachment_size(cwc, 0, rawAttachment.length);
   check_total_attachment_size(cwc, 1);