Bug 1573965 - Remove obsolete comment about getMX function. r=mkmelin DONTBUILD
authorPaul Morris <paul@thunderbird.net>
Fri, 16 Aug 2019 10:13:09 +0200
changeset 27334 bcec15e3ffc706863b957ff620808aa371096126
parent 27333 a117aceeecb22da9f2d0b27f8a53b93ffecee817
child 27335 c25118b0881df17f9c6b760e6a0c02b988d07343
push id16289
push usermozilla@jorgk.com
push dateFri, 16 Aug 2019 08:13:41 +0000
treeherdercomm-central@bcec15e3ffc7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmkmelin
bugs1573965, 1573564
Bug 1573965 - Remove obsolete comment about getMX function. r=mkmelin DONTBUILD A follow-up on bug 1573564.
mail/components/accountcreation/content/fetchConfig.js
--- a/mail/components/accountcreation/content/fetchConfig.js
+++ b/mail/components/accountcreation/content/fetchConfig.js
@@ -172,21 +172,16 @@ function fetchConfigForMX(domain, succes
 
 /**
  * Queries the DNS MX records for a given domain. Calls `successCallback` with
  * the hostname of the MX server. If there are several entries with different
  * preference values, only the most preferred (i.e. has the lowest value)
  * is used. If there are several most preferred servers (i.e. round robin),
  * only one of them is used.
  *
- * The promise-based async call to `DNS.mx` (imported from DNS.jsm) is at odds
- * with the other code here that works with callbacks and `Abortable` objects.
- * That makes the code less coherent, but otherwise it just means we can't
- * abort the initial MX query.
- *
  * @param {string}  sanitizedDomain @see fetchConfigFromISP()
  * @param {function(hostname {string})}  successCallback
  *   Called when we found an MX for the domain.
  *   For |hostname|, see description above.
  * @param {function({Exception|string})}  errorCallback @see fetchConfigFromISP()
  */
 function getMX(sanitizedDomain, successCallback, errorCallback) {
   return new PromiseAbortable(DNS.mx(sanitizedDomain), function(records) {