Bug 1428082 - do not bubble up command execution in appmenu_addonPrefs popup. r=jorgk
authoraceman <acelists@atlas.sk>
Wed, 07 Feb 2018 09:24:00 +0100
changeset 23269 a0716b4dadb52f9aaf818a71bdfa5bd8e88eca72
parent 23268 e1013e31ffaeea1733b1b3e5b728b6f1e84a022d
child 23270 3d13a7832ad7d5a2e98ce4af0416b1101d61ff2c
push id14064
push usermozilla@jorgk.com
push dateWed, 07 Feb 2018 23:39:28 +0000
treeherdercomm-central@f842916b9211 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorgk
bugs1428082
Bug 1428082 - do not bubble up command execution in appmenu_addonPrefs popup. r=jorgk
mail/base/content/mailWindowOverlay.xul
--- a/mail/base/content/mailWindowOverlay.xul
+++ b/mail/base/content/mailWindowOverlay.xul
@@ -1350,17 +1350,17 @@
         <spacer class="appmenuPane-spacer"/>
         <splitmenu id="appmenu_addons"
                    class="menuitem-iconic"
                    label="&addons.label;"
                    oncommand="openAddonsMgr();">
           <menupopup id="appmenu_addonPrefs"
                      onpopupshowing="initAddonPrefsMenu(this);"
                      oncommand="openAddonPrefs(event.target.value, event.target.getAttribute('optionsType'));">
-            <menuitem label="&addons.label;" oncommand="openAddonsMgr();"/>
+            <menuitem label="&addons.label;" oncommand="openAddonsMgr(); event.stopPropagation();"/>
             <menuseparator class="appmenu-menuseparator"/>
             <menuitem label="&addonNoPrefs.label;" disabled="true"/>
           </menupopup>
         </splitmenu>
         <splitmenu id="appmenu_customize"
 #ifdef XP_WIN
                    label="&preferencesCmd2.label;"
 #else