Bug 500004 - drag of message from Search Messages fails with error "GetSelectedMessages is not defined". Call ThreadPaneOnDragStart instead of BeginDragThreadPane. r=mkmelin, a=blocking-tb3b4+
authorSiddharth Agarwal <sid.bugzilla@gmail.com>
Wed, 09 Sep 2009 03:12:27 +0530
changeset 3598 9b7f6edb75fa33f6ebdb8bbddca9251126fc6a26
parent 3597 6f106bd796ae3139d61ba3001cf1853f46084257
child 3599 a98db41b5ca737b647d2a7964cb7d6bffee04fa6
child 3710 668c342deb663372479da9e47656295941ae6815
push id2914
push usersid.bugzilla@gmail.com
push dateTue, 08 Sep 2009 21:43:10 +0000
treeherdercomm-central@9b7f6edb75fa [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmkmelin, blocking-tb3b4
bugs500004
Bug 500004 - drag of message from Search Messages fails with error "GetSelectedMessages is not defined". Call ThreadPaneOnDragStart instead of BeginDragThreadPane. r=mkmelin, a=blocking-tb3b4+
mail/base/content/SearchDialog.js
mail/base/content/SearchDialog.xul
--- a/mail/base/content/SearchDialog.js
+++ b/mail/base/content/SearchDialog.js
@@ -639,22 +639,16 @@ function MoveMessageInSearch(destFolder)
   }
 }
 
 function GoToFolder()
 {
   MsgOpenNewWindowForFolder(gFolderDisplay.selectedMessage);
 }
 
-function BeginDragThreadPane(event)
-{
-    // no search pane dnd yet
-    return false;
-}
-
 function saveAsVirtualFolder()
 {
   var searchFolderURIs = window.arguments[0].folder.URI;
 
   var searchSubfolders = document.getElementById("checkSearchSubFolders").checked;
   if (gCurrentFolder && (searchSubfolders || gCurrentFolder.isServer || gCurrentFolder.noSelect))
   {
     var subFolderURIs = AddSubFoldersToURI(gCurrentFolder);
--- a/mail/base/content/SearchDialog.xul
+++ b/mail/base/content/SearchDialog.xul
@@ -62,17 +62,16 @@
   <script type="application/x-javascript" src="chrome://messenger/content/messageDisplay.js"/>
   <script type="application/x-javascript" src="chrome://messenger/content/threadPane.js"/>
   <script type="application/x-javascript" src="chrome://messenger/content/msgMail3PaneWindow.js"/>
   <script type="application/x-javascript" src="chrome://global/content/globalOverlay.js"/>
   <script type="application/x-javascript" src="chrome://messenger/content/mailCommands.js"/>
   <script type="application/x-javascript" src="chrome://messenger/content/mailWindowOverlay.js"/>
   <script type="application/x-javascript" src="chrome://messenger/content/commandglue.js"/>
   <script type="application/x-javascript" src="chrome://messenger/content/SearchDialog.js"/>
-  <script type="application/x-javascript" src="chrome://messenger/content/messengerdnd.js"/>
 
   <!-- We need this for a SetFolderPicker call, until we de-rdfify this file -->
   <script type="application/x-javascript" src="chrome://messenger/content/msgFolderPickerOverlay.js"/>
   <script type="application/x-javascript" src="chrome://messenger/content/widgetglue.js"/>
 
   <commands id="commands">
     <commandset id="mailSearchItems"
                 commandupdater="true"
@@ -196,17 +195,17 @@
                      label="&totalColumn.label;" tooltiptext="&totalColumn.tooltip;"/>
             <splitter class="tree-splitter"/>
             <treecol id="locationCol" persist="width" flex="1" hidden="true" ignoreincolumnpicker="true"
                      label="&locationColumn.label;" tooltiptext="&locationColumn.tooltip;"/>
             <splitter class="tree-splitter"/>
             <treecol id="idCol" persist="hidden ordinal width" flex="1" hidden="true"
                      label="&idColumn.label;" tooltiptext="&idColumn.tooltip;"/>
           </treecols>
-          <treechildren ondraggesture="BeginDragThreadPane(event);"/>
+          <treechildren ondraggesture="ThreadPaneOnDragStart(event);"/>
         </tree>
       </vbox>
       <hbox align="start"> 
         <button label="&openButton.label;" id="openButton" command="cmd_open" accesskey="&openButton.accesskey;"/>
         <button id="fileMessageButton" type="menu" label="&fileButton.label;"
                 accesskey="&fileButton.accesskey;"
                 observes="file_message_button"
                 oncommand="MoveMessageInSearch(event.target)">