Bug 1358444 - port bug 1356843 to mailnews: Fix clang's -Wcomma warnings. rs=bustage-fix DONTBUILD
authorJorg K <jorgk@jorgk.com>
Fri, 21 Apr 2017 12:36:52 +0200
changeset 21446 9978596cc5d566044597c5a13e0c7801523296ac
parent 21445 e2beacaab75ad46459484a89d2d0ae479db18f52
child 21447 9a8875e3bff1e9f6cd2ba8e1745d722addce4de2
push id13055
push usermozilla@jorgk.com
push dateFri, 21 Apr 2017 10:37:40 +0000
treeherdercomm-central@9978596cc5d5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage-fix
bugs1358444, 1356843
Bug 1358444 - port bug 1356843 to mailnews: Fix clang's -Wcomma warnings. rs=bustage-fix DONTBUILD
mailnews/local/src/nsParseMailbox.cpp
--- a/mailnews/local/src/nsParseMailbox.cpp
+++ b/mailnews/local/src/nsParseMailbox.cpp
@@ -1374,18 +1374,20 @@ nsresult nsParseMailMessageState::Finali
 
   if (!(flags & nsMsgMessageFlags::Expunged))  // message was deleted, don't bother creating a hdr.
   {
     // We'll need the message id first to recover data from the backup database
     nsAutoCString rawMsgId;
     /* Take off <> around message ID. */
     if (id)
     {
-      if (id->length > 0 && id->value[0] == '<')
-        id->length--, id->value++;
+      if (id->length > 0 && id->value[0] == '<') {
+        id->length--;
+        id->value++;
+      }
 
       NS_WARNING_ASSERTION(id->length > 0, "id->length failure in FinalizeHeaders().");
 
       if (id->length > 0 && id->value[id->length - 1] == '>')
         /* generate a new null-terminated string without the final > */
         rawMsgId.Assign(id->value, id->length - 1);
       else
         rawMsgId.Assign(id->value);