Bug 1509194 - Fix calendar view selection radios styling; rs=me DONTBUILD
authorGeoff Lankow <geoff@darktrojan.net>
Thu, 22 Nov 2018 22:44:14 +1300
changeset 25248 95cd4e14ec48ff68aca70ab67ef2e74b0a124b44
parent 25247 781b3615a3ed77074a585e3910a6bb01a592b000
child 25249 997a4690702341b8abdf046eb56f2ee03ade135d
push id15154
push usergeoff@darktrojan.net
push dateThu, 22 Nov 2018 09:44:51 +0000
treeherdercomm-central@95cd4e14ec48 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1509194
Bug 1509194 - Fix calendar view selection radios styling; rs=me DONTBUILD
calendar/base/content/calendar-views.xul
calendar/base/themes/common/calendar-views.css
--- a/calendar/base/content/calendar-views.xul
+++ b/calendar/base/content/calendar-views.xul
@@ -57,44 +57,43 @@
                   <spacer flex="1"/>
                   <label id="calendarWeek"
                          class="view-header"
                          type="end"
                          crop="start"/>
                </hbox>
             <hbox flex="1" class="navigation-bottombox"/>
          </vbox>
-         <hbox id="view-tabbox" pack="end">
+         <vbox id="view-tabbox" pack="end">
             <radiogroup id="view-tabs"
-                   class="calview-tabs"
-                   orient="horizontal"
-                   setfocus="true">
+                        class="calview-tabs"
+                        orient="horizontal">
                <radio id="calendar-day-view-button"
-                    label="&calendar.day.button.label;"
-                    tooltiptext="&calendar.day.button.tooltip;"
-                    calview="day"
-                    observes="calendar_day-view_command"/>
+                      label="&calendar.day.button.label;"
+                      tooltiptext="&calendar.day.button.tooltip;"
+                      calview="day"
+                      observes="calendar_day-view_command"/>
                <radio id="calendar-week-view-button"
-                    label="&calendar.week.button.label;"
-                    tooltiptext="&calendar.week.button.tooltip;"
-                    calview="week"
-                    observes="calendar_week-view_command"/>
+                      label="&calendar.week.button.label;"
+                      tooltiptext="&calendar.week.button.tooltip;"
+                      calview="week"
+                      observes="calendar_week-view_command"/>
                <radio id="calendar-multiweek-view-button"
-                    label="&calendar.multiweek.button.label;"
-                    tooltiptext="&calendar.multiweek.button.tooltip;"
-                    calview="multiweek"
-                    observes="calendar_multiweek-view_command"/>
+                      label="&calendar.multiweek.button.label;"
+                      tooltiptext="&calendar.multiweek.button.tooltip;"
+                      calview="multiweek"
+                      observes="calendar_multiweek-view_command"/>
                <radio id="calendar-month-view-button"
-                    label="&calendar.month.button.label;"
-                    tooltiptext="&calendar.month.button.tooltip;"
-                    calview="month"
-                    observes="calendar_month-view_command"/>
+                      label="&calendar.month.button.label;"
+                      tooltiptext="&calendar.month.button.tooltip;"
+                      calview="month"
+                      observes="calendar_month-view_command"/>
             </radiogroup>
             <box class="navigation-bottombox"/>
-         </hbox>
+         </vbox>
          <vbox>
            <vbox flex="1" class="navigation-spacer-box"/>
            <hbox class="navigation-bottombox"/>
          </vbox>
        </hbox>
        <deck flex="1"
             id="view-deck"
             persist="selectedIndex">
--- a/calendar/base/themes/common/calendar-views.css
+++ b/calendar/base/themes/common/calendar-views.css
@@ -892,30 +892,26 @@ agenda-richlist-item[status="CANCELLED"]
 }
 
 .navigation-spacer-box {
     min-width: 15px;
     border-bottom: 1px solid var(--calview-border-bottom-color);
 }
 
 radio[calview] {
+    -moz-appearance: none;
+    min-width: unset;
     border-left: 1px solid var(--calview-border-color);
     border-right: 1px solid var(--calview-border-color);
     border-bottom: 1px solid var(--calview-border-bottom-color);
-    border-top-left-radius: 0;
-    border-top-right-radius: 0;
-    margin-top: 0;
+    margin: 0;
     padding: 3px 6px;
     -moz-user-focus: normal;
     background-color: transparent;
     font-size: 14px;
-
-    position: relative;
-    -moz-appearance: tab;
-    min-width: unset;
 }
 
 radio[calview]:not(:first-child) {
     margin-inline-start: -1px;
 }
 
 
 radio[calview][selected="true"] {