Bug 1424602 - Restore suite Preferences bindings/styles after their removal in bug 1379338: Part 1 (restore bindings). r=IanN.
authorstefanh@inbox.com
Tue, 26 Dec 2017 21:46:42 +0100
changeset 22993 5087b6ba1eeb6a82b31c6f1d39105296ebcf47df
parent 22992 ea396b8000c33aafb56d0db1535aae216700a017
child 22994 6f7be81e3c4eb706b23d4ca3799cf7a78b4d79ad
push id13918
push userstefanh@inbox.com
push dateSat, 06 Jan 2018 00:22:40 +0000
treeherdercomm-central@8afc685a7b48 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersIanN
bugs1424602, 1379338
Bug 1424602 - Restore suite Preferences bindings/styles after their removal in bug 1379338: Part 1 (restore bindings). r=IanN.
suite/common/bindings/prefwindow.xml
suite/common/communicator.css
suite/common/jar.mn
--- a/suite/common/bindings/prefwindow.xml
+++ b/suite/common/bindings/prefwindow.xml
@@ -62,17 +62,17 @@
 ]>
 
 <bindings id="prefwindowBindings"
           xmlns="http://www.mozilla.org/xbl"
           xmlns:xbl="http://www.mozilla.org/xbl"
           xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
 
   <binding id="prefwindow"
-           extends="chrome://global/content/bindings/preferences.xml#prefwindow">
+           extends="chrome://communicator/content/bindings/preferences.xml#prefwindow">
     <resources>
       <stylesheet src="chrome://communicator/skin/preferences.css"/>
     </resources>
 
     <!-- The only difference between the following <content> and its toolkit
          ancestor is the help button and the 'navTrees' <vbox> before the 'paneDeck'! -->
     <content dlgbuttons="accept,cancel" persist="lastSelected screenX screenY"
              closebuttonlabel="&preferencesCloseButton.label;"
@@ -491,17 +491,17 @@
           event.preventDefault();
         }
       ]]>
       </handler>
     </handlers>
   </binding>
 
   <binding id="prefpane"
-           extends="chrome://global/content/bindings/preferences.xml#prefpane">
+           extends="chrome://communicator/content/bindings/preferences.xml#prefpane">
     <resources>
       <stylesheet src="chrome://communicator/skin/preferences.css"/>
     </resources>
 
     <handlers>
       <handler event="paneload">
       <![CDATA[
         // Since all <prefpane>s now share the same global document, their
--- a/suite/common/communicator.css
+++ b/suite/common/communicator.css
@@ -100,22 +100,57 @@ toolbar > toolbarpaletteitem > toolbarit
 .menubar-items {
   -moz-box-orient: vertical; /* for flex hack */
 }
 
 .menubar-items > menubar {
   -moz-box-flex: 1; /* make menu items expand to fill toolbar height */
 }
 
+prefwindow,
+prefwindow:root,
+prefpane {
+  -moz-box-orient: vertical;
+}
+
+prefwindow[type="child"] > .paneDeckContainer {
+  overflow: -moz-hidden-unscrollable;
+}
+
+prefwindow[type="child"] > prefpane > .content-box {
+  -moz-box-flex: 1;
+  overflow: -moz-hidden-unscrollable;
+}
+
+preferences {
+  -moz-binding: url("chrome://communicator/content/bindings/preferences.xml#preferences");
+  visibility: collapse;
+}
+
+preference {
+  -moz-binding: url("chrome://communicator/content/bindings/preferences.xml#preference");
+  visibility: collapse;
+}
+
+radio[pane] {
+  -moz-binding: url("chrome://communicator/content/bindings/preferences.xml#panebutton") !important;
+  -moz-box-orient: vertical;
+  -moz-box-align: center;
+}
+
+prefwindow[chromehidden~="toolbar"] .chromeclass-toolbar {
+  display: none;
+}
+
 prefwindow[xpfe="false"] {
-  -moz-binding: url("chrome://global/content/bindings/preferences.xml#prefwindow");
+  -moz-binding: url("chrome://communicator/content/bindings/preferences.xml#prefwindow");
 }
 
 prefpane[xpfe="false"] {
-  -moz-binding: url("chrome://global/content/bindings/preferences.xml#prefpane");
+  -moz-binding: url("chrome://communicator/content/bindings/preferences.xml#prefpane");
 }
 
 findbar[xpfe="false"] {
   -moz-binding: url("chrome://global/content/bindings/findbar.xml#findbar");
 }
 
 prefwindow[xpfe="false"] > .paneDeckContainer,
 prefpane[xpfe="false"] > .content-box {
--- a/suite/common/jar.mn
+++ b/suite/common/jar.mn
@@ -107,16 +107,17 @@ comm.jar:
    content/communicator/platformCommunicatorOverlay.xul             (unix/platformCommunicatorOverlay.xul)
 #endif
 #endif
    content/communicator/autocomplete.css                            (autocomplete/autocomplete.css)
    content/communicator/bindings/findbar.xml                        (bindings/findbar.xml)
    content/communicator/bindings/general.xml                        (bindings/general.xml)
    content/communicator/bindings/generalBindings.xml                (../../common/bindings/generalBindings.xml)
    content/communicator/bindings/notification.xml                   (bindings/notification.xml)
+*  content/communicator/bindings/preferences.xml                    (../../common/bindings/preferences.xml)
    content/communicator/bindings/toolbar.xml                        (bindings/toolbar.xml)
 *  content/communicator/bindings/prefwindow.xml                     (bindings/prefwindow.xml)
    content/communicator/bookmarks/bm-panel.js                       (bookmarks/bm-panel.js)
    content/communicator/bookmarks/bm-panel.xul                      (bookmarks/bm-panel.xul)
    content/communicator/bookmarks/bm-props.js                       (bookmarks/bm-props.js)
    content/communicator/bookmarks/bm-props.xul                      (bookmarks/bm-props.xul)
 # Provide another URI for the bookmark properties dialog so we can persist the attributes separately
 % override chrome://communicator/content/bookmarks/bm-props2.xul chrome://communicator/content/bookmarks/bm-props.xul