Bug 1764808 follow-up - Add complete fluent string names in comments. rs=me DONTBUILD
authorGeoff Lankow <geoff@darktrojan.net>
Thu, 19 May 2022 16:56:01 +1200
changeset 35774 4c643239473569036b1fb304baafc7aa6b15411e
parent 35773 6c2b6733806cc4879b187b0c7dfcf21314158589
child 35775 0aeb0dc79b208e20495b2e0a3ecc5fa65fcd5746
push id19936
push usergeoff@darktrojan.net
push dateThu, 19 May 2022 04:56:27 +0000
treeherdercomm-central@4c6432394735 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1764808
Bug 1764808 follow-up - Add complete fluent string names in comments. rs=me DONTBUILD
mail/components/addrbook/content/aboutAddressBook.js
--- a/mail/components/addrbook/content/aboutAddressBook.js
+++ b/mail/components/addrbook/content/aboutAddressBook.js
@@ -1229,16 +1229,24 @@ var cardsPane = {
       header.classList.add("table-header");
       header.classList.add(`${column.toLowerCase()}-column`);
       header.value = column;
       header.hidden = !shown;
       document.l10n.setAttributes(
         header,
         `about-addressbook-column-header-${column.toLowerCase()}`
       );
+      // about-addressbook-column-header-generatedname
+      // about-addressbook-column-header-emailaddresses
+      // about-addressbook-column-header-phonenumbers
+      // about-addressbook-column-header-addresses
+      // about-addressbook-column-header-title
+      // about-addressbook-column-header-department
+      // about-addressbook-column-header-organization
+      // about-addressbook-column-header-addrbook
 
       if (column == "GeneratedName") {
         continue;
       }
 
       let menuitem = this.sortContext.insertBefore(
         document.createXULElement("menuitem"),
         separator
@@ -1246,16 +1254,24 @@ var cardsPane = {
       menuitem.setAttribute("type", "checkbox");
       menuitem.setAttribute("name", "toggle");
       menuitem.setAttribute("value", column);
       menuitem.setAttribute("closemenu", "none");
       document.l10n.setAttributes(
         menuitem,
         `about-addressbook-column-label-${column.toLowerCase()}`
       );
+      // about-addressbook-column-label-generatedname
+      // about-addressbook-column-label-emailaddresses
+      // about-addressbook-column-label-phonenumbers
+      // about-addressbook-column-label-addresses
+      // about-addressbook-column-label-title
+      // about-addressbook-column-label-department
+      // about-addressbook-column-label-organization
+      // about-addressbook-column-label-addrbook
 
       if (shown) {
         menuitem.setAttribute("checked", "true");
       }
     }
 
     this.searchInput.addEventListener("command", this);
     this.sortButton.addEventListener("click", this);