Bug 500687 - "reply-all key binding shouldn't be disabled, even in 1-1 messages" [r=mkmelin+mozilla]
authorBlake Winton <bwinton@latte.ca>
Thu, 02 Jul 2009 20:24:47 +0100
changeset 2999 42f0ff4958e0704efa7eb95b43465fa8c602e0d2
parent 2998 a8e7c2927fafc0d21040d8f53bda12e9c3f71e17
child 3000 fac5602f2febad8a11587a4ee244cd279de1d8d4
push id2433
push userbugzilla@standard8.plus.com
push dateThu, 02 Jul 2009 19:25:47 +0000
treeherdercomm-central@42f0ff4958e0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmkmelin
bugs500687
Bug 500687 - "reply-all key binding shouldn't be disabled, even in 1-1 messages" [r=mkmelin+mozilla]
mail/base/content/mail3PaneWindowCommands.js
mail/base/content/messageWindow.js
--- a/mail/base/content/mail3PaneWindowCommands.js
+++ b/mail/base/content/mail3PaneWindowCommands.js
@@ -317,20 +317,19 @@ var DefaultController =
             whichText = "valueSelection";
           goSetMenuValue(command, whichText);
           goSetAccessKey(command, whichText + "AccessKey");
         }
         if (GetNumSelectedMessages() > 0)
         {
           if (!gFolderDisplay.getCommandStatus(nsMsgViewCommandType.cmdRequiringMsgBody))
             return false;
-          if (command == "cmd_reply" || command == "button_reply")
+          if (command == "cmd_reply" || command == "button_reply" ||
+              command == "cmd_replyall" ||command == "button_replyall")
             return IsReplyEnabled();
-          if (command == "cmd_replyall" || command == "button_replyall")
-            return IsReplyAllEnabled();
           if (command == "cmd_replylist" || command == "button_replylist")
             return IsReplyListEnabled();
           return true;
         }
         return false;
       case "cmd_printpreview":
         if (GetNumSelectedMessages() == 1)
           return gFolderDisplay.getCommandStatus(nsMsgViewCommandType.cmdRequiringMsgBody);
--- a/mail/base/content/messageWindow.js
+++ b/mail/base/content/messageWindow.js
@@ -764,20 +764,19 @@ var MessageWindowController =
         return (!gFolderDisplay.view.isNewsFolder);
       case "button_archive":
         var folder = gFolderDisplay.displayedFolder;
         return folder &&
           !(IsSpecialFolder(folder, Components.interfaces.nsMsgFolderFlags.Archive,
                             true));
       case "cmd_reply":
       case "button_reply":
-        return gFolderDisplay.selectedMessage && IsReplyEnabled();
       case "cmd_replyall":
       case "button_replyall":
-        return gFolderDisplay.selectedMessage && IsReplyAllEnabled();
+        return gFolderDisplay.selectedMessage && IsReplyEnabled();
       case "cmd_replylist":
       case "button_replylist":
         return gFolderDisplay.selectedMessage && IsReplyListEnabled();
       case "cmd_archive":
       case "cmd_replySender":
       case "cmd_replyGroup":
       case "cmd_forward":
       case "button_forward":