Bug 471014 - Remove useless unmoving throbbers in compose and addressbook windows, r=Standard8
authorPhil Ringnalda <philringnalda@gmail.com>
Mon, 29 Dec 2008 12:36:33 -0800
changeset 1510 2854a16a867f
parent 1509 2c97f3a14679
child 1511 f8add3a46947
push id1203
push userphilringnalda@gmail.com
push dateMon, 29 Dec 2008 20:37:03 +0000
treeherdercomm-central@2854a16a867f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersStandard8
bugs471014
Bug 471014 - Remove useless unmoving throbbers in compose and addressbook windows, r=Standard8
mail/components/addrbook/content/addressbook.xul
mail/components/compose/content/messengercompose.xul
mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd
mail/locales/en-US/chrome/messenger/messengercompose/messengercompose.dtd
mail/themes/pinstripe/mail/compose/messengercompose.css
--- a/mail/components/addrbook/content/addressbook.xul
+++ b/mail/components/addrbook/content/addressbook.xul
@@ -135,17 +135,16 @@
     <command id="Tasks:Mail" oncommand="toMessengerWindow();"/>
 #endif
     <command id="cmd_CustomizeABToolbar"
              oncommand="CustomizeMailToolbar('ab-toolbox', 'CustomizeABToolbar')"/>
 </commandset>
 
 <broadcasterset id="abBroadcasters">
   <!-- Edit Menu -->
-  <broadcaster id="broadcaster-throbber" busy="false"/>
   <broadcaster id="button_delete" disabled="true"/>
 </broadcasterset>
 
 <keyset id="tasksKeys">
   <!-- File Menu -->
 #ifdef XP_MACOSX
   <key id="key_newMessage" key="&newMessageCmd.key;" modifiers="accel,shift" oncommand="AbNewMessage()"/>
 #else
@@ -248,17 +247,17 @@
             accesskey="&customizeToolbar.accesskey;"/>
 </popup>
 
 <toolbox id="ab-toolbox" class="toolbox-top" mode="full">
   <toolbar type="menubar" id="addrbook-toolbar-menubar2" class="chromeclass-menubar" customizable="true"
 #ifdef XP_MACOSX
            defaultset="menubar-items"
 #else
-          defaultset="menubar-items,spring,throbber-box"
+          defaultset="menubar-items,spring"
 #endif
            context="toolbar-context-menu" mode="icons">
 
    <toolbaritem id="menubar-items" align="center">
      <menubar id="mail-menubar" style="border:0px;padding:0px;margin:0px;-moz-appearance:none">
         <menu id="menu_File" label="&fileMenu.label;" accesskey="&fileMenu.accesskey;">
 #ifdef XP_MACOSX
             <menupopup id="menu_FilePopup" onpopupshowing="onOSXFileMenuInit();">
@@ -532,20 +531,16 @@
                      oncommand="goDoCommand('button_edit');"/>
       <toolbarbutton class="toolbarbutton-1" id="button-newmessage" label="&newmsgButton.label;" tooltiptext="&newmsgButton.tooltip;" oncommand="AbNewMessage();"/>
       <toolbarbutton class="toolbarbutton-1" id="button-newim" label="&newIM.label;" tooltiptext="&newIM.tooltip;" oncommand="AbIMSelected();"/>
       <toolbarbutton class="toolbarbutton-1" id="button-abdelete"
                      observes="button_delete" label="&deleteButton2.label;"
                      tooltiptext="&deleteButton2.tooltip;"
                      oncommand="goDoCommand('button_delete');"/>
 
-      <toolbaritem id="throbber-box" title="&throbberItem.title;" align="center" pack="center">
-        <button id="navigator-throbber" disabled="true"/>
-      </toolbaritem>
-
       <toolbaritem id="search-container" title="&searchItem.title;" align="center" class="chromeclass-toolbar-additional">
         <textbox id="searchInput" flex="1" timeout="800"
                  onfocus="onSearchInputFocus(event);"
                  onblur="onSearchInputBlur(event);"
                  clickSelectsAll="true" oncommand="onEnterInSearchBar();"
                  chromedir="&locale.dir;">
           <button id="quick-search-button" type="menu" chromedir="&locale.dir;">
             <menupopup id="quick-search-menupopup" value="0" persist="value" popupalign="topleft" popupanchor="bottomleft">
@@ -558,17 +553,17 @@
   <!-- toolbar -->
   <toolbar id="ab-bar2" class="toolbar-primary chromeclass-toolbar"
            toolbarname="&showAbToolbarCmd.label;"
            accesskey="&showAbToolbarCmd.accesskey;"
            fullscreentoolbar="true" mode="full"
            customizable="true"
            context="toolbar-context-menu"
 #ifdef XP_MACOSX
-           defaultset="button-newcard,button-newlist,spacer,button-editcard,button-newmessage,spacer,button-abdelete,spring,search-container,throbber-box">
+           defaultset="button-newcard,button-newlist,spacer,button-editcard,button-newmessage,spacer,button-abdelete,spring,search-container">
 #else
            defaultset="button-newcard,button-newlist,separator,button-editcard,button-newmessage,separator,button-abdelete,spring,search-container">
 #endif
    </toolbar>
    <toolbarset id="customToolbars" context="toolbar-context-menu"/>
   </toolbox>
 
   <!-- The main address book three pane -->
--- a/mail/components/compose/content/messengercompose.xul
+++ b/mail/components/compose/content/messengercompose.xul
@@ -175,17 +175,16 @@
   <command id="Tasks:AddressBook" oncommand="toAddressBook();"/>
 #endif
 
   <command id="cmd_CustomizeComposeToolbar"
            oncommand="CustomizeMailToolbar('compose-toolbox', 'CustomizeComposeToolbar')"/>
 </commandset>
 
 <broadcasterset id="composeBroadcasters">
-  <broadcaster id="Editor:Throbber" busy="false"/>
   <broadcaster id="args" value="editorType=default"/>
   <broadcaster id="viewAddressPicker" autoCheck="false" type="checkbox" oncommand="toggleAddressPicker();"/>
 </broadcasterset>
 
 <keyset id="tasksKeys">
   <!-- File Menu -->
 #ifdef XP_MACOSX
   <key id="key_newMessage" key="&newMessage.key;" oncommand="goOpenNewMessage();" modifiers="accel,shift"/>
@@ -303,17 +302,17 @@
   <toolbox id="compose-toolbox" class="toolbox-top" mode="full">
 
   <!-- Menu -->
   <!-- if you change the id of the menubar, be sure to update mailCore.js::CustomizeMailToolbar and MailToolboxCustomizeDone -->
   <toolbar type="menubar" id="compose-toolbar-menubar2" class="chromeclass-menubar" customizable="true"
 #ifdef XP_MACOSX
            defaultset="menubar-items"
 #else
-          defaultset="menubar-items,spring,throbber-box"
+          defaultset="menubar-items,spring"
 #endif
            context="toolbar-context-menu" mode="full">
 
      <toolbaritem id="menubar-items" align="center">
       <menubar id="mail-menubar" style="border:0px;padding:0px;margin:0px;-moz-appearance:none">
       <menu id="menu_File" label="&fileMenu.label;" accesskey="&fileMenu.accesskey;">
         <menupopup id="menu_FilePopup">
           <menu id="menu_New" label="&newMenu.label;" accesskey="&newMenu.accesskey;">
@@ -599,27 +598,23 @@
           <menuitem name="priority" label="&highPriorityCmd.label;"    value="High"     id="list_priority_high"/>
           <menuitem name="priority" label="&normalPriorityCmd.label;"  value="Normal"   id="list_priority_normal"/>
           <menuitem name="priority" label="&lowPriorityCmd.label;"     value="Low"      id="list_priority_low"/>
           <menuitem name="priority" label="&lowestPriorityCmd.label;"  value="Lowest"   id="list_priority_lowest"/>
         </menupopup>
       </menulist>
     </toolbaritem>
 
-    <toolbaritem id="throbber-box" title="&throbberItem.title;" align="center" pack="center">
-      <button id="navigator-throbber" disabled="true"/>
-    </toolbaritem>
-
   </toolbarpalette>
   <toolbar id="composeToolbar2" class="toolbar-primary chromeclass-toolbar"
            toolbarname="&showCompositionToolbarCmd.label;"
            accesskey="&showCompositionToolbarCmd.accesskey;"
            fullscreentoolbar="true" mode="full"
 #ifdef XP_MACOSX
-           defaultset="button-send,separator,button-address,spellingButton,button-attach,button-security,button-save,spring,throbber-box"
+           defaultset="button-send,separator,button-address,spellingButton,button-attach,button-security,button-save,spring"
 #else
            defaultset="button-send,separator,button-address,spellingButton,button-attach,button-security,button-save"
 #endif
            customizable="true" context="toolbar-context-menu">
   </toolbar>
 
   <toolbarset id="customToolbars" context="toolbar-context-menu"/>
   </toolbox>
--- a/mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd
+++ b/mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd
@@ -123,17 +123,16 @@
 <!ENTITY editButton2.label                              "Properties">
 <!ENTITY editButton2.accesskey                          "P">
 <!ENTITY newmsgButton.label                             "Write">
 <!ENTITY newmsgButton.accesskey                         "W">
 <!ENTITY newIM.label                                    "Instant Message">
 <!ENTITY newIM.accesskey                                "I">
 <!ENTITY deleteButton2.label                            "Delete">
 <!ENTITY deleteButton2.accesskey                        "D">
-<!ENTITY throbberItem.title                             "Activity Indicator">
 
 <!-- Address Book Toolbar Tooltips -->
 <!ENTITY newContactButton.tooltip                       "Create a new address book contact">
 <!ENTITY newlistButton.tooltip                          "Create a new list">
 <!ENTITY editButton2.tooltip                            "Edit the selected item">
 <!ENTITY newmsgButton.tooltip                           "Send a mail message">
 <!ENTITY newIM.tooltip                                  "Send an instant message or chat">
 <!ENTITY deleteButton2.tooltip                           "Delete selected item">
--- a/mail/locales/en-US/chrome/messenger/messengercompose/messengercompose.dtd
+++ b/mail/locales/en-US/chrome/messenger/messengercompose/messengercompose.dtd
@@ -180,17 +180,16 @@
 
 <!-- Mail Toolbar -->
 <!ENTITY sendButton.label "Send">
 <!ENTITY quoteButton.label "Quote">
 <!ENTITY addressButton.label "Contacts">
 <!ENTITY attachButton.label "Attach">
 <!ENTITY spellingButton.label "Spelling">
 <!ENTITY saveButton.label "Save">
-<!ENTITY throbberItem.title "Activity Indicator">
 
 <!-- Mail Toolbar Tooltips -->
 <!ENTITY sendButton.tooltip "Send this message now"> 
 <!ENTITY sendlaterButton.tooltip "Send this message later"> 
 <!ENTITY quoteButton.tooltip "Quote the previous message"> 
 <!ENTITY addressButton.tooltip "Select a recipient from an Address Book"> 
 <!ENTITY attachButton.tooltip "Include an attachment"> 
 <!ENTITY saveButton.tooltip "Save this message"> 
--- a/mail/themes/pinstripe/mail/compose/messengercompose.css
+++ b/mail/themes/pinstripe/mail/compose/messengercompose.css
@@ -900,20 +900,16 @@ sidebarheader {
          background-color: #ececec;
 }
 
 #sidebar-title {
   font: icon;
   color: #000;
 }
 
-#sidebar-throbber[loading="true"] {
-  list-style-image: url("chrome://global/skin/icons/loading_16.png");
-}
-
 #searchInput #sidebar {
   -moz-appearance: textfield !important;
         margin: 3px;
 }
 
 #searchInput > .textbox-input-box #sidebar {
   background-image: none !important;
 }