Bug 752206 - event dialog is not non-modal anymore. r=mmecca, ui-r=paenglab
authorAlexandre Demers <alexandre.f.demers@gmail.com>
Mon, 28 May 2012 00:49:04 -0400
changeset 10294 0094bc46084a50a9d11db9e25cba0330e3ea378c
parent 10293 3301cdb8b397d34ef7a2c0e12f6828c46bacacb3
child 10295 bb6109ec76bf75270f9a8e53f3a4cbf106bee589
push id7797
push usermatthew.mecca@gmail.com
push dateMon, 28 May 2012 04:55:42 +0000
treeherdercomm-central@0094bc46084a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmmecca, paenglab
bugs752206
Bug 752206 - event dialog is not non-modal anymore. r=mmecca, ui-r=paenglab
calendar/base/content/calendar-item-editing.js
--- a/calendar/base/content/calendar-item-editing.js
+++ b/calendar/base/content/calendar-item-editing.js
@@ -359,24 +359,26 @@ function openEventDialog(calendarItem, c
     if (isCalendarWritable(calendar)
         && (mode == "new"
             || (mode == "modify" && !isInvitation && userCanModifyItem((calendarItem))))) {
         url = "chrome://calendar/content/calendar-event-dialog.xul";
     } else {
         url = "chrome://calendar/content/calendar-summary-dialog.xul";
     }
 
+    // reminder: event dialog should not be modal (cf bug 122671)
     var features;
+    // keyword "dependent" should not be used (cf bug 752206)
     if (Services.appinfo.OS == "WINNT") {
-        features = "chrome,titlebar,resizable,dependent";
+        features = "chrome,titlebar,resizable";
     } else if (Services.appinfo.OS == "Darwin") {
         features = "chrome,titlebar,resizable,minimizable=no";
     } else {
         // All other targets, mostly Linux flavors using gnome.
-        features = "chrome,titlebar,resizable,dependent,minimizable=no,dialog=no";
+        features = "chrome,titlebar,resizable,minimizable=no,dialog=no";
     }
 
     openDialog(url, "_blank", features, args);
 }
 
 /**
  * Prompts the user how the passed item should be modified. If the item is an
  * exception or already a parent item, the item is returned without prompting.