Bug 1290477 - Disable l10n dashboard release sanity checks r=Callek
authorRail Aliiev <rail@mozilla.com>
Thu, 11 Aug 2016 10:06:33 -0400
changeset 6950 f6c55a97b7054cbbaf838c3c403b1d98f1c34bd2
parent 6949 2a9d6ef50f0e54d3e5d832d4f950cc30022ae335
child 6952 8686d725cd8c93eddbfd7ec1fb61b1fa926ecec0
push id5184
push userraliiev@mozilla.com
push dateThu, 11 Aug 2016 14:18:42 +0000
reviewersCallek
bugs1290477
Bug 1290477 - Disable l10n dashboard release sanity checks r=Callek MozReview-Commit-ID: 5LbY5ccTmU5
buildfarm/release/release-runner.py
buildfarm/release/releasetasks_graph_gen.py
lib/python/kickoff/__init__.py
lib/python/kickoff/sanity.py
--- a/buildfarm/release/release-runner.py
+++ b/buildfarm/release/release-runner.py
@@ -360,17 +360,16 @@ def main(options):
                     l10n_platforms=branchConfig['l10n_release_platforms'],
                     l10n_changesets=l10n_changesets
                 ),
                 "en_US_config": get_en_US_config(
                     index=index, product=release["product"], branch=branch,
                     revision=release['mozillaRevision'],
                     platforms=branchConfig['release_platforms']
                 ),
-                "dashboard_check": release['dashboardCheck'],
                 "verifyConfigs": {},
                 "balrog_api_root": branchConfig["balrog_api_root"],
                 "funsize_balrog_api_root": branchConfig["funsize_balrog_api_root"],
                 "balrog_username": balrog_username,
                 "balrog_password": balrog_password,
                 "beetmover_aws_access_key_id": beetmover_aws_access_key_id,
                 "beetmover_aws_secret_access_key": beetmover_aws_secret_access_key,
                 # TODO: stagin specific, make them configurable
--- a/buildfarm/release/releasetasks_graph_gen.py
+++ b/buildfarm/release/releasetasks_graph_gen.py
@@ -44,17 +44,16 @@ def main(release_runner_config, release_
         "signing_class": "release-signing",  # TODO: stagin specific, make them configurable
 
         # ship-it items
         "version": release_config["version"],
         "revision": release_config["mozilla_revision"],
         "mozharness_changeset": release_config["mozharness_changeset"] or release_config["mozilla_revision"],
         "buildNumber": release_config["build_number"],
         "l10n_changesets": release_config["l10n_changesets"],
-        "dashboard_check": False,
 
         # was branchConfig items
         "funsize_balrog_api_root": release_config["funsize_balrog_api_root"],
         "balrog_api_root": release_config["balrog_api_root"],
         "build_tools_repo_path": release_config['build_tools_repo_path'],
         "tuxedo_server_url": release_config['tuxedo_server_url'],
         "uptake_monitoring_enabled": release_config['uptake_monitoring_enabled'],
         "beetmover_candidates_bucket": release_config["beetmover_candidates_bucket"],
--- a/lib/python/kickoff/__init__.py
+++ b/lib/python/kickoff/__init__.py
@@ -228,17 +228,17 @@ def bump_version(version):
         v.append("0")
     v[-1] = str(int(v[-1]) + 1)
     return split_by.join(v) + suffix
 
 
 def make_task_graph_strict_kwargs(appVersion, balrog_api_root, balrog_password, balrog_username,
                                   beetmover_aws_access_key_id, beetmover_aws_secret_access_key,
                                   beetmover_candidates_bucket, bouncer_enabled, branch, buildNumber,
-                                  build_tools_repo_path, checksums_enabled, dashboard_check, en_US_config,
+                                  build_tools_repo_path, checksums_enabled, en_US_config,
                                   extra_balrog_submitter_params, final_verify_channels,
                                   final_verify_platforms, uptake_monitoring_platforms,
                                   funsize_balrog_api_root, l10n_config,
                                   l10n_changesets, mozharness_changeset, next_version,
                                   partial_updates, partner_repacks_platforms,
                                   postrelease_bouncer_aliases_enabled, uptake_monitoring_enabled,
                                   postrelease_version_bump_enabled,
                                   product, public_key, push_to_candidates_enabled,
@@ -256,17 +256,16 @@ def make_task_graph_strict_kwargs(appVer
         beetmover_aws_access_key_id=beetmover_aws_access_key_id,
         beetmover_aws_secret_access_key=beetmover_aws_secret_access_key,
         beetmover_candidates_bucket=beetmover_candidates_bucket,
         bouncer_enabled=bouncer_enabled,
         branch=branch,
         buildNumber=buildNumber,
         build_tools_repo_path=build_tools_repo_path,
         checksums_enabled=checksums_enabled,
-        dashboard_check=dashboard_check,
         en_US_config=en_US_config,
         final_verify_channels=final_verify_channels,
         final_verify_platforms=final_verify_platforms,
         uptake_monitoring_platforms=uptake_monitoring_platforms,
         funsize_balrog_api_root=funsize_balrog_api_root,
         l10n_changesets=l10n_changesets,
         l10n_config=l10n_config,
         mozharness_changeset=mozharness_changeset,
--- a/lib/python/kickoff/sanity.py
+++ b/lib/python/kickoff/sanity.py
@@ -359,41 +359,16 @@ class ReleaseSanitizerTestSuite(OpsMixin
             )
 
             try:
                 make_generic_head_request(locale_url)
             except requests.HTTPError:
                 err_msg = "Locale {locale} not found".format(locale=locale_url)
                 result.add_error(err_msg, sys.exc_info())
 
-    def test_l10n_dashboard(self, result):
-        """test_l10n method
-        Tests if l10n dashboard changesets match the current l10n changesets
-        """
-        log.info("Testing l10n dashboard changesets ...")
-        if not self.kwargs["dashboard_check"]:
-            log.info("Skipping l10n dashboard check")
-            return
-
-        try:
-            dash_changesets = get_l10_dashboard_changeset(self.version,
-                                                          self.product)
-        except requests.HTTPError as err:
-            err_msg = ("Failed to retrieve l10n dashboard changes for"
-                       " {product} product, version {version}. URL: {url}").format(
-                           product=self.product,
-                           version=self.version,
-                           url=err.request.url)
-            result.add_error(err_msg, sys.exc_info())
-            return
-
-        err_msg = ("Current ship-it changesets are not the same as the l10n"
-                   " dashboard changesets")
-        self.assertEqual(result, self.locales, dash_changesets, err_msg)
-
 
 class ReleaseSanitizerResult(object):
     """Aggregate exceptions result-object like. It's passed down in all
     ReleaseSanitizerTestSuite methods to collect all potential errors.
     This is usefule to avoid incremenatal fixes in release sanity
     """
     def __init__(self):
         self.errors = []