Bug 1501453 - Allow signing of *.msi r=aki SIGNING_SERVER
authorJustin Wood <Callek@gmail.com>
Wed, 24 Oct 2018 20:15:49 +0000
changeset 8464 854004a17e4a374b10b06b12b34f5bfa5d4bfcf5
parent 8463 5403bbf3cffa1a1b368c7119faf5421f1d088e5f
child 8465 0db2c26309fb12d170fb91bf344299e224d25f79
push id6187
push userjwood@mozilla.com
push dateWed, 24 Oct 2018 20:16:04 +0000
reviewersaki
bugs1501453
Bug 1501453 - Allow signing of *.msi r=aki Differential Revision: https://phabricator.services.mozilla.com/D9705
lib/python/signing/utils.py
--- a/lib/python/signing/utils.py
+++ b/lib/python/signing/utils.py
@@ -575,17 +575,17 @@ def shouldSign(filename, platform='win32
         'msvc*.dll',
     ]
     ext = os.path.splitext(filename)[1]
     b = os.path.basename(filename)
     if platform == 'mac':
         if b.endswith('.app'):
             return True
     elif platform in ('win32', 'win64'):
-        if ext in ('.dll', '.exe') and not any(fnmatch.fnmatch(b, p) for p in _dont_sign):
+        if ext in ('.dll', '.exe', '.msi') and not any(fnmatch.fnmatch(b, p) for p in _dont_sign):
             return True
     else:
         # We should never get here.
         log.debug("Invalid Platform: %s", platform)
     return False
 
 
 def getChkFile(filename):