Bug 1501141 - Handle N update verify configs properly in final verify
authorNick Thomas <nthomas@mozilla.com>
Tue, 23 Oct 2018 16:23:30 +1300
changeset 8463 5403bbf3cffa1a1b368c7119faf5421f1d088e5f
parent 8462 f48e358fe285b8973c6300d6592e27d206300d47
child 8464 854004a17e4a374b10b06b12b34f5bfa5d4bfcf5
push id6186
push usernthomas@mozilla.com
push dateTue, 23 Oct 2018 05:27:03 +0000
bugs1501141
Bug 1501141 - Handle N update verify configs properly in final verify
release/final-verification.sh
--- a/release/final-verification.sh
+++ b/release/final-verification.sh
@@ -257,17 +257,17 @@ update_xml_urls="$(mktemp -t update_xml_
 #
 # We keep a copy of each update.xml file retrieved in individual files.
 ####################################################################################
 
 
 # generate full list of update.xml urls, followed by patch types,
 # as defined in the specified config files - and write into "${update_xml_urls}" file
 aus_server="https://aus5.mozilla.org"
-for cfg_file in "${configs}"
+for cfg_file in "${configs[@]}"
 do
     line_no=0
     sed -e 's/localtest/cdntest/' "${cfg_file}" | while read config_line
     do
         let line_no++
         # to avoid contamination between iterations, reset variables
         # each loop in case they are not declared
         # aus_server is not "cleared" each iteration - to be consistent with previous behaviour of old
@@ -278,21 +278,31 @@ do
         do
             echo "${aus_server}/update/3/$product/$release/$build_id/$platform/$locale/$channel/default/default/default/update.xml?force=1" "${patch_types// /,}" "${cfg_file}" "${line_no}"
         done
     done
 done > "${update_xml_urls}"
 
 # download update.xml files and grab the mar urls from downloaded file for each patch type required
 cat "${update_xml_urls}" | cut -f1-2 -d' ' | sort -u | xargs -n2 "-P${MAX_PROCS}" ../get-update-xml.sh
+if [ "$?" != 0 ]; then
+    flush_logs
+    log "Error generating update requests"
+    exit 70
+fi
 
 flush_logs
 
 # download http header for each mar url
 find "${TMPDIR}" -name 'update_xml_to_mar.*' -type f | xargs cat | cut -f1-2 -d' ' | sort -u | xargs -n2 "-P${MAX_PROCS}" ../test-mar-url.sh
+if [ "$?" != 0 ]; then
+    flush_logs
+    log "Error HEADing mar urls"
+    exit 71
+fi
 
 flush_logs
 
 log ''
 log 'Stopping stopwatch...'
 STOP_TIME="$(date +%s)"
 
 number_of_failures="$(find "${TMPDIR}" -name 'failure.*' -type f | wc -l | sed 's/ //g')"