bug 1346422 - add new macapp signing format. r=rail
authorAki Sasaki <asasaki@mozilla.com>
Tue, 28 Mar 2017 12:41:01 -0700
changeset 7410 4a2b4e307fa8
parent 7409 2afcf469ddd3
child 7411 e31a5a15133c
push id5516
push userasasaki@mozilla.com
push dateTue, 28 Mar 2017 19:41:06 +0000
reviewersrail
bugs1346422
bug 1346422 - add new macapp signing format. r=rail
release/signing/signtool.py
--- a/release/signing/signtool.py
+++ b/release/signing/signtool.py
@@ -37,17 +37,17 @@ def is_authenticode_signed(filename):
     finally:
         if p:
             p.close()
 
 
 def main():
     allowed_formats = ("sha2signcode", "sha2signcodestub", "signcode",
                        "osslsigncode", "gpg", "mar", "mar_sha384", "dmg",
-                       "dmgv2", "jar", "emevoucher")
+                       "dmgv2", "macapp", "jar", "emevoucher")
 
     from optparse import OptionParser
     import random
     parser = OptionParser(__doc__)
     parser.set_defaults(
         hosts=[],
         cert=None,
         log_level=logging.INFO,
@@ -180,20 +180,20 @@ def main():
 
     buildValidatingOpener(options.cert)
     token = open(options.tokenfile, 'rb').read()
 
     for fmt in formats:
         urls = format_urls[fmt]
         random.shuffle(urls)
 
-        # The only difference between dmg and dmgv2 are the servers they use.
+        # The only difference between dmg, dmgv2, and macapp are the servers they use.
         # The server side code only understands "dmg" as a format, so we need
         # to translate this now that we've chosen our URLs
-        if fmt == "dmgv2":
+        if fmt in ("dmgv2", "macapp"):
             fmt = "dmg"
 
         log.debug("doing %s signing", fmt)
         log.debug("possible hosts are %s" % urls)
         files = []
         # We want to package the ".app" file in a tar for mac signing.
         if fmt == "dmg":
             for fd in args: