Bug 1200294 - we should get rid of minidump_stackwalk binaries in talos sources. r=jmaher
authorJulien Pagès <j.parkouss@gmail.com>
Mon, 31 Aug 2015 22:55:36 +0200
changeset 1005 be34538a5581
parent 1004 664caf91d1a6
child 1006 18be0ccfa48d
push id694
push userj.parkouss@gmail.com
push dateWed, 02 Sep 2015 15:00:59 +0000
reviewersjmaher
bugs1200294
Bug 1200294 - we should get rid of minidump_stackwalk binaries in talos sources. r=jmaher This removes minidump_stackwalk binaries, and let mozcrash rely on the env var MINIDUMP_STACKWALK.
talos/breakpad/linux/minidump_stackwalk
talos/breakpad/linux64/minidump_stackwalk
talos/breakpad/osx/minidump_stackwalk
talos/breakpad/osx64/minidump_stackwalk
talos/breakpad/win32/cyggcc_s-1.dll
talos/breakpad/win32/cygstdc++-6.dll
talos/breakpad/win32/cygwin1.dll
talos/breakpad/win32/minidump_stackwalk.exe
talos/ttest.py
deleted file mode 100755
index 85511c59f2c067c1c4885a0584700905efe720a0..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100755
index 2c447dc548160cad17446681cbf643c27fdc25da..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100755
index 86cfa484209578a1e94c0a9dd232b5609da9460d..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100755
index 86cfa484209578a1e94c0a9dd232b5609da9460d..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index c5e15cb214b51ca44715c43a51b0933ad7314239..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index ba99e3d7ad38be74014346669468c8b9d0e71c37..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index 317c51e3519ffc61f4a6d71b70515990d07c392b..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100755
index c64e3bb1bfd50c50e5a053e1d74c7cb245f6b031..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
--- a/talos/ttest.py
+++ b/talos/ttest.py
@@ -52,40 +52,20 @@ class TTest(object):
     def cleanupAndCheckForCrashes(self, browser_config, profile_dir,
                                   test_name):
         """cleanup browser processes and process crashes if found"""
 
         # cleanup processes
         ffprocess.cleanup_processes(self._pids,
                                     browser_config['browser_wait'])
 
-        # find stackwalk binary
-        if platform.system() in ('Windows', 'Microsoft'):
-            stackwalkpaths = ['win32', 'minidump_stackwalk.exe']
-        elif platform.system() == 'Linux':
-            # are we 64 bit?
-            if '64' in platform.architecture()[0]:
-                stackwalkpaths = ['linux64', 'minidump_stackwalk']
-            else:
-                stackwalkpaths = ['linux', 'minidump_stackwalk']
-        elif platform.system() == 'Darwin':
-            stackwalkpaths = ['osx', 'minidump_stackwalk']
-        else:
-            # no minidump_stackwalk available for your platform
-            return
-        stackwalkbin = os.path.join(os.path.dirname(__file__), 'breakpad',
-                                    *stackwalkpaths)
-        assert os.path.exists(stackwalkbin), \
-            "minidump_stackwalk binary not found: %s" % stackwalkbin
-
         # check for minidumps
         minidumpdir = os.path.join(profile_dir, 'minidumps')
         found = mozcrash.check_for_crashes(minidumpdir,
                                            browser_config['symbols_path'],
-                                           stackwalk_binary=stackwalkbin,
                                            test_name=test_name)
         mozfile.remove(minidumpdir)
 
         if found:
             raise TalosCrash("Found crashes after test run, terminating test")
 
     def testCleanup(self, browser_config, profile_dir, test_config):
         try: