Bug 1236951 - use WithProperties in case we actually have a revision - r=bustage
authorChris Cooper <ccooper@deadsquid.com>
Wed, 20 Jan 2016 09:14:34 -0500
changeset 4667 b049ab7ef9a7164ee825b7736337d0d65beae4ef
parent 4665 6368247d8c7a7662dea63e975d92f4a4ea38f99a
child 4668 ff375638929fa818ab9f5cfb05fa8962c45455ef
child 4671 dc9b1cf7b9e11e2ece16236df5e960e42ccd6a4c
push id3920
push usercoop@mozilla.com
push dateWed, 20 Jan 2016 14:14:46 +0000
reviewersbustage
bugs1236951
Bug 1236951 - use WithProperties in case we actually have a revision - r=bustage
process/factory.py
--- a/process/factory.py
+++ b/process/factory.py
@@ -4482,17 +4482,17 @@ class ScriptFactory(RequestSortingBuildF
             ))
             if scriptName.startswith('/'):
                 script_path = scriptName
             else:
                 script_path = 'scripts/%s' % scriptName
             self.addStep(SetProperty(
                 name='get_script_repo_revision',
                 property='script_repo_revision',
-                command=['echo', script_repo_revision],
+                command=['echo', WithProperties(script_repo_revision)],
                 workdir=".",
                 haltOnFailure=False,
             ))
         elif self.script_repo_cache:
             # all slaves bar win tests have a copy of hgtool on their path.
             # However, let's use runner's checkout version like we do for
             # script repo
             assert self.tools_repo_cache