Bug 1190860, fix valgrind by setting up mock before running tooltool, r=jlund
authorNick Thomas <nthomas@mozilla.com>
Wed, 27 Jan 2016 16:51:13 +1300 (2016-01-27)
changeset 4691 28864afc6409357f5204c87fa97cea98cae691f7
parent 4689 de981e55b123c4071774a525c195a6502219ef02
child 4692 877aa0ccb0dcb9a791de8efe505b4ac30b12c8b0
child 4694 c7d3fb99d114a394c30755d5a0f780dfb30b29e2
push id3937
push usernthomas@mozilla.com
push dateWed, 27 Jan 2016 03:52:32 +0000 (2016-01-27)
reviewersjlund
bugs1190860
Bug 1190860, fix valgrind by setting up mock before running tooltool, r=jlund
process/factory.py
--- a/process/factory.py
+++ b/process/factory.py
@@ -4639,24 +4639,16 @@ class ScriptFactory(RequestSortingBuildF
 
         if use_credentials_file:
             self.addStep(FileDownload(
                 mastersrc=os.path.join(os.getcwd(), 'BuildSlaves.py'),
                 slavedest='oauth.txt',
                 workdir='.',
                 flunkOnFailure=False,
             ))
-        if self.tooltool_manifest_src:
-            self.addStep(SetProperty(
-                name='set_toolsdir',
-                command=['bash', '-c', 'pwd'],
-                property='toolsdir',
-                workdir='scripts',
-            ))
-            self.addTooltoolStep(workdir='build')
         self.runScript()
         self.addCleanupSteps()
         self.reboot()
 
     def addCleanupSteps(self):
         # remove oauth.txt file, we don't wanna to leave keys lying around
         if self.use_credentials_file:
             self.addStep(ShellCommand(
@@ -4693,16 +4685,25 @@ class ScriptFactory(RequestSortingBuildF
                     ))
 
             self.addStep(MockInstall(
                 target=self.mock_target,
                 packages=self.mock_packages,
                 timeout=2700,
             ))
 
+        if self.tooltool_manifest_src:
+            self.addStep(SetProperty(
+                name='set_toolsdir',
+                command=['bash', '-c', 'pwd'],
+                property='toolsdir',
+                workdir='scripts',
+            ))
+            self.addTooltoolStep(workdir='build')
+
     def runScript(self, env=None):
         if not env:
             env = self.env
         self.preRunScript()
         self.addStep(MockCommand(
             name="run_script",
             command=self.cmd,
             env=env,