Bug 1065677: don't log master passwords to twistd.log; r=catlee production-0.8 FIREFOX_33_0b5_BUILD1 FIREFOX_33_0b5_RELEASE
authorDustin J. Mitchell <dustin@mozilla.com>
Thu, 18 Sep 2014 08:25:48 -0400
branchproduction-0.8
changeset 1116 6df02dbd315cc67351d8cbf1aa9a5c582fc53858
parent 1115 c67d637ffa55b2787027c64377076de523a9e431
child 1118 6b9a51a608fe6c2e8faf70db622d2eae64516c4f
push id880
push userdmitchell@mozilla.com
push dateThu, 18 Sep 2014 12:26:15 +0000
reviewerscatlee
bugs1065677
Bug 1065677: don't log master passwords to twistd.log; r=catlee
master/buildbot/db/dbspec.py
--- a/master/buildbot/db/dbspec.py
+++ b/master/buildbot/db/dbspec.py
@@ -256,26 +256,24 @@ class DBSpec(object):
         """
         Get an asynchronous (adbapi) connection pool for the specified
         database.
         """
 
         # add some connection keywords
         connkw = self.connkw.copy()
         connkw["cp_reconnect"] = True
-        connkw["cp_noisy"] = True
 
         # This disables sqlite's obsessive checks that a given connection is
         # only used in one thread; this is justified by the Twisted ticket
         # regarding the errors you get on connection shutdown if you do *not*
         # add this parameter: http://twistedmatrix.com/trac/ticket/3629
         if 'sqlite' in self.dbapiName:
             connkw['check_same_thread'] = False
-        log.msg("creating adbapi pool: %s %s %s" % \
-                (self.dbapiName, self.connargs, connkw))
+        log.msg("creating adbapi pool")
 
         # MySQL needs support for expiring idle connections
         if self.dbapiName == 'MySQLdb':
             return ExpiringConnectionPool(self.dbapiName, *self.connargs, **connkw)
         else:
             return RetryingConnectionPool(self.dbapiName, *self.connargs, **connkw)
 
     def get_maxidle(self):