Bug 1566358 - Update releases page to include 64-bit Windows and Linux platforms - fix issue with missing <p> tags in fieldset r=me
authorIan Neal <iann_cvs@blueyonder.co.uk>
Wed, 24 Jul 2019 21:02:50 +0100
changeset 1361 695b12b2d39a2c4bf99ee2fd84b87becbb9ad69f
parent 1360 b13d1e95b37f724df3614690f5a7d8742dc0f9cd
child 1362 5b9d4df758df791e51e8bc3056271a2a38c143e4
push id135
push useriann_cvs@blueyonder.co.uk
push dateWed, 24 Jul 2019 20:04:08 +0000
reviewersme
bugs1566358
Bug 1566358 - Update releases page to include 64-bit Windows and Linux platforms - fix issue with missing <p> tags in fieldset r=me
lib/downloads_fieldset.en.xml
lib/release.tmpl
--- a/lib/downloads_fieldset.en.xml
+++ b/lib/downloads_fieldset.en.xml
@@ -1,17 +1,17 @@
 <dropdowns>
-  <dropdown id="download_platform" label="Which operating system are you using?" aria="download_info">
+  <dropdown id="download_platform" label="Which operating system are you using?" aria="download_info" class="select-platform">
     <option value="win64" label="Windows x64" />
     <option value="win" label="Windows x86" />
     <option value="osx" label="macOS x64" />
     <option value="linux64" label="Linux x64" />
     <option value="linux" label="Linux x86" />
   </dropdown>
-  <dropdown id="download_language" label="Would you like to select a different language?" aria="download_info">
+  <dropdown id="download_language" label="Would you like to select a different language?" aria="download_info" class="select-language">
     <option value="zh-CN" label="Chinese (Simplified) — 中文 (简体)" />
     <option value="zh-TW" label="Chinese (Traditional) — 正體中文 (繁體)" />
     <option value="cs" label="Czech — Čeština" />
     <option value="nl" label="Dutch — Nederlands" />
     <option value="en-GB" label="English (British)" />
     <option value="en-US" label="English (US)" />
     <option value="fr" label="French — Français" />
     <option value="de" label="German — Deutsch" />
--- a/lib/release.tmpl
+++ b/lib/release.tmpl
@@ -155,21 +155,23 @@
 %]
 
 [% BLOCK downloads_fieldset;
      # vars that need to be set by caller or document:
      # dropdowns: set of dropdowns containing information for the selects
 
      "  <fieldset>\n";
      FOREACH dropdown IN dropdowns.dropdown;
-       "    <label for=\"$dropdown.id\" class=\"select-label\">$dropdown.label</label>\n";
-       "    <select id=\"$dropdown.id\" class=\"select-input\" aria-controls=\"$dropdown.aria\">\n";
+       "    <p class=\"$dropdown.class\">\n";
+       "      <label for=\"$dropdown.id\" class=\"select-label\">$dropdown.label</label>\n";
+       "      <select id=\"$dropdown.id\" class=\"select-input\" aria-controls=\"$dropdown.aria\">\n";
 
        FOREACH option IN dropdown.option;
-         "      <option value=\"$option.value\">$option.label</option>\n";
+         "        <option value=\"$option.value\">$option.label</option>\n";
        END;
 
-       "    </select>\n";
+       "      </select>\n";
+       "    </p>\n";
      END;
 
      "  </fieldset>\n";
    END;
 %]